[REVIEW]: MWRpy: A Python package for processing microwave radiometer data

editorialbot commented 6 months ago

Submitting author: !--author-handle-->@tobiasmarke@mengqi-z<!--end-editor-- Reviewers: @Subho07, @kvenkman Archive: 10.5281/zenodo.11614185

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/5fab8b696409397b3627aaf61da9406d"><img src="https://joss.theoj.org/papers/5fab8b696409397b3627aaf61da9406d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/5fab8b696409397b3627aaf61da9406d/status.svg)](https://joss.theoj.org/papers/5fab8b696409397b3627aaf61da9406d)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@Subho07 & @kvenkman, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mengqi-z know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @kvenkman

📝 Checklist for @Subho07

mengqi-z commented 5 months ago

@editorialbot recommend-accept

editorialbot commented 5 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 5 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.7973552 is OK
- 10.1175/BAMS-88-6-883 is OK
- 10.1175/BAMS-D-23-0064.1 is OK
- 10.21105/joss.02123 is OK
- 10.23919/URSIRSB.2004.7909438 is OK
- 10.1007/s42865-021-00033-w is OK
- 10.1109/TGRS.2006.888434 is OK
- 10.1029/2002RS002634 is OK
- 10.5194/amt-5-1121-2012 is OK
- 10.5194/gmd-17-2053-2024 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 5 months ago

:wave: @openjournals/ese-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5497, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

mengqi-z commented 5 months ago

@tobiasmarke Thank you for addressing all the comments from the reviewers!

@kvenkman @Subho07 Thank you for your reviews! I hope you enjoyed the process and look forward to working with you on future JOSS reviews.

kthyng commented 5 months ago

Hi! I'll take over now as Track Associate Editor in Chief to do some final submission editing checks. After these checks are complete, I will publish your submission!

[x] Are checklists all checked off?
[x] Check that version was updated and make sure the version from JOSS matches github and Zenodo.
[x] Check that software archive exists, has been input to JOSS, and title and author list match JOSS paper (or purposefully do not).
[x] Check paper.

kthyng commented 5 months ago

@tobiasmarke Paper looks good except please check the capitalization in your references. You can preserve capitalization by placing {} around characters/words in your .bib file. For example, "european" is not capitalized, but check for others.

tobiasmarke commented 5 months ago

@editorialbot generate pdf

editorialbot commented 5 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

tobiasmarke commented 5 months ago

@kthyng thank you for checking. The references are updated now.

kthyng commented 4 months ago

Ok everything is ready to go!

kthyng commented 4 months ago

@editorialbot accept

editorialbot commented 4 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 4 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Marke given-names: Tobias orcid: "https://orcid.org/0000-0001-7804-9056" - family-names: Löhnert given-names: Ulrich orcid: "https://orcid.org/0000-0002-9023-0269" - family-names: Tukiainen given-names: Simo orcid: "https://orcid.org/0000-0002-0651-4622" - family-names: Siipola given-names: Tuomas orcid: "https://orcid.org/0009-0004-7757-0893" - family-names: Pospichal given-names: Bernhard orcid: "https://orcid.org/0000-0001-9517-8300" contact: - family-names: Marke given-names: Tobias orcid: "https://orcid.org/0000-0001-7804-9056" doi: 10.5281/zenodo.11614185 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Marke given-names: Tobias orcid: "https://orcid.org/0000-0001-7804-9056" - family-names: Löhnert given-names: Ulrich orcid: "https://orcid.org/0000-0002-9023-0269" - family-names: Tukiainen given-names: Simo orcid: "https://orcid.org/0000-0002-0651-4622" - family-names: Siipola given-names: Tuomas orcid: "https://orcid.org/0009-0004-7757-0893" - family-names: Pospichal given-names: Bernhard orcid: "https://orcid.org/0000-0001-9517-8300" date-published: 2024-06-20 doi: 10.21105/joss.06733 issn: 2475-9066 issue: 98 journal: Journal of Open Source Software publisher: name: Open Journals start: 6733 title: "MWRpy: A Python package for processing microwave radiometer data" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06733" volume: 9 title: "MWRpy: A Python package for processing microwave radiometer data" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 4 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 4 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5517
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06733
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kthyng commented 4 months ago

Congratulations on your new publication @tobiasmarke! Many thanks to @mengqi-z and to reviewers @Subho07 and @kvenkman for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts.

editorialbot commented 4 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06733/status.svg)](https://doi.org/10.21105/joss.06733)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06733">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06733/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06733/status.svg
   :target: https://doi.org/10.21105/joss.06733

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

kthyng commented 4 months ago

@tobiasmarke If you're interested in reviewing for JOSS in the future, please register at https://reviewers.joss.theoj.org/.

openjournals / joss-reviews