openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
712 stars 38 forks source link

[PRE REVIEW]: squishyplanet: modeling transits of non-spherical exoplanets in JAX #6738

Closed editorialbot closed 2 months ago

editorialbot commented 4 months ago

Submitting author: !--author-handle-->@ben-cassese<!--end-author-handle-- (Benjamin Cassese) Repository: https://github.com/ben-cassese/squishyplanet Branch with paper.md (empty if default branch): Version: v0.1.1 Editor: !--editor-->@mbobra<!--end-editor-- Reviewers: @rferrerc, @catrionamurray Managing EiC: Dan Foreman-Mackey

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/2b62acea4e4d6c0de73309184861d1e9"><img src="https://joss.theoj.org/papers/2b62acea4e4d6c0de73309184861d1e9/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/2b62acea4e4d6c0de73309184861d1e9/status.svg)](https://joss.theoj.org/papers/2b62acea4e4d6c0de73309184861d1e9)

Author instructions

Thanks for submitting your paper to JOSS @ben-cassese. Currently, there isn't a JOSS editor assigned to your paper.

@ben-cassese if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 4 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 4 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.06 s (694.7 files/s, 190317.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          18            831           1919           4793
Jupyter Notebook                 7              0           2183           1579
TeX                              1             14              0            206
Markdown                         5             70              0            154
YAML                             5             20             32             93
reStructuredText                 4             80             90             80
TOML                             1              6              0             48
JSON                             1              0              0             46
DOS Batch                        1              8              1             26
INI                              1              4              4             21
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            45           1037           4236           7055
-------------------------------------------------------------------------------

Commit count by author:

    82  Ben-Cassese
     1  Ben Cassese
editorialbot commented 4 months ago

:warning: An error happened when generating the pdf. Author (David Kipping) is missing affiliation.

editorialbot commented 4 months ago

Paper file info:

📄 Wordcount for paper.md is 1062

✅ The paper includes a Statement of need section

editorialbot commented 4 months ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 4 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3847/1538-3881/ab4fee is OK
- 10.1086/345520 is OK
- 10.1086/683602 is OK
- 10.21105/joss.03285 is OK
- 10.5281/zenodo.10736936 is OK
- 10.1051/0004-6361/201628579 is OK
- 10.1038/s41586-022-05677-y is OK
- 10.5281/zenodo.11062823 is OK
- 10.1088/0004-637X/796/1/67 is OK
- 10.3847/1538-3881/aae8e5 is OK
- 10.1086/373893 is OK
- 10.1088/0004-637X/709/2/1219 is OK

MISSING DOIs

- No DOI given, and none found for title: JAX: composable transformations of Python+NumPy pr...

INVALID DOIs

- None
dfm commented 4 months ago

@ben-cassese — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience!

In the meantime, could you fix the metadata error in the paper (David Kipping needs a listed affiliation), and then commend @editorialbot generate pdf to compile the paper again? Thanks.

ben-cassese commented 4 months ago

Sounds good, and thanks for adding to the triage! Sorry about the affiliation issue, should be fixed now.

ben-cassese commented 4 months ago

@editorialbot generate pdf

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

dfm commented 4 months ago

@editorialbot invite @mbobra as editor

editorialbot commented 4 months ago

Invitation to edit this submission sent!

mbobra commented 3 months ago

@editorialbot assign me as editor

editorialbot commented 3 months ago

Assigned! @mbobra is now the editor

mbobra commented 3 months ago

@ben-cassese Thanks for your submission! If you have any suggestions for reviewers, please let me know here (you can give me the Github handle without @ mentioning them, e.g. mbobra instead of @mbobra).

ben-cassese commented 3 months ago

Thanks! Looking at the list of volunteers, I'd suggest tedjohnson12 and sblunt.

mbobra commented 3 months ago

@ben-cassese Hang on, I am still working on finding reviewers.

ben-cassese commented 3 months ago

All ok, thank you!

mbobra commented 3 months ago

@editorialbot add @rferrerc as reviewer

editorialbot commented 3 months ago

@rferrerc added to the reviewers list!

mbobra commented 3 months ago

👋 @rferrerc !

mbobra commented 2 months ago

@editorialbot add @catrionamurray as reviewer

editorialbot commented 2 months ago

@catrionamurray added to the reviewers list!

mbobra commented 2 months ago

@editorialbot start review

editorialbot commented 2 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6972.