[REVIEW]: DSSE: An environment for simulation of reinforcement learning-empowered drone swarm maritime search and rescue missions

editorialbot commented 3 months ago

Submitting author: !--author-handle-->@renatex333@kanishkan91<!--end-editor-- Reviewers: @draabe, @wob86 Archive: 10.5281/zenodo.12668728

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/57c2c7323124206325d600d34cfecbcf"><img src="https://joss.theoj.org/papers/57c2c7323124206325d600d34cfecbcf/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/57c2c7323124206325d600d34cfecbcf/status.svg)](https://joss.theoj.org/papers/57c2c7323124206325d600d34cfecbcf)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@draabe & @wob86, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kanishkan91 know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @draabe

📝 Checklist for @wob86

kanishkan91 commented 2 months ago

@editorialbot recommend-accept

editorialbot commented 2 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 2 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.oceaneng.2021.110098 is OK
- 10.1016/j.oceaneng.2023.116403 is OK
- 10.5194/gmd-11-1405-2018 is OK
- 10.1038/nature14236 is OK
- 10.48550/arXiv.1707.06347 is OK
- 10.1016/j.oceaneng.2022.113444 is OK

MISSING DOIs

- No DOI given, and none found for title: Safety and Shipping Review
- No DOI given, and none found for title: Drowning
- No DOI given, and none found for title: Chapter 5. Search techniques and operations
- No DOI given, and none found for title: The complexity of the optimal searcher path proble...
- No DOI given, and none found for title: PettingZoo: Gym for Multi-Agent Reinforcement Lear...
- No DOI given, and none found for title: PettingZoo: Gym for multi-agent reinforcement lear...
- No DOI given, and none found for title: Exploration and Rescue of Shipwreck Survivors usin...
- No DOI given, and none found for title: Algorithms for Drone Swarm Search (DSSE)

INVALID DOIs

- https://doi.org/10.1016/j.artint.2021.103535 is INVALID because of 'https://doi.org/' prefix

editorialbot commented 2 months ago

:warning: Error preparing paper acceptance. The generated XML metadata file is invalid.

Element doi: [facet 'pattern'] The value 'https://doi.org/10.1016/j.artint.2021.103535' is not accepted by the pattern '10\.[0-9]{4,9}/.{1,200}'.

kanishkan91 commented 2 months ago

@renatex333 Actually, I cannot accept till the above DOI is corrected. Specifically, its this one-

https://doi.org/10.1016/j.artint.2021.103535 is INVALID because of 'https://doi.org/' prefix

Could you correct this in the paper and also add the missing DOIs? I can proceed with the acceptance after that. Thanks!

renatex333 commented 2 months ago

Hi!

Of course! I fixed it already, just waiting for my team to accept and merge the changes. It should be all set in a few minutes. Thank you once again for the support and valuable feedback.

Edit: Everything is already updated. Version is 0.2.6 and DOI is https://doi.org/10.5281/zenodo.12668728

kanishkan91 commented 2 months ago

@editorialbot check references

editorialbot commented 2 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.oceaneng.2021.110098 is OK
- 10.1016/j.oceaneng.2023.116403 is OK
- 10.1016/j.artint.2021.103535 is OK
- 10.5194/gmd-11-1405-2018 is OK
- 10.1038/nature14236 is OK
- 10.48550/arXiv.1707.06347 is OK
- 10.1016/j.oceaneng.2022.113444 is OK

MISSING DOIs

- No DOI given, and none found for title: Safety and Shipping Review
- No DOI given, and none found for title: Drowning
- No DOI given, and none found for title: Chapter 5. Search techniques and operations
- No DOI given, and none found for title: The complexity of the optimal searcher path proble...
- No DOI given, and none found for title: PettingZoo: Gym for Multi-Agent Reinforcement Lear...
- No DOI given, and none found for title: PettingZoo: Gym for multi-agent reinforcement lear...
- No DOI given, and none found for title: Exploration and Rescue of Shipwreck Survivors usin...
- No DOI given, and none found for title: Algorithms for Drone Swarm Search (DSSE)

INVALID DOIs

- None

kanishkan91 commented 2 months ago

@editorialbot generate pdf

editorialbot commented 2 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kanishkan91 commented 2 months ago

@editorialbot set v0.2.6 as version

editorialbot commented 2 months ago

Done! version is now v0.2.6

kanishkan91 commented 2 months ago

@editorialbot set 10.5281/zenodo.12668728 as archive

editorialbot commented 2 months ago

Done! archive is now 10.5281/zenodo.12668728

kanishkan91 commented 2 months ago

@editorialbot recommend-accept

@renatex333 Thanks again! I have recommended this for acceptance now (again). The AEiC in this submission track will review shortly and if all goes well this will go live soon! Big thank you to @draabe and @wob86 for reviewing! JOSS is volunteer run and relies heavily on researchers such as yourself.

editorialbot commented 2 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 2 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.oceaneng.2021.110098 is OK
- 10.1016/j.oceaneng.2023.116403 is OK
- 10.1016/j.artint.2021.103535 is OK
- 10.5194/gmd-11-1405-2018 is OK
- 10.1038/nature14236 is OK
- 10.48550/arXiv.1707.06347 is OK
- 10.1016/j.oceaneng.2022.113444 is OK

MISSING DOIs

- No DOI given, and none found for title: Safety and Shipping Review
- No DOI given, and none found for title: Drowning
- No DOI given, and none found for title: Chapter 5. Search techniques and operations
- No DOI given, and none found for title: The complexity of the optimal searcher path proble...
- No DOI given, and none found for title: PettingZoo: Gym for Multi-Agent Reinforcement Lear...
- No DOI given, and none found for title: PettingZoo: Gym for multi-agent reinforcement lear...
- No DOI given, and none found for title: Exploration and Rescue of Shipwreck Survivors usin...
- No DOI given, and none found for title: Algorithms for Drone Swarm Search (DSSE)

INVALID DOIs

- None

editorialbot commented 2 months ago

:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5581, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

crvernon commented 2 months ago

🔍 checking out the following:

[x] reviewer checklists are completed or addressed
[x] version set
[x] archive set
[x] archive names (including order) and title in archive matches those specified in the paper
[x] archive uses the same license as the repo and is OSI approved as open source
[x] archive DOI and version match or redirect to those set by editor in review thread
[x] paper is error free - grammar and typos
[x] paper is error free - test links in the paper and bib
[x] paper is error free - refs preserve capitalization where necessary
[x] paper is error free - no invalid refs without justification

crvernon commented 2 months ago

@editorialbot generate pdf

editorialbot commented 2 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

crvernon commented 2 months ago

@kanishkan91 and @renatex333 - it looks like the Zenodo archive references version v3, though the version set in this review thread is v0.2.6. Could you clear this up?

crvernon commented 2 months ago

@renatex333 - please address the following in the paper:

[x] LINE 43: "Expanding on the state-of-the-art research presented by (Ai et al., 2021; Wu et al., 2024), this..." should read "Expanding on the state-of-the-art research presented by Ai et al. (2021) and Wu et al. (2024), this..." This can be achieved by removing the brackets "[" and "]" from your citation in the paper. See other JOSS articles if you need help on this.

After the version issue raised above and this citation are cleared up, I will accept this article for publication. Thanks!

kanishkan91 commented 2 months ago

@crvernon The Zenodo entry points to version 0.2.6 (See screenshot below). I belive the final version on Zenodo is v3 since the repository has been updated a couple of times?

crvernon commented 2 months ago

@kanishkan91 the DOI posted 10.5281/zenodo.12668728 points to the v3 record, where 10.5281/zenodo.12668727 points to the v0.2.6 record. See

I am fine with either of these based on what was intended. They just need to match. which set do you think you should use?

kanishkan91 commented 2 months ago

@crvernon I see. I think we can use the latest and set the version to v3. Can I still change the version?

kanishkan91 commented 2 months ago

@editorialbot set v3 as version

editorialbot commented 2 months ago

Done! version is now v3

kanishkan91 commented 2 months ago

@crvernon , @renatex333 I changed the version so we can keep the latest doi with all the latest changes

crvernon commented 2 months ago

@renatex333 - please address the following in the paper:

[x] LINE 43: "Expanding on the state-of-the-art research presented by (Ai et al., 2021; Wu et al., 2024), this..." should read "Expanding on the state-of-the-art research presented by Ai et al. (2021) and Wu et al. (2024), this..." This can be achieved by removing the brackets "[" and "]" from your citation in the paper. See other JOSS articles if you need help on this.

After the version issue raised above and this citation are cleared up, I will accept this article for publication. Thanks!

Then the one change left should take care of things. Thanks!

crvernon commented 1 month ago

@renatex333 just a reminder on the above. Let me know when this is done so we may move forward. Thanks!

renatex333 commented 1 month ago

Hi @crvernon,

Thank you for your patience and valuable feedback! The issue you raised is fixed and on the main branch!

crvernon commented 1 month ago

@editorialbot generate pdf

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

crvernon commented 1 month ago

@editorialbot accept

editorialbot commented 1 month ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 1 month ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Falcão given-names: Renato Laffranchi orcid: "https://orcid.org/0009-0001-5943-0481" - family-names: Oliveira given-names: Jorás Custódio Campos name-particle: de orcid: "https://orcid.org/0009-0005-1883-8703" - family-names: Andrade given-names: Pedro Henrique Britto Aragão orcid: "https://orcid.org/0009-0000-0056-4322" - family-names: Rodrigues given-names: Ricardo Ribeiro orcid: "https://orcid.org/0009-0008-1237-3353" - family-names: Barth given-names: Fabrício Jailson orcid: "https://orcid.org/0000-0001-6263-121X" - family-names: Brancalion given-names: José Fernando Basso orcid: "https://orcid.org/0000-0002-4387-0204" contact: - family-names: Falcão given-names: Renato Laffranchi orcid: "https://orcid.org/0009-0001-5943-0481" doi: 10.5281/zenodo.12668728 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Falcão given-names: Renato Laffranchi orcid: "https://orcid.org/0009-0001-5943-0481" - family-names: Oliveira given-names: Jorás Custódio Campos name-particle: de orcid: "https://orcid.org/0009-0005-1883-8703" - family-names: Andrade given-names: Pedro Henrique Britto Aragão orcid: "https://orcid.org/0009-0000-0056-4322" - family-names: Rodrigues given-names: Ricardo Ribeiro orcid: "https://orcid.org/0009-0008-1237-3353" - family-names: Barth given-names: Fabrício Jailson orcid: "https://orcid.org/0000-0001-6263-121X" - family-names: Brancalion given-names: José Fernando Basso orcid: "https://orcid.org/0000-0002-4387-0204" date-published: 2024-07-11 doi: 10.21105/joss.06746 issn: 2475-9066 issue: 99 journal: Journal of Open Source Software publisher: name: Open Journals start: 6746 title: "DSSE: An environment for simulation of reinforcement learning-empowered drone swarm maritime search and rescue missions" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06746" volume: 9 title: "DSSE: An environment for simulation of reinforcement learning-empowered drone swarm maritime search and rescue missions" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 month ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 month ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5605
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06746
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

crvernon commented 1 month ago

🥳 Congratulations on your new publication @renatex333! Many thanks to @kanishkan91 for editing and @draabe and @wob86 for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts.

Please consider becoming a reviewer for JOSS if you are not already: https://reviewers.joss.theoj.org/join

editorialbot commented 1 month ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06746/status.svg)](https://doi.org/10.21105/joss.06746)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06746">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06746/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06746/status.svg
   :target: https://doi.org/10.21105/joss.06746

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews