openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
714 stars 38 forks source link

[PRE REVIEW]: tidylda: An R Package for Latent Dirichlet Allocation Using ''tidyverse'' Conventions #6760

Closed editorialbot closed 4 months ago

editorialbot commented 4 months ago

Submitting author: !--author-handle-->@tommyjones<!--end-author-handle-- (Tommy Jones) Repository: https://github.com/TommyJones/tidylda Branch with paper.md (empty if default branch): main Version: v0.0.5 Editor: !--editor-->@kanishkan91<!--end-editor-- Reviewers: @maximelenormand, @hassaniazi Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/04f617f818a4ef71ea7ffa232016216c"><img src="https://joss.theoj.org/papers/04f617f818a4ef71ea7ffa232016216c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/04f617f818a4ef71ea7ffa232016216c/status.svg)](https://joss.theoj.org/papers/04f617f818a4ef71ea7ffa232016216c)

Author instructions

Thanks for submitting your paper to JOSS @tommyjones. Currently, there isn't a JOSS editor assigned to your paper.

@tommyjones if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 4 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 4 months ago

:warning: An error happened when generating the pdf.

crvernon commented 4 months ago

:wave: @TommyJones - Thank you for your submission to JOSS! Could you please include your paper and supporting files in a branch of the submission repository (https://github.com/TommyJones/tidylda) instead of in a separate repo? Thanks.

TommyJones commented 4 months ago

@crvernon - Done! Do you need me to resubmit through the JOSS portal?

crvernon commented 4 months ago

Thanks and all is well! I can do things from here.

TommyJones commented 4 months ago

Thanks you! πŸ™

Sent with Shortwave https://www.shortwave.com?utm_medium=email&utm_content=signature&utm_source=am9uZXMudGhvcy53QGdtYWlsLmNvbQ==

On Fri May 17, 2024, 05:31 PM GMT, Chris Vernon @.***> wrote:

Thanks and all is well! I can do things from here. β€” Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/6760#issuecomment-2118083829, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGCQARO6RTMIKRT6CXRGEDZCY5HRAVCNFSM6AAAAABH37MPE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYGA4DGOBSHE. You are receiving this because you were mentioned.Message ID: @.***>

crvernon commented 4 months ago

@editorialbot set main as branch

editorialbot commented 4 months ago

Done! branch is now main

crvernon commented 4 months ago

@editorialbot check repository

editorialbot commented 4 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (1690.1 files/s, 276996.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               25            988           1408           2647
C++                              4            319            354            664
Markdown                         8            126              0            540
C/C++ Header                     7            186            130            442
Rmd                              5            284            336            404
TeX                              1              4              0            162
YAML                             4             33             12            120
SVG                              1              0              0             18
C                                1              0              0              1
-------------------------------------------------------------------------------
SUM:                            56           1940           2240           4998
-------------------------------------------------------------------------------

Commit count by author:

   435  Tommy Jones
     9  Tommy
     3  Brendan Knapp
editorialbot commented 4 months ago

Paper file info:

πŸ“„ Wordcount for paper.md is 1518

βœ… The paper includes a Statement of need section

editorialbot commented 4 months ago

License info:

🟑 License found: Other (Check here for OSI approval)

crvernon commented 4 months ago

@editorialbot check references

editorialbot commented 4 months ago

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "-01-01" (NAME) [#<BibTeX::Bibliography data=[19]>, "@", #<BibTeX::Entry >, {:author=>["Max Khun and Hadley Wickham"], :title=>["Tidymodels"], :year=>"2018", :urldate=>"2021"}]
crvernon commented 4 months ago

@editorialbot invite @kanishkan91 as editor

:wave: @kanishkan91 are you able to take this one on?

editorialbot commented 4 months ago

Invitation to edit this submission sent!

crvernon commented 4 months ago

@TommyJones I think you may need to add brackets around your dates on this ref to get it to compile:

@online{tidymodels,
  author = {Max Khun and Hadley Wickham},
  title = {Tidymodels},
  year = 2018,
  urldate = 2021-01-01,
  url = {https://www.tidymodels.org/}
}

Per the error...

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "-01-01" (NAME) [#<BibTeX::Bibliography data=[19]>, "@", #<BibTeX::Entry >, {:author=>["Max Khun and Hadley Wickham"], :title=>["Tidymodels"], :year=>"2018", :urldate=>"2021"}]
TommyJones commented 4 months ago

I just pushed a change with brackets around the date.

@editorialbot check references

crvernon commented 4 months ago

@editorialbot check references

crvernon commented 4 months ago

@TommyJones - FYI, you have to place the editorialbot commands at the top of the comment. Thanks!

editorialbot commented 4 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.01686 is OK
- 10.18637/jss.v091.i02 is OK
- 10.21105/joss.00774 is OK
- 10.21105/joss.00037 is OK

MISSING DOIs

- No DOI given, and none found for title: text2vec
- No DOI given, and none found for title: textmineR: Functions for Text Mining and Topic Mod...
- No DOI given, and none found for title: lda
- No DOI given, and none found for title: broom: An R Package for Converting Statistical Ana...
- No DOI given, and none found for title: R: A Language and Environment for Statistical Comp...
- No DOI given, and none found for title: topicmodels:  An R Package for Fitting Topic Model...
- No DOI given, and none found for title: Software Framework for Topic Modelling with Large ...
- No DOI given, and none found for title: Text Mining Infrastructure in R
- No DOI given, and none found for title: MALLET: A Machine Learning for Language Toolkit
- 10.1002/wics.1212 may be a valid DOI for title: The Comprehensive R Archive Network
- No DOI given, and none found for title: Latent Dirichlet Allocation
- No DOI given, and none found for title: Latent Dirichlet Allocation for Natural Language S...
- No DOI given, and none found for title: Conventions for R Modeling Packages
- No DOI given, and none found for title: Tidy data
- No DOI given, and none found for title: Tidymodels

INVALID DOIs

- doi:10.18637/jss.v083.b01 is INVALID (failed connection)
crvernon commented 4 months ago

@editorialbot generate pdf

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

TommyJones commented 4 months ago

Do you still need me to suggest reviewers? Both Emil Hvitfeldt (EmilHvitfeldt) and Julia Silge (juliasilge) would be excellent.

Of the people who have pre-voluneered to review papers, both Harish Varma Siravuri and bagheria are tagged with all three of R, C++, and natural language processing.

crvernon commented 4 months ago

I am the Associate Editor in Chief of this submission track but have invited a topic editor to edit your submission. Once they accept, they can get some reviewers assigned for you and get you in review. Thanks for the suggestions as that will help them get things moving more quickly.

kanishkan91 commented 4 months ago

@crvernon I can edit this submission

kanishkan91 commented 4 months ago

@editorialbot assign me as editor

editorialbot commented 4 months ago

Assigned! @kanishkan91 is now the editor

kanishkan91 commented 4 months ago

@harishsiravuri Would you be interested in reviewing this software paper for the Journal of Open Source Software?

kanishkan91 commented 4 months ago

@bagheria Would you be interested in reviewing this paper for JOSS?

kanishkan91 commented 4 months ago

@maximelenormand Given your publication history in JOSS, would you be interested in reviewing this software paper for JOSS?

maximelenormand commented 4 months ago

Hi @kanishkan91, I am available to review this paper for JOSS.

kanishkan91 commented 4 months ago

@editorialbot add @maximelenormand as reviewer

editorialbot commented 4 months ago

@maximelenormand added to the reviewers list!

kanishkan91 commented 4 months ago

@jonschwenk, @jsta given your previous publication with JOSS, would either of you be interested in reviewing this software package and paper for JOSS?

kanishkan91 commented 4 months ago

@brunomontezano Given your reviewing experience with JOSS, would you be interested in reviewing this software package and paper for JOSS?

brunomontezano commented 4 months ago

Hello @kanishkan91! Unfortunately in the next couple weeks I'll be very busy. But after that, I'll probably be available for reviewing if still needed, it looks like an interesting piece of work. Thank you a lot for the invite!

kanishkan91 commented 4 months ago

@brunomontezano Thanks! If I still need a reviewer 2 weeks from now, will reach out.

kanishkan91 commented 4 months ago

@hassaniazi Would you be interested in this review?

kanishkan91 commented 4 months ago

@editorialbot add @hassaniazi as reviewer

editorialbot commented 4 months ago

@hassaniazi added to the reviewers list!

kanishkan91 commented 4 months ago

@TommyJones , @hassaniazi and @maximelenormand - Looks like we can get this review started. I'l start it over in another issue and post detailed instructions for reviewers.

kanishkan91 commented 4 months ago

@editorialbot start review

editorialbot commented 4 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6800.