search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
694 stars 36 forks source link

[REVIEW]: RobotDART: a versatile robot simulator for robotics and machine learning researchers #6771

Open editorialbot opened 1 month ago

editorialbot commented 1 month ago

Submitting author: !--author-handle-->@costashatz<!--end-author-handle-- (Konstantinos Chatzilygeroudis) Repository: https://github.com/NOSALRO/robot_dart Branch with paper.md (empty if default branch): Version: v1.0.0 Editor: !--editor-->@boisgera<!--end-editor-- Reviewers: @c-joly, @bstanciulescu Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e13ef9a388c2a9adbfc174fabbeddfce"><img src="https://joss.theoj.org/papers/e13ef9a388c2a9adbfc174fabbeddfce/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e13ef9a388c2a9adbfc174fabbeddfce/status.svg)](https://joss.theoj.org/papers/e13ef9a388c2a9adbfc174fabbeddfce)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@c-joly & @bstanciulescu, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @boisgera know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @c-joly

📝 Checklist for @bstanciulescu

editorialbot commented 1 month ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 month ago

Software report:

github.com/AlDanial/cloc v 1.90  T=1.40 s (822.4 files/s, 415724.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                           296         206671              7         190230
XML                            313           1207           2803          91984
Markdown                       297          27955              1          27897
C++                             80           1938            884           9577
JavaScript                      36           1017           1334           4921
C/C++ Header                    59            958            452           3900
Python                          32            724            661           3104
XSD                              4            131             14           1636
GLSL                            10            128             77            578
YAML                             5             18              9            381
Bourne Shell                     6             51             23            313
TeX                              1             35              0            289
CMake                            8             56            130            205
XSLT                             1              0              5             10
sed                              1              0              2              4
CSS                              2              0              0              2
JSON                             1              0              0              1
-------------------------------------------------------------------------------
SUM:                          1152         240889           6402         335032
-------------------------------------------------------------------------------

Commit count by author:

   907  Konstantinos Chatzilygeroudis
   222  Jean-Baptiste Mouret
    61  DionisTotsila
    18  Vaios Papaspyros
    14  Ivan Bergonzani
    14  dinies
     7  Antoine Cully
     6  Dorian Goepp
     6  eloise
     6  kostastsing
     5  DALIN Eloise
     5  aneoshun
     3  Dionis Totsila
     3  Eloise Dalin
     3  eloise dalin
     3  jspitz
     2  Aneoshun
     2  Matthias Mayr
     2  Olivier Rochel
     2  Pierre Desreumaux
     1  Erick Kramer
     1  Vassilis Vassiliades
     1  artificialsimon
     1  itUserName
     1  kounelisagis
editorialbot commented 1 month ago

Paper file info:

📄 Wordcount for paper.md is 2323

✅ The paper includes a Statement of need section

editorialbot commented 1 month ago

License info:

✅ License found: BSD 2-Clause "Simplified" License (Valid open source OSI approved license)

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 month ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- No DOI given, and none found for title: Black-box data-efficient policy search for robotic...
- 10.1109/iros.2004.1389727 may be a valid DOI for title: Design and use paradigms for gazebo, an open-sourc...
- No DOI given, and none found for title: Gazebo Simulator
- 10.1109/iros.2012.6386109 may be a valid DOI for title: Mujoco: A physics engine for model-based control
- No DOI given, and none found for title: PyBullet, a Python module for physics simulation f...
- No DOI given, and none found for title: Open Dynamics Engine
- 10.21105/joss.00500 may be a valid DOI for title: Dart: Dynamic animation and robotics toolkit
- 10.1126/scirobotics.aau5872 may be a valid DOI for title: Learning agile and dynamic motor skills for legged...
- No DOI given, and none found for title: Learning quadrupedal locomotion over challenging t...
- 10.1109/iros.2017.8202133 may be a valid DOI for title: Domain randomization for transferring deep neural ...
- No DOI given, and none found for title: A review of robot learning for manipulation: Chall...
- 10.1007/s10846-017-0468-y may be a valid DOI for title: Survey of model-based reinforcement learning: Appl...
- No DOI given, and none found for title: Recent advances in robot learning from demonstrati...
- 10.1109/tro.2019.2958211 may be a valid DOI for title: A survey on policy search algorithms for learning ...
- 10.1109/tevc.2017.2735550 may be a valid DOI for title: Using centroidal voronoi tessellations to scale up...
- 10.1016/j.robot.2017.11.010 may be a valid DOI for title: Reset-free trial-and-error learning for robot dama...
- No DOI given, and none found for title: 20 years of reality gap: a few thoughts about simu...
- 10.1109/icra.2018.8463197 may be a valid DOI for title: Bayesian optimization with automatic prior selecti...
- 10.1109/icra.2018.8461083 may be a valid DOI for title: Using parameterized black-box priors to scale up m...
- 10.1609/aaai.v32i1.11687 may be a valid DOI for title: Alternating optimisation and quadrature for robust...
- No DOI given, and none found for title: Multi-objective model-based policy search for data...
- 10.1109/robio55434.2022.10011996 may be a valid DOI for title: Skill-based multi-objective reinforcement learning...
- 10.1109/iros51168.2021.9636292 may be a valid DOI for title: Learning of parameters in behavior trees for movem...
- 10.1109/case49997.2022.9926713 may be a valid DOI for title: Learning skill-based industrial robot tasks with u...
- 10.1145/3512290.3528751 may be a valid DOI for title: Hierarchical quality-diversity for online damage r...
- No DOI given, and none found for title: Safety-aware robot damage recovery using constrain...
- No DOI given, and none found for title: Combining planning, reasoning and reinforcement le...
- 10.1145/3596912 may be a valid DOI for title: Online damage recovery for physical robots with hi...
- No DOI given, and none found for title: Towards semi-episodic learning for robot damage re...
- 10.1109/tsmc.2023.3262954 may be a valid DOI for title: Self-correcting quadratic programming-based robot ...
- 10.3389/frobt.2022.974537 may be a valid DOI for title: Behavior policy learning: Learning multi-stage tas...
- 10.1109/iisa59645.2023.10345937 may be a valid DOI for title: Evolving Dynamic Locomotion Policies in Minutes
- 10.1109/iisa59645.2023.10345879 may be a valid DOI for title: Effective Skill Learning via Autonomous Goal Repre...
- No DOI given, and none found for title: End-to-End Stable Imitation Learning via Autonomou...
- No DOI given, and none found for title: Robust reinforcement learning with Bayesian optimi...
- 10.1109/humanoids.2017.8246947 may be a valid DOI for title: TALOS: A new humanoid research platform targeted f...

INVALID DOIs

- None
c-joly commented 1 month ago

Review checklist for @c-joly

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

bstanciulescu commented 1 month ago

Review checklist for @bstanciulescu

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

costashatz commented 3 weeks ago

@boisgera @c-joly @bstanciulescu thank you for handling the review of our submission! We have tried to update our text such that it's closer to the 1000 words limit (we are still slightly over, ~1200, but we would need to completely re-write the text to reduce it more). Let us know if this is OK with the journal's policies or if we need to further adapt.

@editorialbot generate pdf

boisgera commented 3 weeks ago

@editorialbot generate pdf

editorialbot commented 3 weeks ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

boisgera commented 3 weeks ago

@boisgera @c-joly @bstanciulescu thank you for handling the review of our submission! We have tried to update our text such that it's closer to the 1000 words limit (we are still slightly over, ~1200, but we would need to completely re-write the text to reduce it more). Let us know if this is OK with the journal's policies or if we need to further adapt.

@costashatz Thanks for this effort! Since your paper is not "significantly longer than 1000 words" anymore, this is fine.

boisgera commented 2 weeks ago

Hi @bstanciulescu! Since you usually work with Windows, could you try to install RobotDART on Ubuntu 22.04 with WSL and report what you get please? AFAICT this is not explicitly supported so you may run into issues but OTOH that would be really nice to know that it's a workable solution for Windows users.

boisgera commented 1 day ago

Hi @bstanciulescu! Since you usually work with Windows, could you try to install RobotDART on Ubuntu 22.04 with WSL and report what you get please? AFAICT this is not explicitly supported so you may run into issues but OTOH that would be really nice to know that it's a workable solution for Windows users.

Great news! @bstanciulescu told me (in a private communication) that he successfully managed to install and run RoboDart on WSL, without any fiddling! I asked him to open an issue to report his experience so that this information can be added to the project documentation.