[PRE REVIEW]: Desalination and brine treatment systems integrated modelling framework: simulation and evaluation of water and resource recovery

[editorialbot]

Submitting author: !--author-handle-->@rodoulak<!--end-author-handle-- (Rodoula Ktori) Repository: https://github.com/rodoulak/Desalination-and-Brine-Treatment-Simulation-.git Branch with paper.md (empty if default branch): main Version: DesalSim 1.0.1 (https://pypi.org/project/DesalSim/) Editor: !--editor-->@elbeejay<!--end-editor-- Reviewers: @rkingsbury, @yalinli2, @BenWinchester Managing EiC: Kristen Thyng

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/30a1b99aee30ad44b72c6656b9625fb4"><img src="https://joss.theoj.org/papers/30a1b99aee30ad44b72c6656b9625fb4/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/30a1b99aee30ad44b72c6656b9625fb4/status.svg)](https://joss.theoj.org/papers/30a1b99aee30ad44b72c6656b9625fb4)

Author instructions

Thanks for submitting your paper to JOSS @rodoulak. Currently, there isn't a JOSS editor assigned to your paper.

@rodoulak if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

:warning: An error happened when generating the pdf.

[rodoulak]

Below is the list of reviewers:

• Demetrios G. Eliades (eldemet)
• Shubham Jain (shubhamjain15)
• Lokendra Singh Rathore (LSRathore)
• DARSakthi (DARSakthi)
• mewilhel (mewilhel)
• thermalogic (thermalogic)

[kthyng]

@editorialbot set main as branch

[editorialbot]

Done! branch is now main

[kthyng]

@editorialbot generate pdf

[editorialbot]

:warning: An error happened when generating the pdf.

[kthyng]

@rodoulak can you work on troubleshooting the paper compilation errors? You can recompile with the command I used.

[rodoulak]

@kthyng I fixed the error. It should be okay now.

[kthyng]

@editorialbot generate pdf

[editorialbot]

:warning: An error happened when generating the pdf.

[kthyng]

@rodoulak Sorry I don't see a difference. Can you tell what the error is?

[rodoulak]

@kthyng I checked the error, and there was a problem with line 65 in the bib file. I deleted that line (URL). I don't know how to generate the PDF, so I can test if it works now.

[kthyng]

@editorialbot generate pdf

@rodoulak you can run this command yourself to check

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[kthyng]

@editorialbot check repository

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=0.07 s (769.3 files/s, 170676.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          37           1466           2132           4526
Markdown                        15            564              0           3093
TeX                              2              3              0            196
-------------------------------------------------------------------------------
SUM:                            54           2033           2132           7815
-------------------------------------------------------------------------------

Commit count by author:

   189  rodoulak
    34  Rodoula Ktori

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 850

✅ The paper includes a Statement of need section

[editorialbot]

License info:

✅ License found: MIT License (Valid open source OSI approved license)

[kthyng]

@editorialbot check references

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.desal.2010.10.035 is OK
- 10.1016/j.renene.2011.03.040 is OK
- 10.1021/acssuschemeng.2c06636 is OK
- 10.1016/j.desal.2020.114928 is OK
- 10.3390/membranes6010003 is OK
- 10.1016/B978-0-444-50810-2.50018-X is OK
- 10.1016/j.desal.2013.03.033 is OK
- 10.36227/techrxiv.170595103.36689587/v1 is OK
- 10.1016/j.jclepro.2020.122472 is OK
- 10.1016/j.desal.2022.116005 is OK
- 10.1016/j.desal.2018.11.018 is OK
- 10.1016/j.jece.2021.105338 is OK
- 10.3390/separations9100295 is OK
- 10.1080/19443994.2014.948660 is OK
- 10.1016/j.desal.2024.117562 is OK

MISSING DOIs

- No DOI given, and none found for title: Plant design and economics for chemical engineers
- No DOI given, and none found for title: Deliverable 3.1 Report on the design procedure inc...
- No DOI given, and none found for title: WAVE Water Treatment Design Software
- 10.36227/techrxiv.170594775.55495325/v1 may be a valid DOI for title: Designing for the future: A Value-Sensitive Approa...

INVALID DOIs

- None

[kthyng]

Hi @rodoulak and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:

• [x] OSI-approved license
• [x] Installation instructions
• [x] Documentation
• [x] Tests of some sort
• [x] Check paper
• [x] Substantial scholarly effort
• [x] Clear research application/in scope

In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address that DOI issue.

[kthyng]

We have a backlog of submissions so I will add this to our waitlist. Thanks for your patience.

[kthyng]

@AdamRJensen Might you be able to edit this submission?

[kthyng]

@editorialbot invite @AdamRJensen as editor

[editorialbot]

Invitation to edit this submission sent!

[AdamRJensen]

@editorialbot invite @AdamRJensen as editor

Unfortunately not, I'm running busy with three other JOSS submissions and other work

[kthyng]

ok thanks

[arfon]

@editorialbot generate pdf

☝ to generate the most similar paper recommenders

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[editorialbot]

Five most similar historical JOSS papers:

RHEIA: Robust design optimization of renewable Hydrogen and dErIved energy cArrier systems Submitting author: @DCoppitters Handling editor: @fraukewiese (Active) Reviewers: @andr1976, @ClaraBuettner Similarity score: 0.8233

SIMsalabim: An open-source drift-diffusion simulator for semiconductor devices Submitting author: @ljakoster Handling editor: @rkurchin (Active) Reviewers: @UTH-Tuan, @shahmoradi, @roderickmackenzie Similarity score: 0.8161

OPEM : Open Source PEM Cell Simulation Tool Submitting author: @sepandhaghighi Handling editor: @katyhuff (Retired) Reviewers: @nnadeau Similarity score: 0.8161

PySWMM: The Python Interface to Stormwater Management Model (SWMM) Submitting author: @katmratliff Handling editor: @kbarnhart (Retired) Reviewers: @nickrsan, @jrkasprzyk Similarity score: 0.8153

PorousFlow: a multiphysics simulation code for coupled problems in porous media Submitting author: @WilkAndy Handling editor: @jedbrown (Active) Reviewers: @jbrezmorf, @rpodgorney Similarity score: 0.8133

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

[kthyng]

@elbeejay Can you edit this submission?

[kthyng]

@editorialbot invite @elbeejay as editor

[editorialbot]

Invitation to edit this submission sent!

[elbeejay]

@editorialbot assign @elbeejay as editor

Will likely be able to take a look at this sometime next week.

[editorialbot]

Assigned! @elbeejay is now the editor

[elbeejay]

@rodoulak - would you consider cleaning up the repository a bit before we send it out for review? It looks like a lot of Python auxiliary files and folders that are typically skipped over by git (such as the build/lib, dist, .egg-info folders) are in your repository.

I'd suggest looking at GitHub's Python .gitignore file and potentially adopting it to help manage the files that get pushed up to the GitHub repository. I am happy to hear reasons for why all of those files would need to be included, but it is atypical of a Python project.

Thanks, Jay

[rodoulak]

Hi @elbeejay,

I deleted the folders from the repository.

Thank you, Rodoula

[elbeejay]

@DCoppitters would you be willing to review this submission to JOSS titled: Desalination and brine treatment systems integrated modelling framework: simulation and evaluation of water and resource recovery? I understand that desalination and brine treatment systems might not be your niche, but the submission is presenting more than that, it is an integrated framework consisting of both the water chemistry and the associated economic models. This seems, at a high-level, similar in concept to your RHEIA software, which was previously published in JOSS and allows for the optimization of multiple objectives when designing hydrogen-energy systems.

Please let us know if you'd be willing to provide a review. I understand if you do not have the time to commit to a review for JOSS at this time.

[elbeejay]

@rkingsbury would you be willing to review this submission to JOSS titled: Desalination and brine treatment systems integrated modelling framework: simulation and evaluation of water and resource recovery? I know you previously published your Python water chemistry package, pyEQL, with JOSS, and thought that you might be able to provide some good feedback for this submission, especially on the desalination and brine treatment modeling.

Please let us know if you'd be willing to provide a review. I understand if you do not have the time to commit to a review for JOSS at this time.

[rkingsbury]

@rkingsbury would you be willing to review this submission to JOSS titled: Desalination and brine treatment systems integrated modelling framework: simulation and evaluation of water and resource recovery? I know you previously published your Python water chemistry package, pyEQL, with JOSS, and thought that you might be able to provide some good feedback for this submission, especially on the desalination and brine treatment modeling.

Please let us know if you'd be willing to provide a review. I understand if you do not have the time to commit to a review for JOSS at this time.

Hi @elbeejay I am interested to review this and I think I'm well qualified to do so. However, I do have limited bandwidth right now so my review might be slow. What is the expected timeframe?

[elbeejay]

@rkingsbury apologies for the delayed response on my end, things are busy here too! We're asking reviewers to try and complete their reviews within 6 weeks, but can extend that a bit if needed.

[elbeejay]

@eldemet, would you be interested in reviewing this submission to JOSS titled "Desalination and brine treatment systems integrated modelling framework: simulation and evaluation of water and resource recovery"? JOSS is an open-source, diamond access software journal. The submitting author, Rodoula Ktori, recommended you, and I saw that your lab does work in this area of modeling and simulations for critical infrastructure. I'm including a summary of the JOSS review process below.

At JOSS we do open checklist-driven reviews; peer-review criteria can be viewed here. This issue is a "pre-review issue" which we use to find peer-reviewers. Once 3 reviewers are found, we will officially start the review in a dedicated GitHub issue. At present we are asking reviewers to complete reviews in 6 weeks, although this can be extended if needed. If you are not able to review but can recommend someone else, please mention them here (in this case please mention their GitHub handle without the "@" symbol).

If you are interested, please take a look at the journal's conflict of interest policy to ensure you do not have a conflict before agreeing to review this submission.

Please do not feel any pressure to accept this review request if you do not have the time or do not feel comfortable reviewing this software package, we appreciate and respect our peer-reviewers' time. If you cannot serve as a reviewer at this time but have a peer, collaborator, student, or colleague who might be available and would be a good fit for this submission, please let me know!

Thanks, Jay

[elbeejay]

@stroutm would you be willing to review this submission to JOSS titled "Desalination and brine treatment systems integrated modelling framework: simulation and evaluation of water and resource recovery"? I understand you may already be familiar with JOSS from your publication on the rrcf package a few years ago. At a high-level, this submission deals with the simulation and modeling of an integrated water system, which I thought might be a good fit for someone with your expertise.

Please do not feel any pressure to accept this review request if you do not have the time or do not feel comfortable reviewing this software package, we appreciate and respect our peer-reviewers' time. If you cannot serve as a reviewer at this time but have a peer, collaborator, student, or colleague who might be available and would be a good fit for this submission, please let me know!

Thanks, Jay

[DCoppitters]

@DCoppitters would you be willing to review this submission to JOSS titled: Desalination and brine treatment systems integrated modelling framework: simulation and evaluation of water and resource recovery? I understand that desalination and brine treatment systems might not be your niche, but the submission is presenting more than that, it is an integrated framework consisting of both the water chemistry and the associated economic models. This seems, at a high-level, similar in concept to your RHEIA software, which was previously published in JOSS and allows for the optimization of multiple objectives when designing hydrogen-energy systems.

Please let us know if you'd be willing to provide a review. I understand if you do not have the time to commit to a review for JOSS at this time.

Hi @elbeejay,

Thank you for the invitation. Unfortunately, my schedule doesn't allow for additional reviews at the moment. I'm very sorry about that.

[elbeejay]

@LSRathore, would you be interested in reviewing this submission to JOSS titled "Desalination and brine treatment systems integrated modelling framework: simulation and evaluation of water and resource recovery"? JOSS is an open-source, diamond access software journal. I saw that you've volunteered to review for JOSS in the past and have a background in environmental engineering as well as programming experience which together would make you a qualified reviewer for this submission.

At JOSS we do open checklist-driven reviews; peer-review criteria can be viewed here. This issue is a "pre-review issue" which we use to find peer-reviewers. Once 3 reviewers are found, we will officially start the review in a dedicated GitHub issue. At present we are asking reviewers to complete reviews in 6 weeks, although this can be extended if needed. If you are not able to review but can recommend someone else, please mention them here (in this case please mention their GitHub handle without the "@" symbol).

If you are interested, please take a look at the journal's conflict of interest policy to ensure you do not have a conflict before agreeing to review this submission.

Please do not feel any pressure to accept this review request if you do not have the time or do not feel comfortable reviewing this software package, we appreciate and respect our peer-reviewers' time. If you cannot serve as a reviewer at this time but have a peer, collaborator, student, or colleague who might be available and would be a good fit for this submission, please let me know!

Thanks, Jay

[elbeejay]

@jennwuu and @bemcdonnell - would either of you be interested in reviewing this submission to JOSS titled "Desalination and brine treatment systems integrated modelling framework: simulation and evaluation of water and resource recovery"? JOSS is an open-source, diamond access software journal. I'm reaching out as you are both co-authors on the JOSS publication of PySWMM, which I recognize is different from this submission, but I believe much of your expertise is transferrable and would make you valuable reviewers for this submission. Below I've included a summary of the JOSS review process as it has been a few years since the PySWMM paper came out.

At JOSS we do open checklist-driven reviews; peer-review criteria can be viewed here. This issue is a "pre-review issue" which we use to find peer-reviewers. Once 3 reviewers are found, we will officially start the review in a dedicated GitHub issue. At present we are asking reviewers to complete reviews in 6 weeks, although this can be extended if needed. If you are not able to review but can recommend someone else, please mention them here (in this case please mention their GitHub handle without the "@" symbol).

If you are interested, please take a look at the journal's conflict of interest policy to ensure you do not have a conflict before agreeing to review this submission.

Please do not feel any pressure to accept this review request if you do not have the time or do not feel comfortable reviewing this software package, we appreciate and respect our peer-reviewers' time. If you cannot serve as a reviewer at this time but have a peer, collaborator, student, or colleague who might be available and would be a good fit for this submission, please let me know!

Thanks, Jay

[rkingsbury]

@rkingsbury apologies for the delayed response on my end, things are busy here too! We're asking reviewers to try and complete their reviews within 6 weeks, but can extend that a bit if needed.

Thank you @elbeejay . In that case I would be happy to undertake this review.

[jennwuu]

Hi @elbeejay

Thanks for reaching out! I don't feel I have enough relevant experience to provide a thorough review of the paper at this time.

Thanks!

[elbeejay]

@editorialbot add @rkingsbury as reviewer