[PRE REVIEW]: Desalination and brine treatment systems integrated modelling framework: simulation and evaluation of water and resource recovery

[editorialbot]

Submitting author: !--author-handle-->@rodoulak<!--end-author-handle-- (Rodoula Ktori) Repository: https://github.com/rodoulak/Desalination-and-Brine-Treatment-Simulation-.git Branch with paper.md (empty if default branch): main Version: DesalSim 1.0.1 (https://pypi.org/project/DesalSim/) Editor: !--editor-->@elbeejay<!--end-editor-- Reviewers: Pending Managing EiC: Kristen Thyng

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/30a1b99aee30ad44b72c6656b9625fb4"><img src="https://joss.theoj.org/papers/30a1b99aee30ad44b72c6656b9625fb4/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/30a1b99aee30ad44b72c6656b9625fb4/status.svg)](https://joss.theoj.org/papers/30a1b99aee30ad44b72c6656b9625fb4)

Author instructions

Thanks for submitting your paper to JOSS @rodoulak. Currently, there isn't a JOSS editor assigned to your paper.

@rodoulak if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

:warning: An error happened when generating the pdf.

[rodoulak]

Below is the list of reviewers:

• Demetrios G. Eliades (eldemet)
• Shubham Jain (shubhamjain15)
• Lokendra Singh Rathore (LSRathore)
• DARSakthi (DARSakthi)
• mewilhel (mewilhel)
• thermalogic (thermalogic)

[kthyng]

@editorialbot set main as branch

[editorialbot]

Done! branch is now main

[kthyng]

@editorialbot generate pdf

[editorialbot]

:warning: An error happened when generating the pdf.

[kthyng]

@rodoulak can you work on troubleshooting the paper compilation errors? You can recompile with the command I used.

[rodoulak]

@kthyng I fixed the error. It should be okay now.

[kthyng]

@editorialbot generate pdf

[editorialbot]

:warning: An error happened when generating the pdf.

[kthyng]

@rodoulak Sorry I don't see a difference. Can you tell what the error is?

[rodoulak]

@kthyng I checked the error, and there was a problem with line 65 in the bib file. I deleted that line (URL). I don't know how to generate the PDF, so I can test if it works now.

[kthyng]

@editorialbot generate pdf

@rodoulak you can run this command yourself to check

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[kthyng]

@editorialbot check repository

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=0.07 s (769.3 files/s, 170676.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          37           1466           2132           4526
Markdown                        15            564              0           3093
TeX                              2              3              0            196
-------------------------------------------------------------------------------
SUM:                            54           2033           2132           7815
-------------------------------------------------------------------------------

Commit count by author:

   189  rodoulak
    34  Rodoula Ktori

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 850

✅ The paper includes a Statement of need section

[editorialbot]

License info:

✅ License found: MIT License (Valid open source OSI approved license)

[kthyng]

@editorialbot check references

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.desal.2010.10.035 is OK
- 10.1016/j.renene.2011.03.040 is OK
- 10.1021/acssuschemeng.2c06636 is OK
- 10.1016/j.desal.2020.114928 is OK
- 10.3390/membranes6010003 is OK
- 10.1016/B978-0-444-50810-2.50018-X is OK
- 10.1016/j.desal.2013.03.033 is OK
- 10.36227/techrxiv.170595103.36689587/v1 is OK
- 10.1016/j.jclepro.2020.122472 is OK
- 10.1016/j.desal.2022.116005 is OK
- 10.1016/j.desal.2018.11.018 is OK
- 10.1016/j.jece.2021.105338 is OK
- 10.3390/separations9100295 is OK
- 10.1080/19443994.2014.948660 is OK
- 10.1016/j.desal.2024.117562 is OK

MISSING DOIs

- No DOI given, and none found for title: Plant design and economics for chemical engineers
- No DOI given, and none found for title: Deliverable 3.1 Report on the design procedure inc...
- No DOI given, and none found for title: WAVE Water Treatment Design Software
- 10.36227/techrxiv.170594775.55495325/v1 may be a valid DOI for title: Designing for the future: A Value-Sensitive Approa...

INVALID DOIs

- None

[kthyng]

Hi @rodoulak and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:

• [x] OSI-approved license
• [x] Installation instructions
• [x] Documentation
• [x] Tests of some sort
• [x] Check paper
• [x] Substantial scholarly effort
• [x] Clear research application/in scope

In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address that DOI issue.

[kthyng]

We have a backlog of submissions so I will add this to our waitlist. Thanks for your patience.

[kthyng]

@AdamRJensen Might you be able to edit this submission?

[kthyng]

@editorialbot invite @AdamRJensen as editor

[editorialbot]

Invitation to edit this submission sent!

[AdamRJensen]

@editorialbot invite @AdamRJensen as editor

Unfortunately not, I'm running busy with three other JOSS submissions and other work

[kthyng]

ok thanks

[arfon]

@editorialbot generate pdf

☝ to generate the most similar paper recommenders

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[editorialbot]

Five most similar historical JOSS papers:

RHEIA: Robust design optimization of renewable Hydrogen and dErIved energy cArrier systems Submitting author: @DCoppitters Handling editor: @fraukewiese (Active) Reviewers: @andr1976, @ClaraBuettner Similarity score: 0.8233

SIMsalabim: An open-source drift-diffusion simulator for semiconductor devices Submitting author: @ljakoster Handling editor: @rkurchin (Active) Reviewers: @UTH-Tuan, @shahmoradi, @roderickmackenzie Similarity score: 0.8161

OPEM : Open Source PEM Cell Simulation Tool Submitting author: @sepandhaghighi Handling editor: @katyhuff (Retired) Reviewers: @nnadeau Similarity score: 0.8161

PySWMM: The Python Interface to Stormwater Management Model (SWMM) Submitting author: @katmratliff Handling editor: @kbarnhart (Retired) Reviewers: @nickrsan, @jrkasprzyk Similarity score: 0.8153

PorousFlow: a multiphysics simulation code for coupled problems in porous media Submitting author: @WilkAndy Handling editor: @jedbrown (Active) Reviewers: @jbrezmorf, @rpodgorney Similarity score: 0.8133

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

[kthyng]

@elbeejay Can you edit this submission?

[kthyng]

@editorialbot invite @elbeejay as editor

[editorialbot]

Invitation to edit this submission sent!

[elbeejay]

@editorialbot assign @elbeejay as editor

Will likely be able to take a look at this sometime next week.

[editorialbot]

Assigned! @elbeejay is now the editor

[elbeejay]

@rodoulak - would you consider cleaning up the repository a bit before we send it out for review? It looks like a lot of Python auxiliary files and folders that are typically skipped over by git (such as the build/lib, dist, .egg-info folders) are in your repository.

I'd suggest looking at GitHub's Python .gitignore file and potentially adopting it to help manage the files that get pushed up to the GitHub repository. I am happy to hear reasons for why all of those files would need to be included, but it is atypical of a Python project.

Thanks, Jay