[PRE REVIEW]: NRT: operational monitoring of satellite image time-series in python

[editorialbot]

Submitting author: !--author-handle-->@loicdtx<!--end-author-handle-- (Loïc Dutrieux) Repository: https://github.com/ec-jrc/nrt Branch with paper.md (empty if default branch): joss-paper Version: 0.2.0 Editor: !--editor-->@AdamRJensen<!--end-editor-- Reviewers: @alexgleith, @szwiep Managing EiC: Kristen Thyng

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/34026e580e4ed548596e59f1ab5e1e0e"><img src="https://joss.theoj.org/papers/34026e580e4ed548596e59f1ab5e1e0e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/34026e580e4ed548596e59f1ab5e1e0e/status.svg)](https://joss.theoj.org/papers/34026e580e4ed548596e59f1ab5e1e0e)

Author instructions

Thanks for submitting your paper to JOSS @loicdtx. Currently, there isn't a JOSS editor assigned to your paper.

@loicdtx if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

:warning: An error happened when generating the pdf.

[kthyng]

@editorialbot check repository

[kthyng]

@loicdtx Can you take a look at the error above? It seems to be stopping the automatic processes from running.

[loicdtx]

Dear @kthyng thanks for handling this pre-review.

About potential reviewers

From the list of people that have agreed to review I have identified two potential good fit:

• Tobias Seydewitz (tobijjah)
• Sarah Zwiep (szwiep)

And another not in the list:

• Alex Leith (alexgleith)

Regarding the error

I double checked everything (repository is public and url is correct, branch name is correct, manuscript builds flawlessly using the docker image) and couldn't find the source of the issue. Could it just be bad luck?

[loicdtx]

@editorialbot generate pdf

[editorialbot]

:warning: An error happened when generating the pdf.

[loicdtx]

Build is still failing at the download/clone stage. I explored https://github.com/xuanxu/theoj/blob/main/lib/theoj/paper.rb and https://github.com/xuanxu/paper-action/blob/main/get_paper.rb but couldn't figure out anything obvious; I also don't know much ruby. I tried cloning fully anonymously (from a clean docker container) and that worked fine (git clone -b joss-paper https://github.com/ec-jrc/nrt)

Therefore still a mystery to me why that build does not succeed!

[kthyng]

@openjournals/dev Could you help debug this paper compilation error? Thank you!

[danielskatz]

This is an error that's happened on a few submissions over the last few days, and it seems to be somewhat transient.

[kthyng]

@editorialbot generate pdf

[editorialbot]

:warning: An error happened when generating the pdf.

[kthyng]

Thanks @danielskatz we can try again in a little bit.

[loicdtx]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[kthyng]

@editorialbot check repository

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=0.34 s (161.1 files/s, 416244.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              1              1              1         133737
Python                          26            478           1785           1446
CSV                             10              0              0            761
reStructuredText                 9            258            197            340
TeX                              1             21              0            191
Markdown                         1             45              0            108
YAML                             2             14             17             76
DOS Batch                        1              8              1             26
INI                              1              0              0             11
make                             1              4              7              9
JSON                             1              0              0              1
-------------------------------------------------------------------------------
SUM:                            54            829           2008         136706
-------------------------------------------------------------------------------

Commit count by author:

   202  Jonas Viehweger
   100  Loïc Dutrieux
     6  Loic Dutrieux
     4  Jonas
     1  ash5thpeak

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 1775

✅ The paper includes a Statement of need section

[editorialbot]

License info:

🟡 License found: European Union Public License 1.2 (Check here for OSI approval)

[kthyng]

@editorialbot check references

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.future.2017.11.007 is OK

MISSING DOIs

- 10.2307/2998540 may be a valid DOI for title: Estimating and testing linear models with multiple...
- No DOI given, and none found for title: On-the-fly massively multitemporal change detectio...
- No DOI given, and none found for title: API design for machine learning software: experien...
- 10.1016/j.rse.2019.04.018 may be a valid DOI for title: Improved change monitoring using an ensemble of ti...
- 10.1016/j.rse.2022.113043 may be a valid DOI for title: Timeliness in forest change monitoring: A new asse...
- No DOI given, and none found for title: State of Europe’s forests 2020
- No DOI given, and none found for title: The Open-source software ecosystem for leveraging ...
- 10.1016/j.rse.2010.07.008 may be a valid DOI for title: Detecting trends in forest disturbance and recover...
- 10.1109/igarss.2018.8517694 may be a valid DOI for title: Overview of the open data cube initiative
- No DOI given, and none found for title: Numba: A llvm-based python jit compiler
- No DOI given, and none found for title: Scikit-learn: Machine learning in Python
- 10.3390/rs12193135 may be a valid DOI for title: A near real-time method for forest change detectio...
- No DOI given, and none found for title: SpatioTemporal Asset Catalog (STAC) specification
- 10.1016/j.rse.2012.02.022 may be a valid DOI for title: Near real-time disturbance detection using satelli...
- 10.1016/j.rse.2019.111558 may be a valid DOI for title: Transitioning from change detection to monitoring ...
- No DOI given, and none found for title: strucchange: An R package for testing for structur...
- 10.1002/jae.776 may be a valid DOI for title: Monitoring structural change in dynamic econometri...
- 10.1016/j.rse.2011.10.030 may be a valid DOI for title: Continuous monitoring of forest disturbance using ...
- 10.1016/j.rse.2014.01.011 may be a valid DOI for title: Continuous change detection and classification of ...
- No DOI given, and none found for title: Continuous monitoring of land disturbance based on...

INVALID DOIs

- None

[kthyng]

Hi @loicdtx and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:

• [x] OSI-approved license
• [x] Installation instructions
• [x] Documentation
• [x] Tests of some sort
• [x] Check paper
• [x] Substantial scholarly effort
• [x] Clear research application/in scope

In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them.

[kthyng]

We have a backlog of submissions so I will add this to our waitlist. Thanks for your patience.

[AdamRJensen]

@editorialbot assign @AdamRJensen as editor

[editorialbot]

Assigned! @AdamRJensen is now the editor

[AdamRJensen]

:wave: @tobijjah, @szwiep, @alexgleith, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

[alexgleith]

I'm open to reviewing this, sure, @AdamRJensen.

[szwiep]

Happy to review but I won't have time until June 15th. Let me know if that works, @AdamRJensen.

[AdamRJensen]

@editorialbot add @alexgleith as reviewer

[editorialbot]

@alexgleith added to the reviewers list!

[AdamRJensen]

@editorialbot add @szwiep as reviewer

@szwiep that' perfectly fine, very happy to have you on board

[editorialbot]

@szwiep added to the reviewers list!

[loicdtx]

Thanks everyone, editors and reviewers; great to see that review moving so fast! In the meantime I have added missing DOIs to most bib entries as suggested by the review bot.

[alexgleith]

What is the practical implementation of the review checklist? Do I create a comment and check through the items? Or does that get added to the issue up the top and I complete it there?

[AdamRJensen]

@editorialbot start review

[editorialbot]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6815.