search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
717 stars 38 forks source link

[REVIEW]: superblockify: A Python Package for Automated Generation, Visualization, and Analysis of Potential Superblocks in Cities #6798

Closed editorialbot closed 2 months ago

editorialbot commented 4 months ago

Submitting author: !--author-handle-->@cbueth<!--end-author-handle-- (Carlson Büth) Repository: https://github.com/NERDSITU/superblockify Branch with paper.md (empty if default branch): submission Version: 1.0.0 Editor: !--editor-->@crvernon<!--end-editor-- Reviewers: @erexer, @caimeng2 Archive: 10.5281/zenodo.13300611

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/87426e988ebd0a6d7f592eb16d1fd209"><img src="https://joss.theoj.org/papers/87426e988ebd0a6d7f592eb16d1fd209/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/87426e988ebd0a6d7f592eb16d1fd209/status.svg)](https://joss.theoj.org/papers/87426e988ebd0a6d7f592eb16d1fd209)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@erexer & @dinacmistry, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @crvernon know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @erexer

📝 Checklist for @caimeng2

editorialbot commented 2 months ago 
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 2 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Büth given-names: Carlson M. orcid: "https://orcid.org/0000-0003-2298-8438" - family-names: Vybornova given-names: Anastassia orcid: "https://orcid.org/0000-0001-6915-2561" - family-names: Szell given-names: Michael orcid: "https://orcid.org/0000-0003-3022-2483" doi: 10.5281/zenodo.13300611 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Büth given-names: Carlson M. orcid: "https://orcid.org/0000-0003-2298-8438" - family-names: Vybornova given-names: Anastassia orcid: "https://orcid.org/0000-0001-6915-2561" - family-names: Szell given-names: Michael orcid: "https://orcid.org/0000-0003-3022-2483" date-published: 2024-08-14 doi: 10.21105/joss.06798 issn: 2475-9066 issue: 100 journal: Journal of Open Source Software publisher: name: Open Journals start: 6798 title: "superblockify: A Python Package for Automated Generation, Visualization, and Analysis of Potential Superblocks in Cities" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06798" volume: 9 title: "`superblockify`: A Python Package for Automated Generation, Visualization, and Analysis of Potential Superblocks in Cities" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 2 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 2 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5766
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06798
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

crvernon commented 2 months ago

@cbueth I noticed that you have backticks around the title in your paper. This causes formatting issues in the way our site formats your publication. Could you remove these? No need to conduct a new release or anything.

Let me know when this is done and I'll finalize this one.

Thanks.

cbueth commented 2 months ago

First, thank you for the editorial and review work, and accepting our submission! :clap:

@crvernon Sure, they were just removed in the paper.md on the submission branch, see https://github.com/NERDSITU/superblockify/commit/64730fb208805e95c2b3a0accb7f2bc2ee77d50d.

crvernon commented 2 months ago

@editorialbot reaccept

editorialbot commented 2 months ago 
Rebuilding paper!
editorialbot commented 2 months ago

🌈 Paper updated!

New PDF and metadata files :point_right: https://github.com/openjournals/joss-papers/pull/5768

crvernon commented 2 months ago

🥳 Congratulations on your new publication @cbueth! Many thanks to @erexer and @caimeng2 for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts.

Please consider becoming a reviewer for JOSS if you are not already: https://reviewers.joss.theoj.org/join

editorialbot commented 2 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06798/status.svg)](https://doi.org/10.21105/joss.06798)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06798">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06798/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06798/status.svg
   :target: https://doi.org/10.21105/joss.06798

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: