search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
703 stars 36 forks source link

[REVIEW]: NRT: operational monitoring of satellite image time-series in python #6815

Closed editorialbot closed 3 weeks ago

editorialbot commented 3 months ago

Submitting author: !--author-handle-->@loicdtx<!--end-author-handle-- (Loïc Dutrieux) Repository: https://github.com/ec-jrc/nrt Branch with paper.md (empty if default branch): joss-paper Version: 0.2.1 Editor: !--editor-->@AdamRJensen<!--end-editor-- Reviewers: @alexgleith, @szwiep Archive: 10.5281/zenodo.12799278

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/34026e580e4ed548596e59f1ab5e1e0e"><img src="https://joss.theoj.org/papers/34026e580e4ed548596e59f1ab5e1e0e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/34026e580e4ed548596e59f1ab5e1e0e/status.svg)](https://joss.theoj.org/papers/34026e580e4ed548596e59f1ab5e1e0e)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@alexgleith & @szwiep, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @AdamRJensen know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @szwiep

📝 Checklist for @alexgleith

editorialbot commented 3 months ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 3 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.33 s (164.1 files/s, 423991.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              1              1              1         133737
Python                          26            478           1785           1446
CSV                             10              0              0            761
reStructuredText                 9            258            197            340
TeX                              1             18              0            176
Markdown                         1             45              0            108
YAML                             2             14             17             76
DOS Batch                        1              8              1             26
INI                              1              0              0             11
make                             1              4              7              9
JSON                             1              0              0              1
-------------------------------------------------------------------------------
SUM:                            54            826           2008         136691
-------------------------------------------------------------------------------

Commit count by author:

   202  Jonas Viehweger
   102  Loïc Dutrieux
     6  Loic Dutrieux
     4  Jonas
     1  ash5thpeak
editorialbot commented 3 months ago

Paper file info:

📄 Wordcount for paper.md is 1775

✅ The paper includes a Statement of need section

editorialbot commented 3 months ago

License info:

🟡 License found: European Union Public License 1.2 (Check here for OSI approval)

editorialbot commented 3 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.2307/2998540 is OK
- 10.1109/TGRS.2013.2272545 is OK
- 10.48550/arXiv.1309.0238 is OK
- 10.1016/j.rse.2019.04.018 is OK
- 10.1016/j.rse.2022.113043 is OK
- 10.1109/IGARSS.2018.8517694 is OK
- 10.1145/2833157.2833162 is OK
- 10.48550/arXiv.1201.0490 is OK
- 10.1016/j.future.2017.11.007 is OK
- 10.1016/j.rse.2012.02.022 is OK
- 10.1016/j.rse.2019.111558 is OK
- 10.18637/jss.v007.i02 is OK
- 10.1002/jae.776 is OK
- 10.1016/j.rse.2011.10.030 is OK
- 10.1016/j.rse.2014.01.011 is OK

MISSING DOIs

- No DOI given, and none found for title: State of Europe’s forests 2020
- No DOI given, and none found for title: The Open-source software ecosystem for leveraging ...
- No DOI given, and none found for title: SpatioTemporal Asset Catalog (STAC) specification

INVALID DOIs

- None
editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

AdamRJensen commented 3 months ago

@alexgleith the review will happen in this issue here. Please read the above text and get back to me if you have any questions.

Note, I suggest that each reviewer adds a comment to this issue where you can add a link to all the issues/PRs you make in the actual package repository. This gives a good overview for the editor and the individual reviewers of the status of the raised issues/PRs.

loicdtx commented 3 months ago

Thanks @AdamRJensen for kicking off the review.

@editorialbot generate pdf

loicdtx commented 3 months ago

@editorialbot generate pdf

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

szwiep commented 3 months ago

Review checklist for @szwiep

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

AdamRJensen commented 3 months ago

@alexgleith to get started with the review, you simply need to add a comment to this repo with: "@editorialbot generate my checklist"

If you have any questions, don't hesitate to reach out 😄

alexgleith commented 2 months ago

Review checklist for @alexgleith

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

alexgleith commented 2 months ago

~There are a couple of issue that I think it would be good to resolve, @loicdtx. One is easy, by adding something to the readme about reporting issues and contributing, or adding a 'contributing.md' file.~

~The other is around reproducibility of the examples. I'd actually like an example that streamed data too, rather than using the dumped NetCDF files, but this might be out of scope and too much effort. Pinning xarray or other library versions so that the sample code works for others (like me!) will be enough to get this over the line for me.~

loicdtx commented 2 months ago

Thank you for your review, @alexgleith, and for the valuable suggestions. I've incorporated them, and the project now includes a CONTRIBUTING.md file. Additionally, the online documentation now features a new example that fetches data directly from a cloud archive. This was quite a bit of work, but it was definitely worth it. We've had this in the pipeline for a while, and it just needed this little push.

alexgleith commented 2 months ago

No worries, @loicdtx. Thanks for giving me the opportunity to review!

AdamRJensen commented 2 months ago

Hi @szwiep - at JOSS we aim to have reviews completed within 4-6 weeks. I hope you're able to start soon on the checklist (the first items are easy and a great way to get started).

szwiep commented 2 months ago

Thanks for the ping @AdamRJensen and for your patience @loicdtx. I've completed my first pass through the project and added some issues:

This is super exciting software, even more so because your team is putting it out into the open-source world. Looking forward to moving it through the review process!

loicdtx commented 2 months ago

Thanks for your review as well as the clear and constructive issues @szwiep . I believe I've addressed them all; let me know if you think something isn't right or missing.

szwiep commented 2 months ago

The changes look great, @loicdtx. No other comments on my side.

@AdamRJensen, I've completed my review and all issues have been addressed!

AdamRJensen commented 2 months ago

@AdamRJensen, I've completed my review and all issues have been addressed!

@szwiep could you tick off the functionality check box if you've done that. And thank you for your swift review!

AdamRJensen commented 1 month ago

@editorialbot generate pdf

AdamRJensen commented 1 month ago

@editorialbot check references

editorialbot commented 1 month ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.2307/2998540 is OK
- 10.1109/TGRS.2013.2272545 is OK
- 10.48550/arXiv.1309.0238 is OK
- 10.1016/j.rse.2019.04.018 is OK
- 10.1016/j.rse.2022.113043 is OK
- 10.1109/IGARSS.2018.8517694 is OK
- 10.1145/2833157.2833162 is OK
- 10.48550/arXiv.1201.0490 is OK
- 10.1016/j.future.2017.11.007 is OK
- 10.1016/j.rse.2012.02.022 is OK
- 10.1016/j.rse.2019.111558 is OK
- 10.18637/jss.v007.i02 is OK
- 10.1002/jae.776 is OK
- 10.1016/j.rse.2011.10.030 is OK
- 10.1016/j.rse.2014.01.011 is OK

MISSING DOIs

- No DOI given, and none found for title: State of Europe’s forests 2020
- No DOI given, and none found for title: The Open-source software ecosystem for leveraging ...
- No DOI given, and none found for title: SpatioTemporal Asset Catalog (STAC) specification

INVALID DOIs

- None
editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

AdamRJensen commented 1 month ago

Post-Review Checklist for Editor and Authors

Additional Author Tasks After Review is Complete

Editor Tasks Prior to Acceptance

AdamRJensen commented 1 month ago

It would be nice if the nrt acronym was mentioned (near real time)

Also, I've opened a number of issues and PRs in the repository that I hope you're able to address.

Otherwise, things are looking good! 🥳

AdamRJensen commented 1 month ago

@loicdtx could you make a new release and upload to Zenodo. I'll need the latest package version and the Zenodo DOI. Thanks.

loicdtx commented 1 month ago

@AdamRJensen I pushed this release last week https://github.com/ec-jrc/nrt/releases/tag/v0.2.1

The zenodo project archive is pending approval of the EU funded project community https://zenodo.org/uploads/12799278

AdamRJensen commented 1 month ago

@editorialbot set 0.2.1 as version

editorialbot commented 1 month ago

Done! version is now 0.2.1

AdamRJensen commented 1 month ago

The zenodo project archive is pending approval of the EU funded project community https://zenodo.org/uploads/12799278

@loicdtx OK let me know once it is approved and we can proceed with the submission

loicdtx commented 3 weeks ago

@AdamRJensen the repo finally got approved on Zenodo (https://zenodo.org/records/12799278). There were a couple of changes (mostly to documentation) since that release. Nothing that would justify a full version release, but I could make a post release to pypi and Zenodo if you think that's necessary.

AdamRJensen commented 3 weeks ago

@editorialbot set 10.5281/zenodo.12799278 as archive

editorialbot commented 3 weeks ago

Done! archive is now 10.5281/zenodo.12799278

AdamRJensen commented 3 weeks ago

@editorialbot set 0.2.1 as version

editorialbot commented 3 weeks ago

Done! version is now 0.2.1

AdamRJensen commented 3 weeks ago

@editorialbot generate pdf

editorialbot commented 3 weeks ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

AdamRJensen commented 3 weeks ago

@editorialbot recommend-accept

editorialbot commented 3 weeks ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 3 weeks ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.2307/2998540 is OK
- 10.1109/TGRS.2013.2272545 is OK
- 10.48550/arXiv.1309.0238 is OK
- 10.1016/j.rse.2019.04.018 is OK
- 10.1016/j.rse.2022.113043 is OK
- 10.1109/IGARSS.2018.8517694 is OK
- 10.1145/2833157.2833162 is OK
- 10.48550/arXiv.1201.0490 is OK
- 10.1016/j.future.2017.11.007 is OK
- 10.1016/j.rse.2012.02.022 is OK
- 10.1016/j.rse.2019.111558 is OK
- 10.18637/jss.v007.i02 is OK
- 10.1002/jae.776 is OK
- 10.1016/j.rse.2011.10.030 is OK
- 10.1016/j.rse.2014.01.011 is OK

MISSING DOIs

- No DOI given, and none found for title: State of Europe’s forests 2020
- No DOI given, and none found for title: The Open-source software ecosystem for leveraging ...
- No DOI given, and none found for title: SpatioTemporal Asset Catalog (STAC) specification

INVALID DOIs

- None
editorialbot commented 3 weeks ago

:wave: @openjournals/ese-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5762, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

kthyng commented 3 weeks ago

Hi! I'll take over now as Track Associate Editor in Chief to do some final submission editing checks. After these checks are complete, I will publish your submission!

kthyng commented 3 weeks ago

Ok looks ready to go!

kthyng commented 3 weeks ago

@editorialbot accept

editorialbot commented 3 weeks ago 
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 3 weeks ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Dutrieux given-names: Loïc orcid: "https://orcid.org/0000-0002-5058-2526" - family-names: Viehweger given-names: Jonas orcid: "https://orcid.org/0000-0002-1610-4600" doi: 10.5281/zenodo.12799278 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Dutrieux given-names: Loïc orcid: "https://orcid.org/0000-0002-5058-2526" - family-names: Viehweger given-names: Jonas orcid: "https://orcid.org/0000-0002-1610-4600" date-published: 2024-08-15 doi: 10.21105/joss.06815 issn: 2475-9066 issue: 100 journal: Journal of Open Source Software publisher: name: Open Journals start: 6815 title: "nrt: operational monitoring of satellite image time-series in Python" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06815" volume: 9 title: "nrt: operational monitoring of satellite image time-series in Python" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 3 weeks ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 3 weeks ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5773
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06815
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...