openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
694 stars 36 forks source link

[REVIEW]: DFM Generator v2.2: a new method for simulating the growth of natural fracture networks #6818

Open editorialbot opened 4 weeks ago

editorialbot commented 4 weeks ago

Submitting author: !--author-handle-->@JointFlow<!--end-author-handle-- (Michael Welch) Repository: https://github.com/JointFlow/DFMGenerator Branch with paper.md (empty if default branch): Version: v2.2.2 Editor: !--editor-->@diehlpk<!--end-editor-- Reviewers: !--reviewers-list-->@CBenghi<!--end-reviewers-list-- Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/32db13931bcebe707f05aeb1b394dfb0"><img src="https://joss.theoj.org/papers/32db13931bcebe707f05aeb1b394dfb0/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/32db13931bcebe707f05aeb1b394dfb0/status.svg)](https://joss.theoj.org/papers/32db13931bcebe707f05aeb1b394dfb0)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@CBenghi, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @diehlpk know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@CBenghi, please create your checklist typing: @editorialbot generate my checklist

editorialbot commented 4 weeks ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 4 weeks ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1029/jb089ib06p04077 is OK
- 10.1088/0959-5309/58/6/312 is OK
- 10.1016/0020-7225(65)90028-5 is OK
- 10.1029/jb089ib06p04137 is OK
- 10.1144/petgeo2018-161 is OK
- 10.1007/978-3-030-52414-2 is OK

MISSING DOIs

- None

INVALID DOIs

- 0.1098/rsta.1921.0006 is INVALID
editorialbot commented 4 weeks ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.83 s (64.1 files/s, 340826.0 lines/s)
------------------------------------------------------------------------------------
Language                          files          blank        comment           code
------------------------------------------------------------------------------------
HTML                                  1            400           4463         221510
C#                                   30           3276          12796          28948
XML                                  13             33            144           5552
C# Designer                           1              7            852           2959
MSBuild script                        3              0             23            364
Markdown                              2             68              0            135
TeX                                   1              6              0             57
Visual Studio Solution                1              1              1             45
YAML                                  1              1              4             18
------------------------------------------------------------------------------------
SUM:                                 53           3792          18283         259588
------------------------------------------------------------------------------------

Commit count by author:

    99  michael-welch00
    53  JointFlow
     2  Mikael Lüthje
     2  Simon Oldfield
     1  Mikael Luthje
     1  joint
     1  mend-bolt-for-github[bot]
editorialbot commented 4 weeks ago

Paper file info:

📄 Wordcount for paper.md is 937

✅ The paper includes a Statement of need section

editorialbot commented 4 weeks ago

License info:

✅ License found: Apache License 2.0 (Valid open source OSI approved license)

editorialbot commented 4 weeks ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left: