[PRE REVIEW]: SpectralModel: a high-resolution framework for petitRADTRANS 3

[editorialbot]

Submitting author: !--author-handle-->@doriannblain<!--end-author-handle-- (Doriann Blain) Repository: https://gitlab.com/mauricemolli/petitRADTRANS Branch with paper.md (empty if default branch): JOSS_SpectralModel Version: v3.1.0 Editor: !--editor-->@mbobra<!--end-editor-- Reviewers: @spectralcode, @benhord Managing EiC: Dan Foreman-Mackey

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/469aeb551c40debea6fc944bb64af1cf"><img src="https://joss.theoj.org/papers/469aeb551c40debea6fc944bb64af1cf/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/469aeb551c40debea6fc944bb64af1cf/status.svg)](https://joss.theoj.org/papers/469aeb551c40debea6fc944bb64af1cf)

Author instructions

Thanks for submitting your paper to JOSS @doriannblain. Currently, there isn't a JOSS editor assigned to your paper.

@doriannblain if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3847/1538-3881/ad2c8b is OK
- 10.3847/1538-3881/aaffd3 is OK
- 10.21105/joss.00024 is OK
- 10.1093/mnras/staa228 is OK
- 10.1051/0004-6361/200913396 is OK
- 10.1145/368996.369025 is OK
- 10.1051/0004-6361/201935470 is OK
- 10.21105/joss.05875 is OK
- 10.1111/j.1365-2966.2004.08585.x is OK

MISSING DOIs

- None

INVALID DOIs

- None

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=0.28 s (450.6 files/s, 228852.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          64           5878           6204          23301
Fortran 90                       4           1002            422           3671
Jupyter Notebook                16              0           9863           2991
HTML                             1              7              3           2763
XML                              2              0             20           2281
JSON                             7              0              0           1119
TeX                              4            114             37           1103
reStructuredText                 9            391           1168            695
Markdown                         3             80              0            489
Meson                           10             13              9            143
TOML                             1              5              2             90
make                             2             14             13             56
SQL                              1              0              0             24
YAML                             1              4             11             10
SVG                              1              0              1              3
-------------------------------------------------------------------------------
SUM:                           126           7508          17753          38739
-------------------------------------------------------------------------------

Commit count by author:

   652  Doriann Blain
   339  Evert Nasedkin
   321  mauricemolli
   201  dblain
   121  Paul Mollière
   101  Nicholas Evert Nasedkin
     7  Tomas Stolker
     6  Paul Molliere
     2  System Administrator
     1  samderegt

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 2121

✅ The paper includes a Statement of need section

[editorialbot]

License info:

✅ License found: MIT License (Valid open source OSI approved license)

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[dfm]

@doriannblain — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience!

In the meantime, can you please clarify exactly which parts of this code base are under consideration for this review, since petitRADTRANS has previously been reviewed. Thanks!

[doriannblain]

@dfm, thanks for letting me know.

can you please clarify exactly which parts of this code base are under consideration for this review

This paper is heavily focused on the new SpectralMoldel object and its high-resolution spectra simulation and retrieval frameworks.

There is also a small section on the petitRADTRANS 3 major update, which has a large impact on the entirety of the code base and drastically improves performances compared to petitRADTRANS 2. All of the documentation and tutorials has been updated to account for these changes. We think that only SpectralModel has a direct scientific application (and should therefore be the focus of this review), but we also believe that it is worth mentioning in this paper all the changes made in petitRADTRANS 3, as they enhances the users' productivity.

The previous paper was solely about the new retrieval module, and was referred while petitRADTRANS was in version 2. Some of the critics that the referees had then (e.g. the lack of support for Python 3.12+) have been addressed in version 3.

[dfm]

@editorialbot invite @mbobra as editor

[editorialbot]

Invitation to edit this submission sent!

[mbobra]

@editorialbot assign me as editor

[editorialbot]

Assigned! @mbobra is now the editor

[mbobra]

@doriannblain Thanks for your submission! If you have any suggestions for reviewers, please let me know here (you can give me the Github handle without @ mentioning them, e.g. mbobra instead of @mbobra).

[doriannblain]

@mbobra Thanks for accepting to be the editor of our submission. I unfortunately don't have any reviewer to suggest.

[mbobra]

@editorialbot add @spectralcode as reviewer

[editorialbot]

@spectralcode added to the reviewers list!

[mbobra]

@editorialbot add @benhord as reviewer

[editorialbot]

@benhord added to the reviewers list!

[mbobra]

@editorialbot start review

[editorialbot]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/7028.