openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[REVIEW]: AIgarMIC: a Python package for automated interpretation of agar dilution minimum inhibitory concentration testing #6826

Closed editorialbot closed 1 month ago

editorialbot commented 5 months ago

Submitting author: !--author-handle-->@agerada<!--end-author-handle-- (Alessandro Gerada) Repository: https://github.com/agerada/AIgarMIC Branch with paper.md (empty if default branch): Version: v1.1.1 Editor: !--editor-->@ppxasjsm<!--end-editor-- Reviewers: !--reviewers-list-->@gchure<!--end-reviewers-list-- Archive: 10.5281/zenodo.13628882

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f8a8b53b63b01930260bfeb2d3b60d48"><img src="https://joss.theoj.org/papers/f8a8b53b63b01930260bfeb2d3b60d48/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f8a8b53b63b01930260bfeb2d3b60d48/status.svg)](https://joss.theoj.org/papers/f8a8b53b63b01930260bfeb2d3b60d48)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@gchure, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @ppxasjsm know.

āœØ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest āœØ

Checklists

šŸ“ Checklist for @gchure

ppxasjsm commented 1 month ago

Thanks!

Kevin-Mattheus-Moerman commented 1 month ago

@editorialbot set v1.1.1 as version

editorialbot commented 1 month ago

Done! version is now v1.1.1

Kevin-Mattheus-Moerman commented 1 month ago

@agerada as AEiC for JOSS I will now help to process this submission for acceptance in JOSS. I have checked this review, your repository, the archive link, and the paper. Most seems in order, however the below are some points that require your attention in relation to the ZENODO archive. Please do not create a new archive, simply edit the current:

agerada commented 1 month ago

Thank you @Kevin-Mattheus-Moerman, I have made the changes (title and authors) to the ZENODO archive (https://zenodo.org/doi/10.5281/zenodo.13628882).

Kevin-Mattheus-Moerman commented 1 month ago

@agerada thanks, all looks good now.

Kevin-Mattheus-Moerman commented 1 month ago

@editorialbot accept

editorialbot commented 1 month ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 1 month ago

:warning: Couldn't acccept/publish paper. An error happened.

Kevin-Mattheus-Moerman commented 1 month ago

@editorialbot accept

editorialbot commented 1 month ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 1 month ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - email: alessandro.gerada@liverpool.ac.uk family-names: Gerada given-names: Alessandro orcid: "https://orcid.org/0000-0002-6743-4271" - email: nharper@liverpool.ac.uk family-names: Harper given-names: Nicholas orcid: "https://orcid.org/0009-0000-1705-0619" - email: Alexander.Howard@liverpool.ac.uk family-names: Howard given-names: Alex orcid: "https://orcid.org/0000-0002-4195-6821" - email: hopew@liverpool.ac.uk family-names: Hope given-names: William orcid: "https://orcid.org/0000-0001-6187-878X" doi: 10.5281/zenodo.13628882 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - email: alessandro.gerada@liverpool.ac.uk family-names: Gerada given-names: Alessandro orcid: "https://orcid.org/0000-0002-6743-4271" - email: nharper@liverpool.ac.uk family-names: Harper given-names: Nicholas orcid: "https://orcid.org/0009-0000-1705-0619" - email: Alexander.Howard@liverpool.ac.uk family-names: Howard given-names: Alex orcid: "https://orcid.org/0000-0002-4195-6821" - email: hopew@liverpool.ac.uk family-names: Hope given-names: William orcid: "https://orcid.org/0000-0001-6187-878X" date-published: 2024-09-16 doi: 10.21105/joss.06826 issn: 2475-9066 issue: 101 journal: Journal of Open Source Software publisher: name: Open Journals start: 6826 title: "AIgarMIC: a Python package for automated interpretation of agar dilution minimum inhibitory concentration assays" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06826" volume: 9 title: "AIgarMIC: a Python package for automated interpretation of agar dilution minimum inhibitory concentration assays" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 month ago

šŸ˜šŸ˜šŸ˜ šŸ‘‰ Toot for this paper šŸ‘ˆ šŸ˜šŸ˜šŸ˜

editorialbot commented 1 month ago

šŸšØšŸšØšŸšØ THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! šŸšØšŸšØšŸšØ

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5885
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06826
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! šŸŽ‰šŸŒˆšŸ¦„šŸ’ƒšŸ‘»šŸ¤˜

Any issues? Notify your editorial technical team...

Kevin-Mattheus-Moerman commented 1 month ago

@agerada congratulations on this publication!

Thanks for editing @ppxasjsm !

And a special thanks to the reviewers: @gchure !!!

editorialbot commented 1 month ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06826/status.svg)](https://doi.org/10.21105/joss.06826)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06826">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06826/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06826/status.svg
   :target: https://doi.org/10.21105/joss.06826

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

agerada commented 1 month ago

Thank you @Kevin-Mattheus-Moerman. Just wanted to say a quick thank you to @ppxasjsm and @gchure for their input on this work and the very constuctive reviews. I look forward to contributing to JOSS in the future.