Open editorialbot opened 3 months ago
editorialbot
commented
3 months ago Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.
For a list of things I can do to help you, just type:
@editorialbot commandsFor example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
@editorialbot generate pdfSoftware report:
github.com/AlDanial/cloc v 1.90 T=0.27 s (279.2 files/s, 492984.1 lines/s)
-------------------------------------------------------------------------------
Language files blank comment code
-------------------------------------------------------------------------------
CSV 3 0 0 116689
Python 25 1389 1919 4327
Markdown 28 646 0 2153
Jupyter Notebook 11 0 3660 747
HTML 1 32 1 396
TeX 1 20 1 178
YAML 4 20 6 166
TOML 1 4 0 52
CSS 1 2 0 10
-------------------------------------------------------------------------------
SUM: 75 2113 5587 124718
-------------------------------------------------------------------------------Commit count by author:
161 masoudabedinifar
160 Julius Welzel
56 github-actions
47 rmndrs89
37 Robbin Romijnders
34 jwelzel
21 JuliusWelzel
3 dependabot[bot]Paper file info:
📄 Wordcount for paper.md is 1120
✅ The paper includes a Statement of need section
editorialbot
commented
3 months ago License info:
🟡 License found: Other (Check here for OSI approval)
editorialbot
commented
3 months ago Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.3390/brainsci9020034 is OK
- 10.1016/j.medengphy.2020.11.005 is OK
- 10.21105/joss.01778 is OK
- 10.1016/S1474-4422(20)30033-8 is OK
- 10.1038/sdata.2016.44 is OK
- 10.3233/JPD-181498 is OK
- 10.1109/OJEMB.2024.3356791 is OK
- 10.1002/mds.28377 is OK
- 10.1186/s12984-023-01198-5 is OK
- 10.3389/fneur.2017.00135 is OK
- 10.3389/fneur.2018.00652 is OK
- 10.1016/S1474-4422(19)30397-7 is OK
MISSING DOIs
- 10.31234/osf.io/w6z79 may be a valid DOI for title: Motion-BIDS: extending the Brain Imaging Data Stru...
- 10.1371/journal.pone.0069627 may be a valid DOI for title: Prevalence and burden of gait disorders in elderly...
- No DOI given, and none found for title: Technical validation of real-world monitoring of g...
- 10.1186/s12984-019-0494-z may be a valid DOI for title: Locomotion and cadence detection using a single tr...
- 10.1109/embc44109.2020.9176281 may be a valid DOI for title: Real-world speed estimation using single trunk IMU...
- No DOI given, and none found for title: Estimate Gait Quality Composite
- No DOI given, and none found for title: Mobilise-D Technical Validation Study Recommended ...
INVALID DOIs
- None
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
Kevin-Mattheus-Moerman
commented
3 months ago @aaa34169, @davidpagnon thanks for agreeing to review this submission. This is where the review takes place. Please get started by calling @editorialbot generate my checklist. We hope you can provide your review within about 2-3 weeks but do let me know if you need more time. Thanks again!
aaa34169
commented
3 months ago 
davidpagnon
commented
3 months ago 
JuliusWelzel
commented
2 months ago No worries 😄 I will delete our comments as well
davidpagnon
commented
2 months ago Most of the example files not available --> https://github.com/neurogeriatricskiel/NGMT/issues/90
davidpagnon
commented
2 months ago Here is a first pass for the review:
pip install ngmt --user)Statement of need: I would like more detail to be given about each of the 4 modules. I feel like someone skimming the paper could easily miss that there are actually 4 main modules, and if they do, they may not understand what they consist in. Why are these 4 modules (+ the ones under development: "postural transition analysis" and "turns") specifically useful? I would also appreciate it if you provided the gist of the theory behind each module.
Why are accelerometers better than vision-based approaches in your context? Supposedly because unlike being filmed, one can wear accelerometers all day long and at any place.
I do not understand the end of the sentence L33: "DHT [...] offers a new dimension of measuring daily function, that is, performance"
One subsidiary remark: NGMT is just a sequence of letters that will not bear any meaning to anyone who comes across it; moreover, I think this toolbox could be useful to many more cases than the very specific field of neurogeriatric motion. For the sake of dissemination, would it be worth finding another name?
Kevin-Mattheus-Moerman
commented
1 month ago @aaa34169 I hope you are doing well. Could you provide an update on where things stand? If you need more time let us know. Thanks again for your help!
Kevin-Mattheus-Moerman
commented
1 month ago @JuliusWelzel apologies for the delay with this review so far. We'll see if we here from @aaa34169, if they are still able to help we'll resume, if not we'll try to find an alternative reviewer.
JuliusWelzel
commented
1 month ago Thanks @davidpagnon for your comprehensive review. We have updated the toolbox and made a new release, so the example datasets can now be fetched from public repos. Let us know if everything works.
- Data sharing: Two large datasets are natively supported (Keep Control and Mobilize-D), and tools are provided to load them. Example files for tutorials are missing for now.
Examples for ICD and GSD have been added as part of #102. They can be simply loaded as shown in this example.
It would be good to add a line stating that it has been gathered in accordance with the Declaration of Helsinki.
This has been added in https://github.com/neurogeriatricskiel/KielMAT/commit/8fa81ad785b6a9120e2a3c9cdf9524c27acfe3ca
It may be worth specifying that the expected motion data are 3D accelerations (from the wrist or the lower-back depending on the module).
A table with an overview has been added on the landing page in
- Community guidelines: Issues have been activated on the repository so the user can report issues or seek support; there are contribution guidelines on the website and in the paper, but it would be good to refer to them in the Readme.md file.
We have added a link and statement about contributing in the README.
Software paper
- Summary: It is not immediately clear from the paper what kind of data the toolbox uses: marker-based data? Video input? RGB-D? IMUs? I suppose any piece of hardware could be suitable as long as it can provide acceleration data (from the pelvis? the wrist?), but it is not stated. I would be more specific very early on, for example by specifying which type of motion data is expected L12: "NGMT offers a range of 12 algorithms for the processing of motion data in neuroscience and biomechanics".
We have updated the summary in https://github.com/neurogeriatricskiel/KielMAT/commit/a62e73108f44192dade141ce92d335053f51e768
- Statement of need: I would like more detail to be given about each of the 4 modules. I feel like someone skimming the paper could easily miss that there are actually 4 main modules, and if they do, they may not understand what they consist in. Why are these 4 modules (+ the ones under development: "postural transition analysis" and "turns") specifically useful? I would also appreciate it if you provided the gist of the theory behind each module. Why are accelerometers better than vision-based approaches in your context? Supposedly because unlike being filmed, one can wear accelerometers all day long and at any place. I do not understand the end of the sentence L33: "DHT [...] offers a new dimension of measuring daily function, that is, performance"
We have updated the text in various commits to address these valuable comments
One subsidiary remark: NGMT is just a sequence of letters that will not bear any meaning to anyone who comes across it; moreover, I think this toolbox could be useful to many more cases than the very specific field of neurogeriatric motion. For the sake of dissemination, would it be worth finding another name?
We thank you for pointing this out. We have change the name of the toolbox to KielMotionAnalysisToolbox (KielMAT).
- State of the field: It may be interesting to cite other approaches not using acceleration-based data, such as the Mobile gait-lab (paper and code): although it works from video input and focuses on different quantities (walking speed, cadence, maximum knee flexion, and gait deviation), the approach is globally similar in that it is open-source and meant to be easily accessible to non computer-science specialists. Sit2Stand and Sports2D are other repositories that could make it to this section.
We adapted the text in the following commit: https://github.com/neurogeriatricskiel/KielMAT/commit/d8f471f1e023a043a831aef5cedbb6a16e7568e7
JuliusWelzel
commented
1 month ago @Kevin-Mattheus-Moerman We made a new release as parts of our responses to @davidpagnon. The available version is now 0.0.5.
davidpagnon
commented
1 month ago Thanks for addressing my points! I tried all the modules with the new version and they all work seamlessly.
Three last remarks:
It would be nice if there was a progress bar and/or message telling us that the mobilize dataset is being downloaded. I did not have any of it and it took a while, so I exited. When I relaunched it it did not work (invalid zip file) so I had to find where the dataset was stored, remove it, and type the command again. I believe you would just have to set this to True and it would show the progress bar:
https://github.com/neurogeriatricskiel/KielMAT/blob/a2b757a2f785aa3f43aba72dcfe357d363737dc2/kielmat/datasets/mobilised.py#L71
I had a timeout issue when downloading the keepcontrol dataset, but then the demo still worked so I would not worry. It may be on my end, my connection is not especially fast.
RuntimeError: Timeout when trying to download D:\softs\KielMAT\kielmat\datasets\_keepcontrol\sub-pp001\motion\sub-pp001_task-calibration3_tracksys-omc_motion.tsv.
The user needs to pip install kielmat, but then also to git clone https://github.com/neurogeriatricskiel/KielMAT.git, and to cd keilmat or this tutorial will not work. It may be worth specifying it.
I feel like the Installation section should be at the very beginning of the home page. Right now the user has to dig to find how to install it and that may add a small obstacle to the adoption of the software.
JuliusWelzel
commented
1 month ago Hi,
thanks for getting back so quickly. All three points have been addressed as follows:
- It would be nice if there was a progress bar and/or message telling us that the mobilize dataset is being downloaded. I did not have any of it and it took a while, so I exited. When I relaunched it it did not work (invalid zip file) so I had to find where the dataset was stored, remove it, and type the command again. I believe you would just have to set this to True and it would show the progress bar.
We set the progressbar True as default in: 52a0386b1e4f2df6e8950db50abdf1f94aef5a7a
- The user needs to pip install kielmat, but then also to
git clone https://github.com/neurogeriatricskiel/KielMAT.git, and tocd keilmator this tutorial will not work. It may be worth specifying it.
Good point, we now allow the data for the example to be downloaded form the online repo directly in: d79baaa419fa487ece3f0bbc3514817a07375075
- I feel like the Installation section should be at the very beginning of the home page. Right now the user has to dig to find how to install it and that may add a small obstacle to the adoption of the software.
Agreed, we moved it up on the main page in: 3a001628f85c50405528c78cf5739f574d9c4c92
davidpagnon
commented
1 month ago It all looks good to me!
JuliusWelzel
commented
1 month ago It all looks good to me!
Amazing, thank you for your valuable comments :)
Kevin-Mattheus-Moerman
commented
1 month ago @aaa34169 I hope you are doing well. Could you provide an update on where things stand? If you need more time let us know. Thanks again for your help!
aaa34169
commented
1 month ago yes, i recovered from my two broken arms :-) . I think i can do the review by the end of the week.
Kevin-Mattheus-Moerman
commented
1 month ago @aaa34169 good to hear you recovered. Sounds like quite the trauma you went through. Thanks for still being willing to help, greatly appreciated! Looking forward to your contribution!
aaa34169
commented
1 month ago here is my review of NGMT: NeuroGeriatric Motion Toolbox - An Open-Source Python Toolbox for Analyzing Neurological Motion Data from Various Recording Modalities
General
NGMT is implemented in Python (>=3.10) and is available under the Non-Profit Open Software License version 3.0. It can be installed from PyPI or from source on GitHub.
The documentation includes comprehensive installation instructions, a conceptual framework, and tutorial notebooks.
The code utilizes downloadable data from sources such as the Mobilised and OpenNeuro projects. However, it is important to note that these downloads may encounter SSL errors when accessed from a secure network, such as that of a hospital.
Functionality
The library is easily installable with Python 3.10. The local installation using the command
pip install -e .
works flawlessly.
The modules serve well-defined purposes.
The library employs data from projects such as Mobilised or OpenNeuro. However, when accessed on a secure network, an "SSLCertVerificationError" exception may be returned. It would be beneficial to mention this potential error and ideally provide information on how to resolve or circumvent it. The library is intended for users such as rehabilitation center engineers or academic researchers who may want to use it on institutional workstations. It's important to prevent any potential reluctance from these users.
Regarding the data, I have also noted that the file "exAccelDataMobilise.csv" does not allow the example modules_03_pam to run successfully.
Documentation
The entirety of the library is documented and accessible .
To address common errors, I would recommend that the authors create a "Common Issues" or "Frequently Asked Questions" section.
In general, the documentation is intuitive and provides both high-level and low-level information. However, I find that the organization could be improved, particularly with a focus on the concept of DataClass and its usage.
First, I suggest that the horizontal menu place DataClass before modules. Additionally, on the Home page, it is pertinent to describe the "KielMATRecording" object thoroughly, accompanied specifically by an explanation demonstrating how to construct a KielMATRecording instance from the user’s own data, rather than from the Mobilised project dataset.
Moreover, on the Home page, the link https://neurogeriatricskiel.github.io/KielMAT/examples/00_tutorial_basics/ leads to a page with display errors.
In the Examples section, I find the title "Tutorial basics" to be somewhat misleading, as the content of this page explains how to load a dataset and does not explore the modules. I would propose the following organization for the examples:
Construct Your DataClass
Run Modules
This reorganization would better reflect the content and provide clearer guidance for users.
Paper The accompanying paper is very explicit, with numerous references that allow for further exploration in the field of actimetric evaluation. Here, even if i am not an expert of this domain, I use the term "actimetric" and wonder if this term should be integrated into the title to better delineate the library's scope. Indeed, the use of "Motion Data" is quite general and does not necessarily imply the use of IMUs in a mobility assessment context.
My major comment concerns the term "performance" as cited by the authors: "...a new dimension of measuring daily function, that is performance." Performance is implicitly related to the International Classification of Functioning, Disability and Health (ICF). I believe the authors should explicitly reference the ICF in the manuscript.
I also find no information in the "state of need" section regarding the four modules integrated into the library.
Minor Comments
Kevin-Mattheus-Moerman
commented
1 month ago @aaa34169 thanks for this detailed review!
Kevin-Mattheus-Moerman
commented
1 month ago @JuliusWelzel can you please address these comments/points? :point_up:
JuliusWelzel
commented
1 month ago @aaa34169, thank you for your valuable comments. @Kevin-Mattheus-Moerman, I will discuss all points and address them with the team within the next 2 weeks.
rmndrs89
commented
2 weeks ago NGMT is implemented in Python (>=3.10) and is available under the Non-Profit Open Software License version 3.0. It can be installed from PyPI or from source on GitHub.
The documentation includes comprehensive installation instructions, a conceptual framework, and tutorial notebooks.
The code utilizes downloadable data from sources such as the Mobilised and OpenNeuro projects. However, it is important to note that these downloads may encounter SSL errors when accessed from a secure network, such as that of a hospital. We hope that you find this a fair workaround.
Hi @aaa34169, thanks for pointing out the possible SSL error. We have researched this a bit, but were not able to reproduce this error ourselves since we are not on our university hospital's network. We have read that this error may be circumvented and have addressed this in the new FAQ / Troubeshooting section in the Documentation. Worst case scenario is that users will have to manually navigate to the OpenNeuro or Zenodo repositories to fetch the datasets.
The library is easily installable with Python 3.10. The local installation using the command
pip install -e .works flawlessly.
The modules serve well-defined purposes.
The library employs data from projects such as Mobilised or OpenNeuro. However, when accessed on a secure network, an "SSLCertVerificationError" exception may be returned. It would be beneficial to mention this potential error and ideally provide information on how to resolve or circumvent it. The library is intended for users such as rehabilitation center engineers or academic researchers who may want to use it on institutional workstations. It's important to prevent any potential reluctance from these users.
Regarding the data, I have also noted that the file "exAccelDataMobilise.csv" does not allow the example modules_03_pam to run successfully.
Thanks for this remark, the file is deprecated. The example now runs with Mobilise-D dataset example.
The entirety of the library is documented and accessible .
To address common errors, I would recommend that the authors create a "Common Issues" or "Frequently Asked Questions" section.
Cool we have added a section FAQ / Troubeshooting in the Documentation
In general, the documentation is intuitive and provides both high-level and low-level information. However, I find that the organization could be improved, particularly with a focus on the concept of DataClass and its usage.
First, I suggest that the horizontal menu place DataClass before modules. Additionally, on the Home page, it is pertinent to describe the "KielMATRecording" object thoroughly, accompanied specifically by an explanation demonstrating how to construct a KielMATRecording instance from the user’s own data, rather than from the Mobilised project dataset.
Yes, we agree, since the functionality of the toolbox is founded on the KielMATRecording object, its accurate description is key to user friendliness. We have updated the documentation accordingly by putting the dataclass section before the modules. It is noteworthy to mention that the dataclass is also discussed on the landing page of the documentation.
Moreover, on the Home page, the link https://neurogeriatricskiel.github.io/KielMAT/examples/00_tutorial_basics/ leads to a page with display errors.
In the Examples section, I find the title "Tutorial basics" to be somewhat misleading, as the content of this page explains how to load a dataset and does not explore the modules. I would propose the following organization for the examples:
Construct Your DataClass
Load data into KielMAT Load datasets Events in DataClass Run Modules
Gait sequence Initial contact detection This reorganization would better reflect the content and provide clearer guidance for users.
We appreciate this valuable feedback, and we agree that the order of the examples should make sense so that users can easily learn how to work with the toolbox. We have updated the Examples in the documentation (thereby also the error with regards to examples/00_tutorial_basics/ has been resolved).
The accompanying paper is very explicit, with numerous references that allow for further exploration in the field of actimetric evaluation. Here, even if i am not an expert of this domain, I use the term "actimetric" and wonder if this term should be integrated into the title to better delineate the library's scope. Indeed, the use of "Motion Data" is quite general and does not necessarily imply the use of IMUs in a mobility assessment context.
We agree that the term "motion data" is generic, however, we envision that its functionality will not be limited to accelerometer- (or inertial sensor-)based movement analysis. We are currently working on adding functionality for marker-based motion capture, and are exploring on how to include functionality for markerless motion capture as well. In that case the term "actimetric" would not cover the functionality anymore.
My major comment concerns the term "performance" as cited by the authors: "...a new dimension of measuring daily function, that is performance." Performance is implicitly related to the International Classification of Functioning, Disability and Health (ICF). I believe the authors should explicitly reference the ICF in the manuscript.
We absolutely agree with this comment, and therefore explicitly refer to the ICF "[...] DHT provides objective insights into an individual’s functional performance, directly linking it to the International Classification of Functioning, Disability and Health (ICF) framework (Üstun et al., 2003; World Health Organization, 2001) for assessing how people perform in everyday life activities. [...]"
I also find no information in the "state of need" section regarding the four modules integrated into the library.
We have addressed this comment by explicitly mentioning the currently implemented modules in the Statement of Need section, like:
_"The KielMAT comprises several modules which are implemented and validated with dfferent dataset and each serving distinct purposes in human motion analysis:
Minor Comments
Provide a reference to the Mobilise-D consortium. Add The MathWorks, Inc. (2022) to the Matlab references. Define FAIR.
We have added a reference to the Mobilise-D consortium, and to The Mathworks, Inc. (for MATLAB). We have defined and referenced FAIR as: "[...] The conceptual framework builds on Findable, Accessible, Interoperable and Reusable (FAIR) data principles to encourage the use of open source software as well as facilitate data sharing and reproducibility in the field of human motion analysis (Wilkinson et al., 2016). [...]"
Overall, we really appreciate the comments, and hope that our adjustments have increased the quality of the toolbox, documentation and paper. Feel free to let us know what else we can address.
JuliusWelzel
commented
6 days ago Hi @aaa34169 and @Kevin-Mattheus-Moerman,
we would highly appreciate if you could provide us with a rough timeline when the second revision from your site will be completed.
Best, Julius & Team
aaa34169
commented
6 days ago Hi
I am doing it for the end of the week.
From: jwelzel @.> Sent: Tuesday, September 3, 2024 9:22 AM To: openjournals/joss-reviews @.> Cc: Fabien Leboeuf @.>; Mention @.> Subject: Re: [openjournals/joss-reviews] [REVIEW]: NGMT: NeuroGeriatric Motion Toolbox - An Open-Source Python Toolbox for Analyzing Neurological Motion Data from Various Recording Modalities (Issue #6842)
Hi @aaa34169https://github.com/aaa34169 and @Kevin-Mattheus-Moermanhttps://github.com/Kevin-Mattheus-Moerman,
we would highly appreciate if you could provide us with a rough timeline when the second revision from your site will be completed.
Best, Julius & Team
— Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/6842#issuecomment-2325781857, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAXUMBJMXGAWFF6EED23JALZUVPSRAVCNFSM6AAAAABI2IKW6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVG44DCOBVG4. You are receiving this because you were mentioned.Message ID: @.**@.>>
JuliusWelzel
commented
5 days ago Hi I am doing it for the end of the week.
Amazing, thank you for the prompt response :)
aaa34169
commented
5 days ago I greatly appreciated the commentes provided, and I fully accept the proposed modifications. I have no further comments to add at this time.
Kevin-Mattheus-Moerman
commented
4 days ago @editorialbot check references
editorialbot
commented
4 days ago Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
✅ OK DOIs
- 10.1038/s41746-023-00775-1 is OK
- 10.3390/brainsci9020034 is OK
- 10.1016/j.medengphy.2020.11.005 is OK
- 10.21105/joss.01778 is OK
- 10.1016/S1474-4422(20)30033-8 is OK
- 10.1038/sdata.2016.44 is OK
- 10.3233/JPD-181498 is OK
- 10.1038/s41467-020-17807-z is OK
- 10.1109/OJEMB.2024.3356791 is OK
- 10.1002/mds.28377 is OK
- 10.1186/s12984-023-01198-5 is OK
- 10.3389/fneur.2017.00135 is OK
- 10.3389/fneur.2018.00652 is OK
- 10.1080/0963828031000137063 is OK
- 10.1371/journal.pone.0061691 is OK
- 10.1016/S1474-4422(19)30397-7 is OK
- 10.1038/sdata.2016.18 is OK
- 10.5281/zenodo.7903963 is OK
🟡 SKIP DOIs
- No DOI given, and none found for title: International classification of functioning, disab...
- No DOI given, and none found for title: Technical validation of real-world monitoring of g...
- No DOI given, and none found for title: Estimate Gait Quality Composite
- No DOI given, and none found for title: mobile-gaitlab
- No DOI given, and none found for title: Mobilise-D consortium
- No DOI given, and none found for title: Mobilise-D Technical Validation Study Recommended ...
- No DOI given, and none found for title: MATLAB version: 9.13.0 (R2022b)
❌ MISSING DOIs
- 10.31234/osf.io/w6z79 may be a valid DOI for title: Motion-BIDS: extending the Brain Imaging Data Stru...
- 10.1371/journal.pone.0069627 may be a valid DOI for title: Prevalence and burden of gait disorders in elderly...
- 10.1186/s12984-019-0494-z may be a valid DOI for title: Locomotion and cadence detection using a single tr...
- 10.1109/embc44109.2020.9176281 may be a valid DOI for title: Real-world speed estimation using single trunk IMU...
❌ INVALID DOIs
- None
Hi @Kevin-Mattheus-Moerman,
we updated the .bib entries in https://github.com/neurogeriatricskiel/KielMAT/commit/0ebe0d61076c763a488db23d7db3fe515af865e7.
DOIs should return no error now
editorialbot
commented
4 days ago Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
✅ OK DOIs
- 10.1038/s41746-023-00775-1 is OK
- 10.3390/brainsci9020034 is OK
- 10.1016/j.medengphy.2020.11.005 is OK
- 10.21105/joss.01778 is OK
- 10.1016/S1474-4422(20)30033-8 is OK
- 10.1038/sdata.2016.44 is OK
- 10.3233/JPD-181498 is OK
- 10.1038/s41597-024-03559-8 is OK
- 10.1038/s41467-020-17807-z is OK
- 10.1109/OJEMB.2024.3356791 is OK
- 10.1002/mds.28377 is OK
- 10.1371/journal.pone.0069627 is OK
- 10.1136/bmjopen-2021-050785 is OK
- 10.1186/s12984-023-01198-5 is OK
- 10.1186/s12984-019-0494-z is OK
- 10.1109/EMBC44109.2020.9176281 is OK
- 10.3389/fneur.2017.00135 is OK
- 10.3389/fneur.2018.00652 is OK
- 10.1080/0963828031000137063 is OK
- 10.1371/journal.pone.0061691 is OK
- 10.1016/S1474-4422(19)30397-7 is OK
- 10.1038/sdata.2016.18 is OK
- 10.5281/zenodo.7903963 is OK
🟡 SKIP DOIs
- No DOI given, and none found for title: International classification of functioning, disab...
- No DOI given, and none found for title: Estimate Gait Quality Composite
- No DOI given, and none found for title: mobile-gaitlab
- No DOI given, and none found for title: Mobilise-D consortium
- No DOI given, and none found for title: Mobilise-D Technical Validation Study Recommended ...
- No DOI given, and none found for title: MATLAB version: 9.13.0 (R2022b)
❌ MISSING DOIs
- None
❌ INVALID DOIs
- None
@editorialbot check references
editorialbot
commented
4 days ago Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
✅ OK DOIs
- 10.1038/s41746-023-00775-1 is OK
- 10.3390/brainsci9020034 is OK
- 10.1016/j.medengphy.2020.11.005 is OK
- 10.21105/joss.01778 is OK
- 10.1016/S1474-4422(20)30033-8 is OK
- 10.1038/sdata.2016.44 is OK
- 10.3233/JPD-181498 is OK
- 10.1038/s41597-024-03559-8 is OK
- 10.1038/s41467-020-17807-z is OK
- 10.1109/OJEMB.2024.3356791 is OK
- 10.1002/mds.28377 is OK
- 10.1371/journal.pone.0069627 is OK
- 10.1136/bmjopen-2021-050785 is OK
- 10.1186/s12984-023-01198-5 is OK
- 10.1186/s12984-019-0494-z is OK
- 10.1109/EMBC44109.2020.9176281 is OK
- 10.3389/fneur.2017.00135 is OK
- 10.3389/fneur.2018.00652 is OK
- 10.1080/0963828031000137063 is OK
- 10.1371/journal.pone.0061691 is OK
- 10.1016/S1474-4422(19)30397-7 is OK
- 10.1038/sdata.2016.18 is OK
- 10.5281/zenodo.7903963 is OK
🟡 SKIP DOIs
- No DOI given, and none found for title: International classification of functioning, disab...
- No DOI given, and none found for title: Estimate Gait Quality Composite
- No DOI given, and none found for title: mobile-gaitlab
- No DOI given, and none found for title: Mobilise-D consortium
- No DOI given, and none found for title: Mobilise-D Technical Validation Study Recommended ...
- No DOI given, and none found for title: MATLAB version: 9.13.0 (R2022b)
❌ MISSING DOIs
- None
❌ INVALID DOIs
- None
@editorialbot generate pdf
editorialbot
commented
3 days ago :point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
Kevin-Mattheus-Moerman
commented
3 days ago @JuliusWelzel below are some minor comments on the paper:
...build on the Motion BIDS specification [@jeung:2023]. Can you check if it is part of the .bib file and if the correct handle is used in the paper? Should this be [@jeung:2024] which is used later in the paper and works? Side note, you acknowledge no funding at the moment. This is not a requirement but if you do want to you can do so in the acknowledgements section.
Kevin-Mattheus-Moerman
commented
3 days ago @openjournals/dev FYI it looks like the above reference report did not pick up an ill-formatted reference [@jeung:2023]. I suppose it checks for DOIs, but perhaps it should also check if the paper has referencing errors.
JuliusWelzel
commented
3 days ago
- [ ] This reference in the paper does not seem to work:
...build on the Motion BIDS specification [@jeung:2023]. Can you check if it is part of the .bib file and if the correct handle is used in the paper? Should this be[@jeung:2024]which is used later in the paper and works?- [ ] The KielMAT name is explained twice. You can introduce it once, and subsequently keep using the name KielMAT.
Thanks @Kevin-Mattheus-Moerman for the catch. I addressed both remarks in https://github.com/neurogeriatricskiel/KielMAT/commit/c50191cad3e2a4d2631664c97afc738d4b08d582
Kevin-Mattheus-Moerman
commented
3 days ago @editorialbot generate pdf
editorialbot
commented
3 days ago :point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
Submitting author: !--author-handle-->@JuliusWelzel<!--end-author-handle-- (Julius Welzel) Repository: https://github.com/neurogeriatricskiel/NGMT Branch with paper.md (empty if default branch): Version: v0.0.4 Editor: !--editor-->@Kevin-Mattheus-Moerman<!--end-editor-- Reviewers: @aaa34169, @davidpagnon Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@aaa34169 & @davidpagnon, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Kevin-Mattheus-Moerman know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @aaa34169
📝 Checklist for @davidpagnon