openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
707 stars 37 forks source link

[PRE REVIEW]: pyforce: Python Framework for data-driven model Order Reduction of multi-physiCs problEms #6847

Closed editorialbot closed 2 months ago

editorialbot commented 3 months ago

Submitting author: !--author-handle-->@Steriva<!--end-author-handle-- (Stefano Riva) Repository: https://github.com/ERMETE-Lab/ROSE-pyforce Branch with paper.md (empty if default branch): Version: v0.1.2 Editor: !--editor-->@Fei-Tao<!--end-editor-- Reviewers: @ShimingYIN, @damar-wicaksono, @alberto743 Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b3bc9aaecef1a8e0919310833eb76c2c"><img src="https://joss.theoj.org/papers/b3bc9aaecef1a8e0919310833eb76c2c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b3bc9aaecef1a8e0919310833eb76c2c/status.svg)](https://joss.theoj.org/papers/b3bc9aaecef1a8e0919310833eb76c2c)

Author instructions

Thanks for submitting your paper to JOSS @Steriva. Currently, there isn't a JOSS editor assigned to your paper.

@Steriva if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 3 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 3 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1063/1.168744 is OK
- 10.5281/zenodo.10447666 is OK
- 10.1016/j.cma.2015.01.018 is OK
- 10.1002/nme.4747 is OK
- 10.1016/j.anucene.2022.109538 is OK

MISSING DOIs

- No DOI given, and none found for title: Multi-Physics Model Bias Correction with Data-Driv...
- No DOI given, and none found for title: Reduced Basis Methods for Partial Differential Equ...
- No DOI given, and none found for title: A complete data-driven framework for the efficient...

INVALID DOIs

- https://doi.org/10.1016/j.nucengdes.2024.113105 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.cma.2022.115773 is INVALID because of 'https://doi.org/' prefix
editorialbot commented 3 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.12 s (616.0 files/s, 179450.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          29           1335           2238           2938
Jupyter Notebook                17              0           9305           2921
SVG                              1              0              0            708
TeX                              2             41              0            376
Markdown                         4             85              0            272
GLSL                             3             34             73            129
reStructuredText                10             86            166            104
YAML                             3             11             12             80
DOS Batch                        1              8              1             26
make                             1              4              7              9
Bourne Shell                     1              0              1              5
-------------------------------------------------------------------------------
SUM:                            72           1604          11803           7568
-------------------------------------------------------------------------------

Commit count by author:

    35  Stefano Riva
    35  Steriva
     5  Neko-tan
editorialbot commented 3 months ago

Paper file info:

📄 Wordcount for paper.md is 543

🔴 Failed to discover a Statement of need section in paper

editorialbot commented 3 months ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 3 months ago

👋 @Steriva - thanks for your submission.

Please add a statement of need section to your paper, as in our example paper.

In addition, please fix the invalid DOIs that editorialbot found. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf after making changes to the .md file or when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

danielskatz commented 3 months ago

Please also add countries to all affiliations.

Steriva commented 3 months ago

Hello there @danielskatz 👋🏻 Sorry for the missing parts. We have updated the paper!

Steriva commented 3 months ago

@editorialbot check references

editorialbot commented 3 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.nucengdes.2024.113105 is OK
- 10.1063/1.168744 is OK
- 10.48550/arXiv.2401.07300 is OK
- 10.5281/zenodo.10447666 is OK
- 10.1515/9783110671490 is OK
- 10.48550/arXiv.1905.05982 is OK
- 10.1016/j.cma.2015.01.018 is OK
- 10.1016/j.cma.2022.115773 is OK
- 10.1002/nme.4747 is OK
- 10.1016/j.anucene.2022.109538 is OK

MISSING DOIs

- None

INVALID DOIs

- None
Steriva commented 3 months ago

@editorialbot generate pdf

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Steriva commented 3 months ago

@editorialbot generate preprint

editorialbot commented 3 months ago

:page_facing_up: Preprint file created: Find it here in the Artifacts list :page_facing_up:

danielskatz commented 3 months ago

@Steriva - thanks for the updates. We realize that this ended up in the wrong track, and have now moved it. The PE track chair will take over from here.

kyleniemeyer commented 3 months ago

@Steriva unfortunately, we do not have any available editors in this area, so I have to place this on your waitlist. We will move forward with finding reviewers once an editor frees up to handle this.

Fei-Tao commented 3 months ago

Hi @kyleniemeyer and @danielskatz, I have done reduced-order modeling and am interested in editing this submission. Can you assign me as editor for this submission?

kyleniemeyer commented 3 months ago

@editorialbot assign @Fei-Tao as editor

Thanks!

editorialbot commented 3 months ago

Assigned! @Fei-Tao is now the editor

Fei-Tao commented 3 months ago

@kyleniemeyer Thanks for getting back to me quickly. I will start to look for reviewers now.

Fei-Tao commented 2 months ago

@editorialbot add @ShimingYIN as reviewer

editorialbot commented 2 months ago

@ShimingYIN added to the reviewers list!

Fei-Tao commented 2 months ago

👋🏻 Hi, @alberto743, @jpmorgan98, @gtheler, @damar-wicaksono, @gwenchee, @mbudisic, this submission might interest you. If you'd like to review this submission, please comment here! Feel free to unsubscribe from this issue if you are not interested. Thank you for your time!

alberto743 commented 2 months ago

@Fei-Tao, I am interested in this review, but I will not be available before July 10th. If the timing works for you, let me know.

Fei-Tao commented 2 months ago

Hi @alberto743, thanks for your prompt response. Your review timing after July 10th works for us. I am happy to add you to our reviewer list. Please confirm if this works for you.

damar-wicaksono commented 2 months ago

Hi @Fei-Tao 👋

In case you still need another reviewer, I'm interested and would be happy to be one.

alberto743 commented 2 months ago

Hi @alberto743, thanks for your prompt response. Your review timing after July 10th works for us. I am happy to add you to our reviewer list. Please confirm if this works for you.

Ok, fine for me.

Fei-Tao commented 2 months ago

Hi @damar-wicaksono, and @alberto743, thanks for your prompt response and willingness to review this submission. I can add both of you to this submission.

Fei-Tao commented 2 months ago

@editorialbot add @damar-wicaksono as reviewer

editorialbot commented 2 months ago

@damar-wicaksono added to the reviewers list!

Fei-Tao commented 2 months ago

@editorialbot add @alberto743 as reviewer

editorialbot commented 2 months ago

@alberto743 added to the reviewers list!

Fei-Tao commented 2 months ago

@editorialbot start review

editorialbot commented 2 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6950.

Fei-Tao commented 2 months ago

Thanks everyone! Looking forward to your reviews at https://github.com/openjournals/joss-reviews/issues/6950.