openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
713 stars 38 forks source link

[PRE REVIEW]: AixWeather: A Weather Data Generation Tool for Building Energy System Simulations. Pull, Transform, Export. #6854

Open editorialbot opened 3 months ago

editorialbot commented 3 months ago

Submitting author: !--author-handle-->@martinraetz<!--end-author-handle-- (Martin Rätz) Repository: https://github.com/RWTH-EBC/AixWeather Branch with paper.md (empty if default branch): 4-joss_paper Version: v0.1.7 Editor: !--editor-->@arfon<!--end-editor-- Reviewers: Pending Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c278075a160fa7302e125e4725a46e02"><img src="https://joss.theoj.org/papers/c278075a160fa7302e125e4725a46e02/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c278075a160fa7302e125e4725a46e02/status.svg)](https://joss.theoj.org/papers/c278075a160fa7302e125e4725a46e02)

Author instructions

Thanks for submitting your paper to JOSS @martinraetz. Currently, there isn't a JOSS editor assigned to your paper.

@martinraetz if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 3 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 3 months ago

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "}" (RBRACE) [#<BibTeX::Bibliography data=[3]>, "@", #<BibTeX::Entry >, {:title=>["EnergyPlus™, Version 00"], :author=>[""], :abstractnote=>["Originally developed in 1999, an updated version 8.8.0 with bug fixes was released on September 30th, 2017. EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption—for heating, cooling, ventilation, lighting and plug and process loads—and water use in buildings. EnergyPlus is a console-based program that reads input and writes output to text files. It ships with a number of utilities including IDF-Editor for creating input files using a simple spreadsheet-like interface, EP-Launch for managing input and output files and performing batch simulations, and EP-Compare for graphically comparing the results of two or more simulations. Several comprehensive graphical interfaces for EnergyPlus are also available. DOE does most of its work with EnergyPlus using the OpenStudio® software development kit and suite of applications. DOE releases major updates to EnergyPlus twice annually."], :url=>["https://www.osti.gov/biblio/1395882"], :doi=>[""], :year=>["2017"], :month=>["9"]}, ",", "note", "="]
editorialbot commented 3 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=4.88 s (17.6 files/s, 15947.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSV                             11              0              0          71175
Python                          38            973           1498           2986
Markdown                         8            132              2            355
JSON                            17              0              0            217
SVG                              4             12              0            162
TeX                              1              6              0             62
YAML                             2              3              9             51
reStructuredText                 3              8             10              9
TOML                             1              0              0              5
Jupyter Notebook                 1              0            116              0
-------------------------------------------------------------------------------
SUM:                            86           1134           1635          75022
-------------------------------------------------------------------------------

Commit count by author:

    99  Martin Rätz
     6  TobiasSpratte
     5  fabian.wuellhorst
     4  FWuellhorst
     4  fabian.wuellhorst@eonerc.rwth-aachen.de
     2  Jun Jiang
     1  Tobias Spratte
editorialbot commented 3 months ago

Paper file info:

📄 Wordcount for paper.md is 857

✅ The paper includes a Statement of need section

editorialbot commented 3 months ago

License info:

🟡 License found: Other (Check here for OSI approval)

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kyleniemeyer commented 3 months ago

Hi @MartinRaetz, unfortunately we do not have any editors in this area available at the moment, so I have to place this on our waitlist. We will move forward with the process once someone frees up.

In addition, I noticed that your software's license is a modified version of the revised BSD 3-clause license. JOSS submissions must use OSI-approved licenses, and not make modifications to these—please change this to the boilerplate revised BSD3 license. Terms of contributions should go in a separate document (such as CONTRIBUTING.md).

MartinRaetz commented 3 months ago

@editorialbot generate pdf

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

MartinRaetz commented 3 months ago

Thank you, @kyleniemeyer. I have revised the BSD 3-clause license to the boilerplate version. I have also fixed the failing Bibtex entry.

MartinRaetz commented 3 months ago

Possible reviewers: Jeremy Lerond Florian Kotthoff

MartinRaetz commented 2 months ago

Hi @kyleniemeyer, is there anything I can do to help finding an editor? In my opinion, anyone in simulations using weather data, persons working with weather data, or possibly even persons working with time series data in general might be suitable.

kyleniemeyer commented 2 months ago

@MartinRaetz unfortunately the issue is just availability - we have people that can edit this, they are just at capacity right now.

MartinRaetz commented 2 months ago

Understood, thank you for your fast response!

arfon commented 3 weeks ago

@editorialbot assign me as editor

editorialbot commented 3 weeks ago

Assigned! @arfon is now the editor

arfon commented 3 weeks ago

:wave: @MartinRaetz – apologies for the delay. I'll be the editor for your submission. To help us get started, could you take a look a this list of potential reviewers and identify a few people who would be good candidates to review this submission?

MartinRaetz commented 3 weeks ago

Hey @arfon, thanks for taking over!

Here are some suggestions for reviewers: Jeremy Lerond Ralph Evins Xuechen Lei

If you would like me to suggest more, just let me know!

arfon commented 1 week ago

@ralphevins @leijerry888 – :wave: would any of you be willing to review this submission for JOSS? The submission under consideration is AixWeather: A Weather Data Generation Tool for Building Energy System Simulations. Pull, Transform, Export

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. You can learn more about the process in these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

Based on your experience, we think you might be able to provide a great review of this submission. Please let me know if you think you can help us out!

Many thanks Arfon

ralphevins commented 1 day ago

Sorry for the late reply, I'm swapped right now so can't review this, sorry. You could try Matt Eames at Exeter University.

On Sat, 21 Sept 2024 at 00:36, Arfon Smith @.***> wrote:

@ralphevins https://github.com/ralphevins @leijerry888 https://github.com/leijerry888 – 👋 would any of you be willing to review this submission for JOSS? The submission under consideration is AixWeather: A Weather Data Generation Tool for Building Energy System Simulations. Pull, Transform, Export

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. You can learn more about the process in these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

Based on your experience, we think you might be able to provide a great review of this submission. Please let me know if you think you can help us out!

Many thanks Arfon

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/6854#issuecomment-2365045323, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTNDUSKJQ6AEZYONRKLYVTZXUOV7AVCNFSM6AAAAABI5BKCF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGA2DKMZSGM . You are receiving this because you were mentioned.Message ID: @.***>