search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[REVIEW]: MARTINI: Mock Array Radio Telescope Interferometry of the Neutral ISM #6860

Closed editorialbot closed 5 months ago

editorialbot commented 5 months ago

Submitting author: !--author-handle-->@kyleaoman<!--end-author-handle-- (Kyle Oman) Repository: https://github.com/kyleaoman/martini Branch with paper.md (empty if default branch): joss-paper Version: v2.0.12 Editor: !--editor-->@dfm<!--end-editor-- Reviewers: !--reviewers-list-->@dfm<!--end-reviewers-list-- Archive: 10.5281/zenodo.11198185

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f46e9c0a37c70331703069f190c21c09"><img src="https://joss.theoj.org/papers/f46e9c0a37c70331703069f190c21c09/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f46e9c0a37c70331703069f190c21c09/status.svg)](https://joss.theoj.org/papers/f46e9c0a37c70331703069f190c21c09)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@dfm, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @dfm know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

@dfm, please create your checklist typing: @editorialbot generate my checklist

editorialbot commented 5 months ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 5 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/mnras/stu2058 is OK
- 10.1093/mnras/stu1536 is OK
- 10.1086/112164 is OK
- 10.1093/mnras/181.3.375 is OK
- 10.1086/322526 is OK
- 10.22323/1.215.0129 is OK
- 10.1093/mnras/stw1876 is OK
- 10.1093/mnras/stv2674 is OK
- 10.1093/mnras/stac1213 is OK
- 10.1093/mnras/stad549 is OK
- 10.48550/arXiv.2401.11878 is OK
- 10.1093/mnras/stac2684 is OK
- 10.1093/mnras/stab2279 is OK
- 10.1093/mnras/stz2069 is OK
- 10.3847/2041-8213/ab40c7 is OK
- 10.1093/mnras/staa1256 is OK
- 10.1093/mnras/staa1072 is OK
- 10.1093/mnras/sty2687 is OK
- 10.48550/arXiv.2311.10657 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 5 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.08 s (1118.2 files/s, 185058.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          43           1323           3116           5872
Markdown                         6            162              0            694
Jupyter Notebook                 3              0           1944            452
reStructuredText                29            389            587            338
TeX                              1             24              3            309
SVG                              2              2              2            223
YAML                             4             14              9            129
TOML                             1              3              0             46
JSON                             1              0              0             24
HTML                             2              1              0             17
CSS                              1              3              0             13
make                             1              4              7              9
INI                              1              0              0              3
-------------------------------------------------------------------------------
SUM:                            95           1925           5668           8129
-------------------------------------------------------------------------------

Commit count by author:

   471  Kyle Oman
   206  K.A. Oman
     2  kyleaoman
editorialbot commented 5 months ago

Paper file info:

📄 Wordcount for paper.md is 1114

✅ The paper includes a Statement of need section

editorialbot commented 5 months ago

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

dfm commented 5 months ago

Cross-linking with pyOpenSci submission here: https://github.com/pyOpenSci/software-submission/issues/164

editorialbot commented 5 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

dfm commented 5 months ago

@editorialbot set v2.0.12 as version

editorialbot commented 5 months ago

Done! version is now v2.0.12

dfm commented 5 months ago

@editorialbot set 10.5281/zenodo.11198185 as archive

editorialbot commented 5 months ago

Done! archive is now 10.5281/zenodo.11198185

dfm commented 5 months ago

@editorialbot recommend-accept

editorialbot commented 5 months ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 5 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/mnras/stu2058 is OK
- 10.1093/mnras/stu1536 is OK
- 10.1086/112164 is OK
- 10.1093/mnras/181.3.375 is OK
- 10.1086/322526 is OK
- 10.22323/1.215.0129 is OK
- 10.1093/mnras/stw1876 is OK
- 10.1093/mnras/stv2674 is OK
- 10.1093/mnras/stac1213 is OK
- 10.1093/mnras/stad549 is OK
- 10.48550/arXiv.2401.11878 is OK
- 10.1093/mnras/stac2684 is OK
- 10.1093/mnras/stab2279 is OK
- 10.1093/mnras/stz2069 is OK
- 10.3847/2041-8213/ab40c7 is OK
- 10.1093/mnras/staa1256 is OK
- 10.1093/mnras/staa1072 is OK
- 10.1093/mnras/sty2687 is OK
- 10.48550/arXiv.2311.10657 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 5 months ago

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5468, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

dfm commented 5 months ago

@editorialbot accept

editorialbot commented 5 months ago 
Doing it live! Attempting automated processing of paper acceptance...
kyleaoman commented 5 months ago

@dfm that was fast 😂

editorialbot commented 5 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Oman given-names: Kyle A. orcid: "https://orcid.org/0000-0001-9857-7788" contact: - family-names: Oman given-names: Kyle A. orcid: "https://orcid.org/0000-0001-9857-7788" doi: 10.5281/zenodo.11198185 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Oman given-names: Kyle A. orcid: "https://orcid.org/0000-0001-9857-7788" date-published: 2024-06-08 doi: 10.21105/joss.06860 issn: 2475-9066 issue: 98 journal: Journal of Open Source Software publisher: name: Open Journals start: 6860 title: "MARTINI: Mock Array Radio Telescope Interferometry of the Neutral ISM" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06860" volume: 9 title: "MARTINI: Mock Array Radio Telescope Interferometry of the Neutral ISM" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 5 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 5 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5469
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06860
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

dfm commented 5 months ago

@kyleaoman – your paper is now accepted and published in JOSS :zap::rocket::boom:

We call the pyOpenSci review process "streamlined" for a reason! 😄

editorialbot commented 5 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06860/status.svg)](https://doi.org/10.21105/joss.06860)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06860">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06860/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06860/status.svg
   :target: https://doi.org/10.21105/joss.06860

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

kyleaoman commented 5 months ago

@editorialbot generate preprint

editorialbot commented 5 months ago

:page_facing_up: Preprint file created: Find it here in the Artifacts list :page_facing_up: