Closed editorialbot closed 1 week ago
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.
For a list of things I can do to help you, just type:
@editorialbot commands
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
@editorialbot generate pdf
Software report:
github.com/AlDanial/cloc v 1.90 T=0.03 s (1034.0 files/s, 321988.8 lines/s)
-------------------------------------------------------------------------------
Language files blank comment code
-------------------------------------------------------------------------------
Python 14 390 397 1005
Jupyter Notebook 6 0 7850 555
Markdown 4 64 0 194
Cython 5 33 0 137
YAML 3 28 0 103
TeX 1 15 0 73
DOS Batch 1 8 1 26
make 1 4 7 9
-------------------------------------------------------------------------------
SUM: 35 542 8255 2102
-------------------------------------------------------------------------------
Commit count by author:
102 aadya940
50 Aadya Chinubhai
Paper file info:
π Wordcount for paper.md
is 1301
β
The paper includes a Statement of need
section
License info:
β
License found: BSD 2-Clause "Simplified" License
(Valid open source OSI approved license)
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- None
MISSING DOIs
- No DOI given, and none found for title: Markov chain neural networks
- No DOI given, and none found for title: PyDTMC
- 10.1109/mcse.2010.118 may be a valid DOI for title: Cython: The best of both worlds
- No DOI given, and none found for title: Array programming with NumPy
- No DOI given, and none found for title: SciPy 1.0: fundamental algorithms for scientific c...
- No DOI given, and none found for title: Pytorch: An imperative style, high-performance dee...
- No DOI given, and none found for title: Numba: A llvm-based python jit compiler
- No DOI given, and none found for title: Convergence rates for Markov chains
- No DOI given, and none found for title: Regime switching models
INVALID DOIs
- None
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
Hi @aadya940 and reviewers @braniii @MichalisPanayides π ! - this is the review thread for the submission. All of our communications will happen here from now on.
Meanwhile, please check the post at the top of the issue for instructions on how to generate your own review checklist. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines.
The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues directly in the software repository. If you do so, please mention this thread so that a link is created (and I can keep an eye on what is happening). Please also feel free to comment and ask questions in this thread. It is often easier to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.
Please feel free to ping me (@mooniean) if you have any questions or concerns. Thanks!
The changes have been made :+1:
Thanks @MichalisPanayides for the review :))
Hi everyone! @braniii @MichalisPanayides and @aadya940
How is everything going? Just checking in to see if you need anything from me!
@mooniean Everything good from my side. Thanks for asking :))
@mooniean Thank you for asking. There are still some open issues regarding the documentation and the package management/installation process.
@aadya940 hello! just checking you've seen the open issues that @braniii mentioned?
Hello @mooniean , Yes , Thanks :))
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
Hello! @mooniean @braniii @MichalisPanayides Looks like I'm done with all the issues raised in chainopy. Thanks :))
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@mooniean There are still two open issues (make it installable via pip/pypi and add examples to the docs). Once these are fixed, I will check off the remaining boxes in my review.
Edit: @aadya940 fixed all issues.
Hello everyone! I've checked that both reviewers have checked all the boxes. @braniii @MichalisPanayides are you happy to recommend the paper for publication in JOSS?
Hello everyone! I've checked that both reviewers have checked all the boxes. @braniii @MichalisPanayides are you happy to recommend the paper for publication in JOSS?
Yes. I am happy with the changes
Thank You, really appreciate your feedbacks and the issues raised. :)) @MichalisPanayides @braniii
Hi @aadya940 ! Before we do the post-review checklist, there's only a couple of small corrections for the paper (for consistency purposes in the most part):
There are some capitalisation inconsistencies: Line 29: writing pyDTMC while previous was PyDTMC (and afterwards too) Line 36: same with cython and python (Python has to be capitalised) Line 39: markov chains > Markov chains
And a small typo on line 115: should be packages ("we use the Pytest and PyDTMC packages)
Hello @mooniean , Thanks for the review. I've fixed the issues & can start with the post-review now. Please let me know what are the next steps :))
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@editorialbot set <DOI here> as archive
@editorialbot set <version here> as version
@editorialbot generate pdf
@editorialbot check references
and ask author(s) to update as needed@editorialbot recommend-accept
@editorialbot check references
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- None
MISSING DOIs
- No DOI given, and none found for title: Markov chain neural networks
- No DOI given, and none found for title: PyDTMC
- No DOI given, and none found for title: simple-markov
- No DOI given, and none found for title: mchmm
- 10.1109/mcse.2010.118 may be a valid DOI for title: Cython: The best of both worlds
- No DOI given, and none found for title: Array programming with NumPy
- No DOI given, and none found for title: SciPy 1.0: fundamental algorithms for scientific c...
- No DOI given, and none found for title: Pytorch: An imperative style, high-performance dee...
- No DOI given, and none found for title: Numba: A llvm-based python jit compiler
- No DOI given, and none found for title: Convergence rates for Markov chains
- No DOI given, and none found for title: Regime switching models
INVALID DOIs
- None
@mooniean I already have a release made (v1.0.2):
@aadya940 can you check the DOIs missing on the comment above, please?
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@editorialbot check references
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1109/MCSE.2010.118 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1145/2833157.2833162 is OK
- 10.1137/1037083 is OK
- 10.1057/9780230280830_23 is OK
MISSING DOIs
- No DOI given, and none found for title: Markov chain neural networks
- No DOI given, and none found for title: PyDTMC
- No DOI given, and none found for title: simple-markov
- No DOI given, and none found for title: mchmm
- No DOI given, and none found for title: Pytorch: An imperative style, high-performance dee...
INVALID DOIs
- None
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@editorialbot check references
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1109/CVPRW.2018.00293 is OK
- 10.1109/MCSE.2010.118 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1145/2833157.2833162 is OK
- 10.1137/1037083 is OK
- 10.1057/9780230280830_23 is OK
MISSING DOIs
- No DOI given, and none found for title: PyDTMC
- No DOI given, and none found for title: simple-markov
- No DOI given, and none found for title: mchmm
INVALID DOIs
- 10.5555/3454287.3455008 is INVALID
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@editorialbot check references
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1109/CVPRW.2018.00293 is OK
- 10.1109/MCSE.2010.118 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1145/3620665.3640366 is OK
- 10.1145/2833157.2833162 is OK
- 10.1137/1037083 is OK
- 10.1057/9780230280830_23 is OK
MISSING DOIs
- No DOI given, and none found for title: PyDTMC
- No DOI given, and none found for title: simple-markov
- No DOI given, and none found for title: mchmm
INVALID DOIs
- None
@mooniean I wasn't able to find the other DOIs, these likely don't exist. They're mostly just github repos and not proper publications.
The zenodo DOI for v1.0.3 (latest) is:
10.5281/zenodo.13305155
Submitting author: !--author-handle-->@aadya940<!--end-author-handle-- (Aadya Chinubhai) Repository: https://github.com/aadya940/chainopy Branch with paper.md (empty if default branch): master Version: v1.0.3 Editor: !--editor-->@mooniean<!--end-editor-- Reviewers: @braniii, @MichalisPanayides Archive: 10.5281/zenodo.13305155
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@braniii & @MichalisPanayides, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mooniean know.
β¨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest β¨
Checklists
π Checklist for @MichalisPanayides
π Checklist for @braniii