search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
694 stars 36 forks source link

[REVIEW]: Choice-Learn: Large-scale choice modeling for operational contexts through the lens of machine learning #6899

Open editorialbot opened 1 week ago

editorialbot commented 1 week ago

Submitting author: !--author-handle-->@VincentAuriau<!--end-author-handle-- (Vincent Auriau) Repository: https://github.com/artefactory/choice-learn Branch with paper.md (empty if default branch): joss Version: v0.0.4 Editor: !--editor-->@crvernon<!--end-editor-- Reviewers: @tmigot, @samuelduchesne Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/1b68a5f8d791de0ac87f518bc08b688b"><img src="https://joss.theoj.org/papers/1b68a5f8d791de0ac87f518bc08b688b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/1b68a5f8d791de0ac87f518bc08b688b/status.svg)](https://joss.theoj.org/papers/1b68a5f8d791de0ac87f518bc08b688b)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@tmigot & @samuelduchesne, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @crvernon know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

@tmigot, please create your checklist typing: @editorialbot generate my checklist

@samuelduchesne, please create your checklist typing: @editorialbot generate my checklist

editorialbot commented 1 week ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 week ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.jocm.2018.01.002 is OK
- 10.48550/arXiv.2304.01906 is OK
- 10.48550/arXiv.2207.12877 is OK
- 10.1016/j.trb.2022.07.001 is OK
- 10.48550/arXiv.2401.11954 is OK
- 10.2307/2555538 is OK
- 10.5281/zenodo.4724125 is OK
- 10.1007/0-306-48332-7_250 is OK
- 10.48550/arXiv.1412.6980 is OK
- 10.1287/msom.2023.1195 is OK
- 10.1016/j.dam.2012.03.003 is OK
- 10.5281/zenodo.3509134 is OK
- 10.1002/1099-1255(200009/10)15:5<447::aid-jae570>3.3.co;2-t is OK

MISSING DOIs

- No DOI given, and none found for title: A short introduction to Biogeme
- No DOI given, and none found for title: Array programming with NumPy
- No DOI given, and none found for title: Lecture 6.5 RMSProp, coursera: Neural networks for...
- No DOI given, and none found for title: Personalize Expedia Hotel Searches
- No DOI given, and none found for title: The acceptance of modal innovation: The case of Sw...
- No DOI given, and none found for title: Scikit-learn: Machine Learning in Python
- No DOI given, and none found for title: Convert data from wide to long format
- 10.1163/2214-8647_dnp_e612900 may be a valid DOI for title: Keras
- No DOI given, and none found for title: Gurobi Optimizer Reference Manual
- No DOI given, and none found for title: OR-Tools

INVALID DOIs

- None
editorialbot commented 1 week ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.10 s (915.1 files/s, 233953.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          34           1556           3747           6970
Jupyter Notebook                15              0           8848           1664
Markdown                        32            238              0            612
YAML                            10             43              3            445
TeX                              1             21              0            214
TOML                             1             12              0             97
Bourne Shell                     2              3              0             35
make                             1              6              5             23
-------------------------------------------------------------------------------
SUM:                            96           1879          12603          10060
-------------------------------------------------------------------------------

Commit count by author:

   412  VincentAuriau
    59  VincentAURIAU
    35  Vincent Auriau
    15  Emmanuel MALHERBE
     1  Luca Serra
     1  Scaffolder
     1  ma-aouad
editorialbot commented 1 week ago

Paper file info:

📄 Wordcount for paper.md is 1663

✅ The paper includes a Statement of need section

editorialbot commented 1 week ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 1 week ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

crvernon commented 1 week ago

👋 @VincentAuriau, @tmigot, and @samuelduchesne - This is the review thread for the paper. All of our communications will happen here from now on.

Please read the "Reviewer instructions & questions" in the first comment above.

Both reviewers have checklists at the top of this thread (in that first comment) with the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention https://github.com/openjournals/joss-reviews/issues/6899 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.

We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule.

crvernon commented 1 week ago

👋 @VincentAuriau - one thing you can do right away: please reduce the length of your paper to about 1000 words. Thanks!

VincentAuriau commented 1 week ago

Hello, Thank you for reviewing ! A few experiments are detailed in the paper and can be reproduced with the notebooks here.

VincentAuriau commented 5 days ago

@editorialbot generate pdf

editorialbot commented 5 days ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

VincentAuriau commented 5 days ago

@editorialbot commands

editorialbot commented 5 days ago

Hello @VincentAuriau, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers
VincentAuriau commented 5 days ago

@editorialbot check repository

editorialbot commented 5 days ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.11 s (903.7 files/s, 232719.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          34           1556           3747           6970
Jupyter Notebook                15              0           8914           1782
Markdown                        32            236              0            610
YAML                            10             43              3            445
TeX                              1             21              0            214
TOML                             1             12              0             97
Bourne Shell                     2              3              0             35
make                             1              6              5             23
-------------------------------------------------------------------------------
SUM:                            96           1877          12669          10176
-------------------------------------------------------------------------------

Commit count by author:

   412  VincentAuriau
    59  VincentAURIAU
    36  Vincent Auriau
    15  Emmanuel MALHERBE
     1  Luca Serra
     1  Scaffolder
     1  ma-aouad
editorialbot commented 5 days ago

Paper file info:

📄 Wordcount for paper.md is 1544

✅ The paper includes a Statement of need section

editorialbot commented 5 days ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

crvernon commented 1 day ago

:wave: @tmigot and @samuelduchesne - just checking in to see how things are going. Let me know if you need help creating your review checklist. Thanks!

samuelduchesne commented 1 day ago

:wave: @tmigot and @samuelduchesne - just checking in to see how things are going. Let me know if you need help creating your review checklist. Thanks!

I'll be starting my review next Monday.