openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
712 stars 38 forks source link

[PRE REVIEW]: small_gicp: Efficient and parallel algorithms for point cloud registration #6900

Closed editorialbot closed 2 months ago

editorialbot commented 3 months ago

Submitting author: !--author-handle-->@koide3<!--end-author-handle-- (Kenji Koide) Repository: https://github.com/koide3/small_gicp Branch with paper.md (empty if default branch): paper Version: v0.1.0 Editor: !--editor-->@diehlpk<!--end-editor-- Reviewers: @versatran01, @abougouffa Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/059b017c823ed9fd211fc91373cdc2cc"><img src="https://joss.theoj.org/papers/059b017c823ed9fd211fc91373cdc2cc/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/059b017c823ed9fd211fc91373cdc2cc/status.svg)](https://joss.theoj.org/papers/059b017c823ed9fd211fc91373cdc2cc)

Author instructions

Thanks for submitting your paper to JOSS @koide3. Currently, there isn't a JOSS editor assigned to your paper.

@koide3 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 3 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 3 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1109/icra.2011.5980567 may be a valid DOI for title: 3D is here: Point Cloud Library (PCL)
- No DOI given, and none found for title: Open3D: A Modern Library for 3D Data Processing
- 10.1109/lra.2022.3152830 may be a valid DOI for title: Faster-LIO: Lightweight Tightly Coupled Lidar-Iner...
- 10.1109/icra48506.2021.9560835 may be a valid DOI for title: Voxelized GICP for Fast and Accurate 3D Point Clou...
- 10.1007/bf01427149 may be a valid DOI for title: Iterative point matching for registration of free-...
- 10.15607/rss.2009.v.021 may be a valid DOI for title: Generalized-icp.

INVALID DOIs

- None
editorialbot commented 3 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.05 s (2413.3 files/s, 229951.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C++                             40            798            276           3548
C/C++ Header                    45            781            734           2872
Markdown                         8            235              0            668
Python                           9            248             79            643
YAML                            10             64             13            449
CMake                            3             46             43            288
Bourne Shell                     4             14              0             55
TeX                              1              5              0             50
Dockerfile                       2             22              0             42
TOML                             1              9              0             40
make                             1              5              0             23
XML                              1              4              3             15
reStructuredText                 2              8             12              9
-------------------------------------------------------------------------------
SUM:                           127           2239           1160           8702
-------------------------------------------------------------------------------

Commit count by author:

    65  k.koide
    46  koide3
     4  Martin Valgur
     2  Atticus Zhou
     2  Daisuke Nishimatsu
     2  Nikhil Khedekar
editorialbot commented 3 months ago

Paper file info:

📄 Wordcount for paper.md is 663

✅ The paper includes a Statement of need section

editorialbot commented 3 months ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 3 months ago

👋 @koide3 - thanks for your submission.

Please

  1. Work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. After you make changes to your .bib file, then use the command @editorialbot check references to check them again
  2. Fix the formatting of your references - follow the example paper. Use the command @editorialbot generate pdf after making changes (or when the references are right) to make a new PDF

@editorialbot commands need to be the first entry in a new comment.

In the meantime, I'll look for an editor for your submission.

danielskatz commented 3 months ago

👋 @galessiorob - would you be able to edit this submission?

danielskatz commented 3 months ago

@editorialbot invite @galessiorob as editor

editorialbot commented 3 months ago

Invitation to edit this submission sent!

koide3 commented 3 months ago

@editorialbot generate pdf

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

koide3 commented 3 months ago

👋 @danielskatz Thank you for handling our submission. I just updated and re-generated the paper accordingly. I look forward to receiving reviews.

danielskatz commented 3 months ago

@editorialbot check references

editorialbot commented 3 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/ICRA.2011.5980567 is OK
- 10.48550/arXiv.1801.09847 is OK
- 10.1109/LRA.2022.3152830 is OK
- 10.1109/ICRA48506.2021.9560835 is OK
- 10.1007/BF01427149 is OK
- 10.15607/rss.2009.v.021 is OK

MISSING DOIs

- None

INVALID DOIs

- None
danielskatz commented 3 months ago

@koide3 - thanks for the updates. Once there is an editor, they will be in touch with you about next steps

danielskatz commented 3 months ago

👋 @diehlpk - Do you think you would be able to edit this submission?

danielskatz commented 3 months ago

@editorialbot invite @diehlpk as editor

editorialbot commented 3 months ago

Invitation to edit this submission sent!

diehlpk commented 3 months ago

@editorialbot add @diehlpk as editor

editorialbot commented 3 months ago

Assigned! @diehlpk is now the editor

koide3 commented 3 months ago

@danielskatz Thank you so much for serving as an editor of our submission. As reviewer candidates, I found the following people from the reviewer list: SteveMacenski, abougouffa, versatran01, jingnanshi, CameronDevine, ekorudiawan

danielskatz commented 3 months ago

@diehlpk is the editor. I am the track editor, and you won't hear from me again until the end of the process or if there are problems along the way

koide3 commented 3 months ago

Sorry, I mistyped. Thank you @diehlpk for serving as an editor.

diehlpk commented 3 months ago

Hi @koide3 could you please recommend some potential reviewers. Please post their GitHub handle without the @ so they are not getting a notification yet.

koide3 commented 3 months ago

@diehlpk As reviewer candidates, I found the following people from the reviewer list: SteveMacenski, abougouffa, versatran01, jingnanshi, CameronDevine, ekorudiawan

diehlpk commented 3 months ago

Hi @SteveMacenski do you have time to review this paper?

diehlpk commented 3 months ago

Hi @abougouffa do you have time to review this paper?

diehlpk commented 3 months ago

Hi @versatran01 do you have time to review this paper?

SteveMacenski commented 3 months ago

I can do it

abougouffa commented 2 months ago

Hi @abougouffa do you have time to review this paper?

Hello @diehlpk, yes I can! Thanks for the mention.

versatran01 commented 2 months ago

@diehlpk Yes I can review this paper.

diehlpk commented 2 months ago

@editorialbot add @versatran01 as reviewer

editorialbot commented 2 months ago

@versatran01 added to the reviewers list!

diehlpk commented 2 months ago

@editorialbot add @abougouffa as reviewer

editorialbot commented 2 months ago

@abougouffa added to the reviewers list!

diehlpk commented 2 months ago

Hi @versatran01 and @abougouffa thanks for agreeing to review.

diehlpk commented 2 months ago

@editorialbot start review

editorialbot commented 2 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6948.