search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
712 stars 38 forks source link

[PRE REVIEW]: snSMART: An R Package for Small Sample, Sequential, Multiple Assignment, Randomized Trial Data Analysis #6907

Closed editorialbot closed 2 months ago

editorialbot commented 3 months ago

Submitting author: !--author-handle-->@sidiwang<!--end-author-handle-- (Sidi Wang) Repository: https://github.com/sidiwang/snSMART Branch with paper.md (empty if default branch): JOSS Version: v0.2.3 Editor: !--editor-->@osorensen<!--end-editor-- Reviewers: @aghaynes, @ezraporter Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/119f9b14b157f475c25f737aca4a166e"><img src="https://joss.theoj.org/papers/119f9b14b157f475c25f737aca4a166e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/119f9b14b157f475c25f737aca4a166e/status.svg)](https://joss.theoj.org/papers/119f9b14b157f475c25f737aca4a166e)

Author instructions

Thanks for submitting your paper to JOSS @sidiwang. Currently, there isn't a JOSS editor assigned to your paper.

@sidiwang if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 3 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 3 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.02 s (892.9 files/s, 226501.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                                9            268            907           1725
Markdown                         2             81              0            425
TeX                              1             33              1            195
YAML                             2              6              6             41
Rmd                              1             18             62             37
-------------------------------------------------------------------------------
SUM:                            15            406            976           2423
-------------------------------------------------------------------------------

Commit count by author:

   105  Sidi Wang
    27  sidiwang
    13  Michael Kleinsasser
     1  Michael (Mike) Kleinsasser
editorialbot commented 3 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1016/j.cct.2020.105989 may be a valid DOI for title: Dynamic Treatment Regimens in Small N, Sequential,...
- No DOI given, and none found for title: A Bayesian Group Sequential Small N Sequential Mul...
- No DOI given, and none found for title: A Bayesian Analysis of Small N Sequential Multiple...
- No DOI given, and none found for title: Sample Size Determination for Bayesian Analysis of...
- 10.1002/sim.8813 may be a valid DOI for title: Bayesian Methods to Compare Dose Levels with Place...
- 10.1002/sim.8776 may be a valid DOI for title: Design and Analysis Considerations for Utilizing a...
- 10.1016/s0140-6736(02)07283-5 may be a valid DOI for title: An Overview of Clinical Research: the Lay of the L...
- 10.1186/s13063-020-04285-3 may be a valid DOI for title: Protocol for a Randomized Multicenter Study for Is...
- 10.2307/2348770 may be a valid DOI for title: A Bayesian Approach to Calculating Sample Sizes
- 10.1111/1467-985x.00154 may be a valid DOI for title: A Design for Testing Clinical Strategies: Biased A...
- No DOI given, and none found for title: An Experimental Design for the Development of Adap...
- 10.1093/biostatistics/kxr016 may be a valid DOI for title: Efficient Design and Inference for Multistage Rand...
- 10.32614/cran.package.geepack may be a valid DOI for title: geepack: Generalized Estimating Equation Package
- No DOI given, and none found for title: The R Package geepack for Generalized Estimating E...
- 10.1002/sim.1650 may be a valid DOI for title: Estimating Equations for Association Structures
- No DOI given, and none found for title: geepack: Yet Another Package for Generalized Estim...
- No DOI given, and none found for title: Longitudinal Data Analysis for Discrete and Contin...
- No DOI given, and none found for title: JAGS: A Program for Analysis of Bayesian Graphical...
- 10.32614/cran.package.envstats may be a valid DOI for title: EnvStats: Package for Environmental Statistics, In...
- 10.32614/cran.package.rjags may be a valid DOI for title: rjags: Bayesian Graphical Models using MCMC

INVALID DOIs

- None
editorialbot commented 3 months ago

Paper file info:

📄 Wordcount for paper.md is 1832

✅ The paper includes a Statement of need section

editorialbot commented 3 months ago

License info:

🔴 Failed to discover a valid open source license

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

crvernon commented 3 months ago

:wave: @sidiwang - thanks for your submission to JOSS. All of our the editors who would be able to edit this submission are currently occupied. I am going to waitlist this submission until one becomes available.

In the meantime, I notice you specify a license in your package but there is no LICENSE file in the root of the repository. Please add the appropriate open source license to your repository. Also, at first glance, I don't see any tests accompanying your package. This will come up if your submission makes it into full review so please try to take care of that ahead of time. There are also many DOI in your references not accounted for (see report above). Lastly, please reduce the length of the paper down to around 1000 words maximum.

Thanks!

arfon commented 3 months ago

@editorialbot generate pdf

☝ to generate the most similar paper recommendation list which has been broken for some time.

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 3 months ago

Five most similar historical JOSS papers:

POSSA: Power simulation for sequential analyses and multiple hypotheses Submitting author: @gasparl Handling editor: @fboehm (Active) Reviewers: @mingzehuang, @mmrabe Similarity score: 0.8264

greta: simple and scalable statistical modelling in R Submitting author: @goldingn Handling editor: @terrytangyuan (Retired) Reviewers: @lionel68, @joethorley, @lionel68 Similarity score: 0.8242

simstudy: Illuminating research methods through data generation Submitting author: @assignUser Handling editor: @mikldk (Retired) Reviewers: @gagolews, @brunaw Similarity score: 0.8229

presize: An R-package for precision-based sample size calculation in clinical research Submitting author: @aghaynes Handling editor: @majensen (Active) Reviewers: @amoeba, @TomKellyGenetics Similarity score: 0.8220

rsimsum: Summarise results from Monte Carlo simulation studies Submitting author: @ellessenne Handling editor: @leeper (Retired) Reviewers: @lebebr01 Similarity score: 0.8184

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

sidiwang commented 2 months ago

👋 @sidiwang - thanks for your submission to JOSS. All of our the editors who would be able to edit this submission are currently occupied. I am going to waitlist this submission until one becomes available.

In the meantime, I notice you specify a license in your package but there is no LICENSE file in the root of the repository. Please add the appropriate open source license to your repository. Also, at first glance, I don't see any tests accompanying your package. This will come up if your submission makes it into full review so please try to take care of that ahead of time. There are also many DOI in your references not accounted for (see report above). Lastly, please reduce the length of the paper down to around 1000 words maximum.

Thanks!

Thank you for your feedback! I have made the changes, and hopefully, the package and the paper look better now. If any more edits are recommended, please let me know!

osorensen commented 2 months ago

👋 @gasparl, @aghaynes, @rsh52, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

rsh52 commented 2 months ago

Thanks @osorensen!

My colleague and fellow co-author on our JOSS paper, @ezraporter, might be a better choice for this given his stats background.

aghaynes commented 2 months ago

Hi @osorensen, I can do a review, although it might have to be next week...

osorensen commented 2 months ago

Thanks @aghaynes; it's absolutely alright if it takes a few weeks until you start the review.

osorensen commented 2 months ago

@editorialbot add @aghaynes as reviewer

editorialbot commented 2 months ago

Can't add reviewers: There is no editor assigned yet

osorensen commented 2 months ago

@editorialbot add @osorensen as editor

editorialbot commented 2 months ago

Assigned! @osorensen is now the editor

osorensen commented 2 months ago

@editorialbot add @aghaynes as review

editorialbot commented 2 months ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

osorensen commented 2 months ago

@editorialbot add @aghaynes as reviewer

editorialbot commented 2 months ago

@aghaynes added to the reviewers list!

osorensen commented 2 months ago

@ezraporter would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

ezraporter commented 2 months ago

@osorensen yes, I'd be happy to!

osorensen commented 2 months ago

@editorialbot add @ezraporter as reviewer

editorialbot commented 2 months ago

@ezraporter added to the reviewers list!

osorensen commented 2 months ago

@editorialbot start review

editorialbot commented 2 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6971.