[PRE REVIEW]: Dolphin: A Python package for large-scale InSAR PS/DS processing

[editorialbot]

Submitting author: !--author-handle-->@scottstanie<!--end-author-handle-- (Scott Staniewicz) Repository: https://github.com/isce-framework/dolphin Branch with paper.md (empty if default branch): joss Version: v0.19.0 Editor: !--editor-->@mikemahoney218<!--end-editor-- Reviewers: @McWhity, @margauxmouchene Managing EiC: Kristen Thyng

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/22654c1f71df2ecf3ada009499ed8961"><img src="https://joss.theoj.org/papers/22654c1f71df2ecf3ada009499ed8961/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/22654c1f71df2ecf3ada009499ed8961/status.svg)](https://joss.theoj.org/papers/22654c1f71df2ecf3ada009499ed8961)

Author instructions

Thanks for submitting your paper to JOSS @scottstanie. Currently, there isn't a JOSS editor assigned to your paper.

@scottstanie if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=0.17 s (912.3 files/s, 174428.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                         115           3953           5333          14623
CSV                              1              0              0           1201
Markdown                        11            291              0            672
TeX                              2             38              0            498
YAML                            11             39             35            433
Bourne Shell                     3             26             26            148
Jupyter Notebook                 2              0           1332            132
Ruby                             1             28             12            106
TOML                             1             19             15             93
JSON                             3              0              0             90
Dockerfile                       1             19             18             47
JavaScript                       1              3              0             15
make                             1              2              0              5
-------------------------------------------------------------------------------
SUM:                           153           4418           6771          18063
-------------------------------------------------------------------------------

Commit count by author:

   510  Scott Staniewicz
    44  pre-commit-ci[bot]
    11  Sara Mirzaee
     4  Simran S Sangha
     3  Geoffrey Gunter
     3  scott
     2  Ryan Burns
     2  dependabot[bot]
     1  Geoffrey M Gunter
     1  seyeonjeon

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/TGRS.2017.2711037 is OK
- 10.1109/TGRS.2018.2826045 is OK
- 10.1109/TGRS.2020.3003421 is OK
- 10.1364/JOSAA.18.000338 is OK
- 10.1109/TGRS.2011.2164805 is OK
- 10.1002/2015GL065031 is OK
- 10.1109/TGRS.2011.2124465 is OK
- 10.1109/TGRS.2014.2352853 is OK
- 10.1109/TGRS.2008.2001756 is OK
- 10.3390/rs14020390 is OK
- 10.1016/j.cageo.2022.105291 is OK
- 10.1109/IGARSS.2018.8517504 is OK
- 10.1109/LGRS.2010.2083631 is OK
- 10.6028/jres.066D.020 is OK
- 10.1109/TGRS.2022.3210868 is OK
- 10.1016/j.cageo.2019.104331 is OK
- 10.1109/LGRS.2022.3197423 is OK

MISSING DOIs

- No DOI given, and none found for title: Introducing the OPERA Project for Systematic Surfa...
- No DOI given, and none found for title: JAX: Composable Transformations of Python+NumPy Pr...
- No DOI given, and none found for title: FRInGE; Full-Resolution InSAR Timeseries Using Gen...

INVALID DOIs

- None

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 1119

✅ The paper includes a Statement of need section

[editorialbot]

License info:

🟡 License found: Other (Check here for OSI approval)

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[editorialbot]

Five most similar historical JOSS papers:

SenSARP: A pipeline to pre-process Sentinel-1 SLC data by using ESA SNAP Sentinel-1 Toolbox Submitting author: @McWhity Handling editor: @pdebuyl (Active) Reviewers: @arthur-e, @danclewley Similarity score: 0.6735

PyBWE: Python tools for Bandwidth Extrapolation of planetary radar signals Submitting author: @NicOudart Handling editor: @mbobra (Active) Reviewers: @letiziagambacorta1, @kathlandgren Similarity score: 0.6735

Seaduck: A python package for Eulerian and Lagrangian interpolation on ocean datasets Submitting author: @MaceKuailv Handling editor: @kthyng (Active) Reviewers: @pnsaevik, @syedhamidali Similarity score: 0.6701

X-PSI: A Python package for neutron star X-ray pulse simulation and inference Submitting author: @drannawatts Handling editor: @adonath (Active) Reviewers: @JohannesBuchner, @matteobachetti Similarity score: 0.6689

pyprop8: A lightweight code to simulate seismic observables in a layered half-space Submitting author: @valentineap Handling editor: @leouieda (Retired) Reviewers: @hemmelig, @hfmark Similarity score: 0.6676

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

[kthyng]

Hi @scottstanie and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:

• [x] OSI-approved license
• [x] Installation instructions
• [x] Documentation
• [x] Tests of some sort
• [x] Check paper
• [x] Substantial scholarly effort
• [x] Clear research application/in scope

In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them.

[scottstanie]

Hi, here are the handles of 5 reviewers from the database:

• jiangyuinsar
• margauxmouchene
• valentineap
• McWhity
• braunfuss

[scottstanie]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/TGRS.2017.2711037 is OK
- 10.1109/TGRS.2018.2826045 is OK
- 10.1109/TGRS.2020.3003421 is OK
- 10.1364/JOSAA.18.000338 is OK
- 10.1109/TGRS.2011.2164805 is OK
- 10.1002/2015GL065031 is OK
- 10.1109/TGRS.2011.2124465 is OK
- 10.1109/TGRS.2014.2352853 is OK
- 10.1109/TGRS.2008.2001756 is OK
- 10.3390/rs14020390 is OK
- 10.1016/j.cageo.2022.105291 is OK
- 10.1109/IGARSS.2018.8517504 is OK
- 10.1109/LGRS.2010.2083631 is OK
- 10.6028/jres.066D.020 is OK
- 10.1109/TGRS.2022.3210868 is OK
- 10.1016/j.cageo.2019.104331 is OK
- 10.1109/LGRS.2022.3197423 is OK

MISSING DOIs

- No DOI given, and none found for title: Introducing the OPERA Project for Systematic Surfa...
- No DOI given, and none found for title: JAX: Composable Transformations of Python+NumPy Pr...
- No DOI given, and none found for title: FRInGE; Full-Resolution InSAR Timeseries Using Gen...

INVALID DOIs

- None

For these missing DOIs:

• Two are from AGU meetings (here and here), which have Bibcodes but not DOIs listed
• The other is the suggested JAX citation on their README

[kthyng]

@scottstanie In your paper's summary or statement of need section, can you add a bit about what makes your software important for research? As in, how is it used by researchers, in what line of research, or for what purpose? Something along those lines, please, assuming this is true.

[kthyng]

Also @scottstanie is there a reason for your license file the way it is (select a license, both open source licenses) or is it an accident over time? If there isn't a reason, we would recommend you choose one.

[scottstanie]

@scottstanie In your paper's summary or statement of need section, can you add a bit about what makes your software important for research? As in, how is it used by researchers, in what line of research, or for what purpose? Something along those lines, please, assuming this is true.

Thanks for the comment @kthyng, I have tried to clarify the background and motivation in the summary and statement of need.

Also @scottstanie is there a reason for your license file the way it is (select a license, both open source licenses) or is it an accident over time? If there isn't a reason, we would recommend you choose one.

I've applied the dual Apache-2.0 and BSD-3-Clause license based on the instructions of my institution's Software Release Authority. This work is subject to an Open Source Agreement between my institution and the sponsor agency that governs which license(s) should apply.

[kthyng]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[editorialbot]

Five most similar historical JOSS papers:

stingray: A modern Python library for spectral timing Submitting author: @dhuppenkothen Handling editor: @arfon (Active) Reviewers: @Cadair Similarity score: 0.6738

SenSARP: A pipeline to pre-process Sentinel-1 SLC data by using ESA SNAP Sentinel-1 Toolbox Submitting author: @McWhity Handling editor: @pdebuyl (Active) Reviewers: @arthur-e, @danclewley Similarity score: 0.6727

xeofs: Comprehensive EOF analysis in Python with xarray Submitting author: @nicrie Handling editor: @samhforbes (Active) Reviewers: @DamienIrving, @malmans2 Similarity score: 0.6714

Seaduck: A python package for Eulerian and Lagrangian interpolation on ocean datasets Submitting author: @MaceKuailv Handling editor: @kthyng (Active) Reviewers: @pnsaevik, @syedhamidali Similarity score: 0.6709

SlideRule: Enabling rapid, scalable, open science for the NASA ICESat-2 mission and beyond Submitting author: @dshean Handling editor: @kthyng (Active) Reviewers: @jhkennedy, @betolink Similarity score: 0.6678

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

[kthyng]

We have a backlog of submissions so I will add this to our waitlist. Thanks for your patience.

[kthyng]

@mikemahoney218 Would you be interested in editing this submission?

[kthyng]

@editorialbot invite @mikemahoney218 as editor

[editorialbot]

Invitation to edit this submission sent!

[mikemahoney218]

@editorialbot assign me as editor

Happy to take this one on! I'll start searching for reviewers a bit later on this week, and will follow up here as I hear back.

[editorialbot]

Assigned! @mikemahoney218 is now the editor

[mikemahoney218]

Sent out the first round of reviewer invitations today.

Quick formatting nit on the paper -- I think you want to remove the [] around the Mirzaee 2023 reference on Line 25, to drop the () in the PDF. I'll do a more thorough copyediting scan after the review process, but wanted to note this one in case I didn't see it again later :smile:

[scottstanie]

Sent out the first round of reviewer invitations today.

Quick formatting nit on the paper -- I think you want to remove the [] around the Mirzaee 2023 reference on Line 25, to drop the () in the PDF. I'll do a more thorough copyediting scan after the review process, but wanted to note this one in case I didn't see it again later 😄

👍 I edited the inline citations that I saw to remove the parens

[mikemahoney218]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[editorialbot]

Five most similar historical JOSS papers:

stingray: A modern Python library for spectral timing Submitting author: @dhuppenkothen Handling editor: @arfon (Active) Reviewers: @Cadair Similarity score: 0.6693

xeofs: Comprehensive EOF analysis in Python with xarray Submitting author: @nicrie Handling editor: @samhforbes (Active) Reviewers: @DamienIrving, @malmans2 Similarity score: 0.6693

Seaduck: A python package for Eulerian and Lagrangian interpolation on ocean datasets Submitting author: @MaceKuailv Handling editor: @kthyng (Active) Reviewers: @pnsaevik, @syedhamidali Similarity score: 0.6688

SenSARP: A pipeline to pre-process Sentinel-1 SLC data by using ESA SNAP Sentinel-1 Toolbox Submitting author: @McWhity Handling editor: @pdebuyl (Active) Reviewers: @arthur-e, @danclewley Similarity score: 0.6643

pyprop8: A lightweight code to simulate seismic observables in a layered half-space Submitting author: @valentineap Handling editor: @leouieda (Retired) Reviewers: @hemmelig, @hfmark Similarity score: 0.6627

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

[mikemahoney218]

@editorialbot add McWhity as reviewer

[editorialbot]

I can't add that reviewer: McWhity is not a username

[mikemahoney218]

@editorialbot add @McWhity as reviewer

[editorialbot]

@McWhity added to the reviewers list!

[mikemahoney218]

@editorialbot add @margauxmouchene as reviewer

[editorialbot]

@margauxmouchene added to the reviewers list!

[mikemahoney218]

@editorialbot start review

[editorialbot]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6997.