search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
694 stars 36 forks source link

[PRE REVIEW]: ExaDEM: a HPC application based on exaNBody targeting scalable DEM simulations with complex particle shapes #6936

Open editorialbot opened 6 days ago

editorialbot commented 6 days ago

Submitting author: !--author-handle-->@rprat-pro<!--end-author-handle-- (Raphaël Prat) Repository: https://github.com/Collab4exaNBody/exaDEM Branch with paper.md (empty if default branch): joss_paper Version: v1.0.0 Editor: Pending Reviewers: Pending Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/164b73025d743b47e03c36561e1d4580"><img src="https://joss.theoj.org/papers/164b73025d743b47e03c36561e1d4580/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/164b73025d743b47e03c36561e1d4580/status.svg)](https://joss.theoj.org/papers/164b73025d743b47e03c36561e1d4580)

Author instructions

Thanks for submitting your paper to JOSS @rprat-pro. Currently, there isn't a JOSS editor assigned to your paper.

@rprat-pro if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 6 days ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 6 days ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.08 s (2266.7 files/s, 250757.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C/C++ Header                    57           1247           2270           6480
C++                             86           1456           1782           6408
Markdown                         5             96              0            241
CMake                           32             83            269            233
TeX                              1             18              0            138
Python                           5             57             16            134
YAML                             3             12             17             48
Bourne Shell                     1              1              1             12
-------------------------------------------------------------------------------
SUM:                           190           2970           4355          13694
-------------------------------------------------------------------------------

Commit count by author:

    74  rprat-pro
    54  Raphaël Prat
    16  PRAT Raphael 269144
     6  Thierry Carrard
     4  Raphael PRAT
     3  Thierry CARRARD
     1  DONCECCHI Carlo-Elia
editorialbot commented 6 days ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-031-50684-0_27 is OK
- 10.1209/0295-5075/83/14001 is OK

MISSING DOIs

- No DOI given, and none found for title: Simulation of liquids and solids
- No DOI given, and none found for title: Rocakble
- 10.1016/j.cpc.2021.108171 may be a valid DOI for title: LAMMPS-a flexible simulation tool for particle-bas...
- 10.2172/10176421 may be a valid DOI for title: Fast parallel algorithms for short-range molecular...
- 10.1103/physrev.159.98 may be a valid DOI for title: Computer" experiments" on classical fluids. I. The...
- 10.1504/pcfd.2012.047457 may be a valid DOI for title: Models, algorithms and validation for opensource D...
- 10.1007/978-3-319-69953-0_10 may be a valid DOI for title: Tins: A task-based dynamic helper core strategy fo...
- 10.1016/j.amc.2017.03.037 may be a valid DOI for title: A study of shape non-uniformity and poly-dispersit...
- 10.1007/978-3-319-14313-2_11 may be a valid DOI for title: ExaStamp: A parallel framework for molecular dynam...
- 10.1145/3225058.3225085 may be a valid DOI for title: Combining task-based parallelism and adaptive mesh...
- 10.1016/j.cpc.2020.107177 may be a valid DOI for title: AMR-based molecular dynamics for non-uniform, high...
- 10.1016/j.cpc.2019.107129 may be a valid DOI for title: Fast, flexible particle simulations—an introductio...
- No DOI given, and none found for title: Yade documentation

INVALID DOIs

- 10.1016/B978-1-78548-076-8 is INVALID
editorialbot commented 6 days ago

Paper file info:

📄 Wordcount for paper.md is 1609

✅ The paper includes a Statement of need section

editorialbot commented 6 days ago

:warning: An error happened when generating the pdf. Problem with affiliations for Thierry Carrard, perhaps the affiliations index need quoting?.

editorialbot commented 6 days ago

License info:

✅ License found: Apache License 2.0 (Valid open source OSI approved license)

rprat-pro commented 6 days ago

@editorialbot generate pdf

editorialbot commented 6 days ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 6 days ago

👋 @rprat-pro - Thanks for your submission.

Note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it. In addition, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf after making changes to the .md file or when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

editorialbot commented 6 days ago

Five most similar historical JOSS papers:

Akantu: an HPC finite-element library for contact and dynamic fracture simulations Submitting author: @nrichart Handling editor: @diehlpk (Active) Reviewers: @vijaysm, @chennachaos Similarity score: 0.7054

Efficient Polyhedral Gravity Modeling in Modern C++ and Python Submitting author: @schuhmaj Handling editor: @dfm (Active) Reviewers: @mikegrudic, @santisoler Similarity score: 0.7035

RHEA: an open-source Reproducible Hybrid-architecture flow solver Engineered for Academia Submitting author: @lluisjofre Handling editor: @diehlpk (Active) Reviewers: @ctdegroot, @thomasgillis Similarity score: 0.6996

Cabana: A Performance Portable Library for Particle-Based Simulations Submitting author: @streeve Handling editor: @diehlpk (Active) Reviewers: @atmyers, @XzzX Similarity score: 0.6991

PAPRECA: A parallel hybrid off-lattice kinetic Monte Carlo/molecular dynamics simulator Submitting author: @sntioudis Handling editor: @srmnitc (Active) Reviewers: @liamhuber, @jfaraudo Similarity score: 0.6941

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

rprat-pro commented 6 days ago

@editorialbot check references

editorialbot commented 6 days ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-031-50684-0_27 is OK
- 10.1016/j.cpc.2021.108171 is OK
- 10.2172/10176421 is OK
- 10.1103/physrev.159.98 is OK
- 10.1504/pcfd.2012.047457 is OK
- 10.1007/978-3-319-69953-0_10 is OK
- 10.1016/j.amc.2017.03.037 is OK
- 10.1007/978-3-319-14313-2_11 is OK
- 10.1145/3225058.3225085 is OK
- 10.1016/j.cpc.2020.107177 is OK
- 10.1016/j.cpc.2019.107129 is OK
- 10.48550/arXiv.2301.00611 is OK
- 10.1209/0295-5075/83/14001 is OK

MISSING DOIs

- No DOI given, and none found for title: Simulation of liquids and solids
- No DOI given, and none found for title: Rocakble
- 10.1016/c2015-0-01294-1 may be a valid DOI for title: Modeling Gravity Hazards from Rockfalls to Landsli...

INVALID DOIs

- None
rprat-pro commented 6 days ago

@editorialbot check references

editorialbot commented 6 days ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-031-50684-0_27 is OK
- 10.1016/j.cpc.2021.108171 is OK
- 10.2172/10176421 is OK
- 10.1103/physrev.159.98 is OK
- 10.1504/pcfd.2012.047457 is OK
- 10.1007/978-3-319-69953-0_10 is OK
- 10.1016/j.amc.2017.03.037 is OK
- 10.1007/978-3-319-14313-2_11 is OK
- 10.1145/3225058.3225085 is OK
- 10.1016/j.cpc.2020.107177 is OK
- 10.1016/j.cpc.2019.107129 is OK
- 10.48550/arXiv.2301.00611 is OK
- 10.1016/c2015-0-01294-1 is OK
- 10.1209/0295-5075/83/14001 is OK

MISSING DOIs

- No DOI given, and none found for title: Simulation of liquids and solids
- No DOI given, and none found for title: Rocakble

INVALID DOIs

- None
rprat-pro commented 6 days ago

@editorialbot generate pdf

editorialbot commented 6 days ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 6 days ago

Five most similar historical JOSS papers:

Akantu: an HPC finite-element library for contact and dynamic fracture simulations Submitting author: @nrichart Handling editor: @diehlpk (Active) Reviewers: @vijaysm, @chennachaos Similarity score: 0.7051

Efficient Polyhedral Gravity Modeling in Modern C++ and Python Submitting author: @schuhmaj Handling editor: @dfm (Active) Reviewers: @mikegrudic, @santisoler Similarity score: 0.7034

RHEA: an open-source Reproducible Hybrid-architecture flow solver Engineered for Academia Submitting author: @lluisjofre Handling editor: @diehlpk (Active) Reviewers: @ctdegroot, @thomasgillis Similarity score: 0.6997

Cabana: A Performance Portable Library for Particle-Based Simulations Submitting author: @streeve Handling editor: @diehlpk (Active) Reviewers: @atmyers, @XzzX Similarity score: 0.6986

PAPRECA: A parallel hybrid off-lattice kinetic Monte Carlo/molecular dynamics simulator Submitting author: @sntioudis Handling editor: @srmnitc (Active) Reviewers: @liamhuber, @jfaraudo Similarity score: 0.6939

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

rprat-pro commented 6 days ago

Hello @danielskatz,

Thank you to manage our submission. The paper seems to compile correctly and the missing doi have been added. Unfortunately, I am unable to find the DOI for the last two papers.

danielskatz commented 6 days ago

That's fine - not all papers have DOIs. As you can see above, we've also moved this to another track, so another track editor will take over.