search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
694 stars 36 forks source link

[PRE REVIEW]: DelaunayTriangulation.jl: A Julia package for Delaunay triangulations and Voronoi tessellations in the plane #6937

Open editorialbot opened 1 week ago

editorialbot commented 1 week ago

Submitting author: !--author-handle-->@DanielVandH<!--end-author-handle-- (Daniel VandenHeuvel) Repository: https://github.com/JuliaGeometry/DelaunayTriangulation.jl Branch with paper.md (empty if default branch): paper Version: v1.0.3 Editor: !--editor-->@Kevin-Mattheus-Moerman<!--end-editor-- Reviewers: Pending Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9f806b9bc4dd2f31f5e7ca67b64448bd"><img src="https://joss.theoj.org/papers/9f806b9bc4dd2f31f5e7ca67b64448bd/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9f806b9bc4dd2f31f5e7ca67b64448bd/status.svg)](https://joss.theoj.org/papers/9f806b9bc4dd2f31f5e7ca67b64448bd)

Author instructions

Thanks for submitting your paper to JOSS @DanielVandH. Currently, there isn't a JOSS editor assigned to your paper.

@DanielVandH if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 week ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 week ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.45 s (616.6 files/s, 166696.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                          187           5186          11288          41961
Markdown                        75           2053              0           9646
TOML                             6            705              2           3323
TeX                              1             25              0            212
YAML                             6              9             11            175
JSON                             1              0              0             22
-------------------------------------------------------------------------------
SUM:                           276           7978          11301          55339
-------------------------------------------------------------------------------

Commit count by author:

   530  DanielVandH
    49  Daniel VandenHeuvel
     3  dependabot[bot]
     2  Júlio Hoffimann
     1  CompatHelper Julia
     1  Simon
     1  himcraft
editorialbot commented 1 week ago

Paper file info:

📄 Wordcount for paper.md is 969

✅ The paper includes a Statement of need section

editorialbot commented 1 week ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 1 week ago

:warning: An error happened when generating the pdf. Problem with ORCID (https://orcid.org/0000-0001-6462-0135) for Daniel VandenHeuvel. ORCID looks to be the wrong length.

editorialbot commented 1 week ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/S0925-7721(98)00035-2 is OK
- 10.5281/zenodo.11178646 is OK
- 10.5281/zenodo.11176971 is OK

MISSING DOIs

- No DOI given, and none found for title: Delaunay Mesh Generation
- No DOI given, and none found for title: Voronoi Diagrams and Delaunay Triangulations
- No DOI given, and none found for title: Natural neighbor interpolation - critical assessme...
- No DOI given, and none found for title: Delaunay refinement mesh generation of curve-bound...
- 10.1137/141000671 may be a valid DOI for title: Julia: A fresh approach to numerical computing
- 10.1016/s0168-874x(96)00054-6 may be a valid DOI for title: Delaunay triangulation and 3D adaptive mesh genera...
- 10.1137/050643568 may be a valid DOI for title: Adaptive finite element methods for elliptic PDEs ...
- No DOI given, and none found for title: ExactPredicates.jl: Fast and exact geometrical pre...
- 10.1016/s0070-2153(07)81013-1 may be a valid DOI for title: Delaunay-object-dynamics: Cell mechanics with a 3D...
- No DOI given, and none found for title: Centroidal Voronoi tessellations: Applications and...
- 10.1101/2022.09.13.507714 may be a valid DOI for title: Calibration of agent based models for monophasic a...
- 10.1007/bfb0014497 may be a valid DOI for title: Triangle:  Engineering a 2D quality mesh generator...
- No DOI given, and none found for title: MATLAB version: R2024a
- 10.1109/wcica.2008.4593771 may be a valid DOI for title: Path planning based on constrained Delaunay triang...
- No DOI given, and none found for title: SciPy 1.0: Fundamental Algorithms for Scientific C...
- No DOI given, and none found for title: CGAL User and Reference Manual
- No DOI given, and none found for title: Gmsh: a three-dimensional finite element mesh gene...
- 10.31224/3017 may be a valid DOI for title: New computational tools and experiments reveal how...
- 10.21105/joss.03349 may be a valid DOI for title: Makie.jl: Flexible high-performance data visualiza...
- No DOI given, and none found for title: A Guide to First Passage Processes
- 10.1088/1751-8121/ac4a1d may be a valid DOI for title: Mean exit time in irregularly-shaped annular and c...

INVALID DOIs

- None
danielskatz commented 1 week ago

👋 @DanielVandH - Thanks for your submission.

Note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it. In addition, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf after making changes to the .md file or when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

DanielVandH commented 1 week ago

Thanks @danielskatz. I'll check out the compiling issues - it worked when I did it in https://github.com/JuliaGeometry/DelaunayTriangulation.jl/actions/runs/9697066359, did I configure the workflow file incorrectly?

I'll get all the DOIs fixed up. I'll get them manually incase some of them are incorrect as you suggest, thanks.

DanielVandH commented 1 week ago

@DanielVandH if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Of those that I can see in that list, Kevin Moerman and juliohm are probably suitable.

DanielVandH commented 1 week ago

@editorialbot check references

editorialbot commented 1 week ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1142/8685 is OK
- 10.1016/S0925-7721(98)00035-2 is OK
- 10.14288/1.0067778 is OK
- 10.1137/141000671 is OK
- 10.1016/S0168-874X(96)00054-6 is OK
- 10.1137/050643568 is OK
- 10.1016/S0070-2153(07)81013-1 is OK
- 10.1137/S0036144599352836 is OK
- 10.1007/s00285-024-02045-4 is OK
- 10.1007/BFb0014497 is OK
- 10.1109/WCICA.2008.4593771 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1002/nme.2579 is OK
- 10.21105/joss.03349 is OK
- 10.5281/zenodo.11178646 is OK
- 10.5281/zenodo.11176971 is OK
- 10.1017/CBO9780511606014 is OK
- 10.1088/1751-8121/ac4a1d is OK

MISSING DOIs

- No DOI given, and none found for title: Delaunay Mesh Generation
- No DOI given, and none found for title: Natural neighbor interpolation - critical assessme...
- No DOI given, and none found for title: ExactPredicates.jl: Fast and exact geometrical pre...
- No DOI given, and none found for title: MATLAB version: R2024a
- No DOI given, and none found for title: CGAL User and Reference Manual

INVALID DOIs

- https://doi.org/10.1016/j.cej.2023.145776 is INVALID because of 'https://doi.org/' prefix
DanielVandH commented 1 week ago

@editorialbot check references

editorialbot commented 1 week ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1142/8685 is OK
- 10.1016/S0925-7721(98)00035-2 is OK
- 10.14288/1.0067778 is OK
- 10.1137/141000671 is OK
- 10.1016/S0168-874X(96)00054-6 is OK
- 10.1137/050643568 is OK
- 10.1016/S0070-2153(07)81013-1 is OK
- 10.1137/S0036144599352836 is OK
- 10.1007/s00285-024-02045-4 is OK
- 10.1007/BFb0014497 is OK
- 10.1109/WCICA.2008.4593771 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1002/nme.2579 is OK
- 10.1016/j.cej.2023.145776 is OK
- 10.21105/joss.03349 is OK
- 10.5281/zenodo.11178646 is OK
- 10.5281/zenodo.11176971 is OK
- 10.1017/CBO9780511606014 is OK
- 10.1088/1751-8121/ac4a1d is OK

MISSING DOIs

- No DOI given, and none found for title: Delaunay Mesh Generation
- No DOI given, and none found for title: Natural neighbor interpolation - critical assessme...
- No DOI given, and none found for title: ExactPredicates.jl: Fast and exact geometrical pre...
- No DOI given, and none found for title: MATLAB version: R2024a
- No DOI given, and none found for title: CGAL User and Reference Manual

INVALID DOIs

- None
DanielVandH commented 1 week ago

@editorialbot generate pdf

editorialbot commented 1 week ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 week ago

Five most similar historical JOSS papers:

Gridap: An extensible Finite Element toolbox in Julia Submitting author: @fverdugo Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @PetrKryslUCSD, @TeroFrondelius, @KristofferC Similarity score: 0.7475

Makie.jl: Flexible high-performance data visualization for Julia Submitting author: @jkrumbiegel Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @fverdugo, @gaelforget Similarity score: 0.7306

GaussianRandomFields.jl: A Julia package to generate and sample from Gaussian random fields Submitting author: @PieterjanRobbe Handling editor: @jbytecode (Active) Reviewers: @ziyiyin97, @shahmoradi Similarity score: 0.7302

DynamicalBilliards.jl: An easy-to-use, modular and extendable Julia package for Dynamical Billiard systems in two dimensions. Submitting author: @Datseris Handling editor: @kyleniemeyer (Active) Reviewers: @ahwillia Similarity score: 0.7222

GridapDistributed: a massively parallel finite element toolbox in Julia Submitting author: @amartinhuertas Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @PetrKryslUCSD, @Leticia-maria, @jedbrown Similarity score: 0.7170

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

DanielVandH commented 1 week ago 
- No DOI given, and none found for title: Delaunay Mesh Generation
- No DOI given, and none found for title: Natural neighbor interpolation - critical assessme...
- No DOI given, and none found for title: ExactPredicates.jl: Fast and exact geometrical pre...
- No DOI given, and none found for title: MATLAB version: R2024a
- No DOI given, and none found for title: CGAL User and Reference Manual

As far as I can tell, none of these titles have a DOI assigned to them, and https://www.crossref.org/guestquery also seems to show no DOIs for them.

danielskatz commented 1 week ago

Thanks @danielskatz. I'll check out the compiling issues - it worked when I did it in https://github.com/JuliaGeometry/DelaunayTriangulation.jl/actions/runs/9697066359, did I configure the workflow file incorrectly?

I'll get all the DOIs fixed up. I'll get them manually incase some of them are incorrect as you suggest, thanks.

Sometimes there can be difference between the action and what we do. I'm unsure why, but I'm pinging @openjournals/dev in case this is something they can fix.

danielskatz commented 1 week ago

Thanks for your fixes @DanielVandH

danielskatz commented 1 week ago

@editorialbot assign @Kevin-Mattheus-Moerman as editor

thanks Kevin!

editorialbot commented 1 week ago

Assigned! @Kevin-Mattheus-Moerman is now the editor