search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
713 stars 38 forks source link

[PRE REVIEW]: AMaze: a benchmark generator for sighted maze-navigating agents #6945

Closed editorialbot closed 3 weeks ago

editorialbot commented 3 months ago

Submitting author: !--author-handle-->@kgd-al<!--end-author-handle-- (Kevin Godin - Dubois) Repository: https://github.com/kgd-al/amaze Branch with paper.md (empty if default branch): joss Version: 1.0rc1 Editor: !--editor-->@ymzayek<!--end-editor-- Reviewers: @stheid, @abhiramm7 Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/bc6892f6873808ced10bc8c4c222e635"><img src="https://joss.theoj.org/papers/bc6892f6873808ced10bc8c4c222e635/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/bc6892f6873808ced10bc8c4c222e635/status.svg)](https://joss.theoj.org/papers/bc6892f6873808ced10bc8c4c222e635)

Author instructions

Thanks for submitting your paper to JOSS @kgd-al. Currently, there isn't a JOSS editor assigned to your paper.

@kgd-al if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 3 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 3 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/TSMC.1983.6313077 is OK
- 10.1613/jair.3912 is OK
- 10.1109/IROS.2012.6386109 is OK
- 10.5281/zenodo.8269265 is OK

MISSING DOIs

- No DOI given, and none found for title: Reinforcement learning: An introduction

INVALID DOIs

- None
editorialbot commented 3 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.08 s (1193.5 files/s, 159241.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          62           2049            702           7558
Bourne Shell                     8             91             50            397
TeX                              6             32             13            311
reStructuredText                 9            147            125            282
CSV                              1              0              0            210
Markdown                         2             63              0            182
YAML                             4             29             14            176
TOML                             1             14              0             75
CSS                              1              2              0             20
-------------------------------------------------------------------------------
SUM:                            94           2427            904           9211
-------------------------------------------------------------------------------

Commit count by author:

   125  Kevin Godin-Dubois
editorialbot commented 3 months ago

Paper file info:

📄 Wordcount for paper.md is 1182

✅ The paper includes a Statement of need section

editorialbot commented 3 months ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 3 months ago

Five most similar historical JOSS papers:

Abmarl: Connecting Agent-Based Simulations with Multi-Agent Reinforcement Learning Submitting author: @rusu24edward Handling editor: @drvinceknight (Active) Reviewers: @seba-1511, @abhiramm7 Similarity score: 0.6818

OMG: A Scalable and Flexible Simulation and Testing Environment Toolbox for Intelligent Microgrid Control Submitting author: @stheid Handling editor: @dhhagan (Retired) Reviewers: @katyhuff, @gonsie Similarity score: 0.6779

sbp-env: A Python Package for Sampling-based Motion Planner and Samplers Submitting author: @soraxas Handling editor: @danielskatz (Active) Reviewers: @KanishAnand, @OlgerSiebinga Similarity score: 0.6758

OTTO: A Python package to simulate, solve and visualize the source-tracking POMDP Submitting author: @auroreloisy Handling editor: @VivianePons (Retired) Reviewers: @11michalis11, @RomainAzais Similarity score: 0.6673

gym-saturation: an OpenAI Gym environment for saturation provers Submitting author: @inpefess Handling editor: @VivianePons (Retired) Reviewers: @lutzhamel, @quickbeam123 Similarity score: 0.6640

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

crvernon commented 3 months ago

@editorialbot invite @ymzayek as editor

:wave: @ymzayek - do you think you could take this one on as editor? Thanks!

editorialbot commented 3 months ago

Invitation to edit this submission sent!

ymzayek commented 3 months ago

@crvernon I'm happy to take it but I'm not very available until July 15th. If that's ok feel free to assign it to me and I'll at least get it going right away with trying to find reviewers

crvernon commented 3 months ago

@editorialbot add @ymzayek as editor

@ymzayek that's perfect, thank you!

editorialbot commented 3 months ago

Assigned! @ymzayek is now the editor

ymzayek commented 3 months ago

@editorialbot generate pdf

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

ymzayek commented 3 months ago

@editorialbot check references

editorialbot commented 3 months ago

Five most similar historical JOSS papers:

Abmarl: Connecting Agent-Based Simulations with Multi-Agent Reinforcement Learning Submitting author: @rusu24edward Handling editor: @drvinceknight (Active) Reviewers: @seba-1511, @abhiramm7 Similarity score: 0.6755

OMG: A Scalable and Flexible Simulation and Testing Environment Toolbox for Intelligent Microgrid Control Submitting author: @stheid Handling editor: @dhhagan (Retired) Reviewers: @katyhuff, @gonsie Similarity score: 0.6754

sbp-env: A Python Package for Sampling-based Motion Planner and Samplers Submitting author: @soraxas Handling editor: @danielskatz (Active) Reviewers: @KanishAnand, @OlgerSiebinga Similarity score: 0.6717

OTTO: A Python package to simulate, solve and visualize the source-tracking POMDP Submitting author: @auroreloisy Handling editor: @VivianePons (Retired) Reviewers: @11michalis11, @RomainAzais Similarity score: 0.6620

gym-saturation: an OpenAI Gym environment for saturation provers Submitting author: @inpefess Handling editor: @VivianePons (Retired) Reviewers: @lutzhamel, @quickbeam123 Similarity score: 0.6574

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

editorialbot commented 3 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/TSMC.1983.6313077 is OK
- 10.1613/jair.3912 is OK
- 10.1109/IROS.2012.6386109 is OK
- 10.5281/zenodo.8269265 is OK

MISSING DOIs

- No DOI given, and none found for title: Reinforcement learning: An introduction

INVALID DOIs

- None
ymzayek commented 3 months ago

Hi @kgd-al, thank you for submitting to JOSS. I am the handling editor for this submission.

Do you have any suggestion for reviewers?

If you have suggestions, please provide a list of potential reviewers here but do not use the @ character to avoid receiving unwanted notifications.

And finally, can you check the missing DOI listed here: https://github.com/openjournals/joss-reviews/issues/6945#issuecomment-2203405335 ?

Thank you in advance.

kgd-al commented 3 months ago

Hi @ymzayek and thanks for handling the edition of this submission.

I do not have any specific suggestion for the reviewers but based on the articles editorialbot listed:

The missing doi is coming from a book for which there seems to only be an ISBN. How should I proceed?

ymzayek commented 3 months ago

@kgd-al ok for the missing DOI. Thanks for the list!

ymzayek commented 3 months ago

Hello @lutzhamel, @KanishAnand and @gonsie ,

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled:

AMaze: a benchmark generator for sighted maze-navigating agents

You can find more information at the top of this Github issue (https://github.com/openjournals/joss-reviews/issues/6945).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be 23 check items for each single reviewer.

Thank you in advance!

gonsie commented 2 months ago

Sorry, this is too outside of my field. Thanks.

ymzayek commented 2 months ago

Hello @abhiramm7 and @seba-1511,

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled:

AMaze: a benchmark generator for sighted maze-navigating agents

You can find more information at the top of this Github issue (https://github.com/openjournals/joss-reviews/issues/6945).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be 23 check items for each single reviewer.

Thank you in advance!

abhiramm7 commented 2 months ago

@ymzayek I would be happy to review the work.

ymzayek commented 1 month ago

Thanks @abhiramm7! Once we find one or two other reviewers we will begin the review process in another thread.

ymzayek commented 1 month ago

@kgd-al do you have any other reviewers you can suggest?

kgd-al commented 1 month ago

@ymzayek Well according to the guidelines at the top, we should consider the authors from the 5 most similar papers. Meaning:

ymzayek commented 3 weeks ago

Hello @rusu24edward, @stheid, and @soraxas

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled:

AMaze: a benchmark generator for sighted maze-navigating agents

You can find more information at the top of this Github issue (https://github.com/openjournals/joss-reviews/issues/6945).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be 23 check items for each single reviewer.

Thank you in advance!

stheid commented 3 weeks ago

sure

soraxas commented 3 weeks ago

I'm currently in the process of reviewing another repo, and will pass on this, thanks.

ymzayek commented 3 weeks ago

No problem @soraxas

I think we can get the review process started with @stheid and @abhiramm7

ymzayek commented 3 weeks ago

@stheid and @abhiramm7 thanks for agreeing to review this paper.

The review will start in a separate thread.

@kgd-al you can follow the review in the new review issue that will be opened.

ymzayek commented 3 weeks ago

@editorialbot start review

editorialbot commented 3 weeks ago

Can't start a review without reviewers

ymzayek commented 3 weeks ago

@editorialbot add @stheid as reviewer

editorialbot commented 3 weeks ago

@stheid added to the reviewers list!

ymzayek commented 3 weeks ago

@editorialbot add @abhiramm7 as reviewer

editorialbot commented 3 weeks ago

@abhiramm7 added to the reviewers list!

ymzayek commented 3 weeks ago

@editorialbot start review

editorialbot commented 3 weeks ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/7208.