openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
694 stars 36 forks source link

[PRE REVIEW]: FAIRmaterials: Ontology Tools with Data FAIRification in Development #6951

Open editorialbot opened 5 days ago

editorialbot commented 5 days ago

Submitting author: !--author-handle-->@Alexhb02<!--end-author-handle-- (Alexander Harding Bradley) Repository: https://github.com/cwru-sdle/FAIRmaterials Branch with paper.md (empty if default branch): main Version: 0.4.2.2 Editor: Pending Reviewers: Pending Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b38d892fdc407c82379ea4f164110674"><img src="https://joss.theoj.org/papers/b38d892fdc407c82379ea4f164110674/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b38d892fdc407c82379ea4f164110674/status.svg)](https://joss.theoj.org/papers/b38d892fdc407c82379ea4f164110674)

Author instructions

Thanks for submitting your paper to JOSS @Alexhb02. Currently, there isn't a JOSS editor assigned to your paper.

@Alexhb02 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 5 days ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 5 days ago

:warning: An error happened when generating the pdf.

danielskatz commented 5 days ago

@editorialbot set as branch

editorialbot commented 5 days ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

danielskatz commented 5 days ago

@editorialbot set main as branch

editorialbot commented 5 days ago

Done! branch is now main

danielskatz commented 5 days ago

@editorialbot check repository

danielskatz commented 5 days ago

@editorialbot check references

danielskatz commented 5 days ago

@editorialbot generate pdf

editorialbot commented 5 days ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.05 s (722.0 files/s, 236739.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                             1            338              5           1755
SVG                              2              0            299           1483
R                                4            169            298            797
Python                           8            205            282            636
Markdown                         4            139              0            367
CSV                             10              0              0            145
TeX                              1              8              0             93
TOML                             1              5              0             76
Rmd                              3            487           3528             33
-------------------------------------------------------------------------------
SUM:                            34           1351           4412           5385
-------------------------------------------------------------------------------

Commit count by author:

     8  Jonathan Gordon
     1  Jonathan-E-Gordon
editorialbot commented 5 days ago

Paper file info:

📄 Wordcount for paper.md is 2575

✅ The paper includes a Statement of need section

editorialbot commented 5 days ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/sdata.2016.18 is OK
- 10.1145/2757001.2757003 is OK

MISSING DOIs

- 10.1007/978-3-319-17966-7_21 may be a valid DOI for title: WebVOWL: Web-based Visualization of Ontologies
- No DOI given, and none found for title: Graphviz Python Package
- No DOI given, and none found for title: RDFLib: Python Library for working with RDF
- 10.32614/cran.package.diagrammer may be a valid DOI for title: DiagrammeR: Graph/Network Visualization
- 10.32614/cran.package.rdflib may be a valid DOI for title: rdflib: Tools to Manipulate and Query Semantic Dat...
- No DOI given, and none found for title: PyPI: The Python Package Index
- No DOI given, and none found for title: CRAN: The Comprehensive R Archive Network

INVALID DOIs

- None
editorialbot commented 5 days ago

License info:

✅ License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

editorialbot commented 5 days ago

:warning: An error happened when generating the pdf. Author (Roger H. French) is missing affiliation.

danielskatz commented 5 days ago

👋 @Alexhb02 - note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it. In addition, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf after making changes to the .md file or when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

Jonathan-E-Gordon commented 5 days ago

@editorialbot check references

editorialbot commented 5 days ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/sdata.2016.18 is OK
- 10.32614/CRAN.package.DiagrammeR is OK
- 10.1145/2757001.2757003 is OK
- 10.32614/CRAN.package.rdflib is OK

MISSING DOIs

- 10.1007/978-3-319-17966-7_21 may be a valid DOI for title: WebVOWL: Web-based Visualization of Ontologies
- No DOI given, and none found for title: Graphviz Python Package
- No DOI given, and none found for title: RDFLib: Python Library for working with RDF
- No DOI given, and none found for title: PyPI: The Python Package Index
- No DOI given, and none found for title: CRAN: The Comprehensive R Archive Network

INVALID DOIs

- None
Jonathan-E-Gordon commented 5 days ago

@editorialbot generate pdf

editorialbot commented 5 days ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 5 days ago

Five most similar historical JOSS papers:

Building, Importing, and Exporting GEXF Graph Files with rgexf Submitting author: @gvegayon Handling editor: @fabian-s (Active) Reviewers: @jonjoncardoso, @corneliusfritz Similarity score: 0.6791

microViz: an R package for microbiome data visualization and statistics Submitting author: @david-barnett Handling editor: @lpantano (Active) Reviewers: @marypiper, @yoonjeongcha Similarity score: 0.6780

A reusable tree-based web-visualization to browse EDAM ontology, and contribute to it. Submitting author: @bryan-brancotte Handling editor: @pjotrp (Retired) Reviewers: @alexgarciac Similarity score: 0.6735

glottospace: R package for language mapping and geospatial analysis of linguistic and cultural data Submitting author: @SietzeN Handling editor: @ajstewartlang (Active) Reviewers: @fauxneticien, @skalyan91 Similarity score: 0.6715

rTASSEL: An R interface to TASSEL for analyzing genomic diversity Submitting author: @btmonier Handling editor: @fboehm (Active) Reviewers: @tkchafin, @tomsing1 Similarity score: 0.6715

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

danielskatz commented 5 days ago

@Alexhb02 & @Jonathan-E-Gordon - JOSS papers are expected to be 250-1000 words in length. This paper is currently over 2500, as shown by the @editorialbot check repository command. If JOSS accepts this for review, you will have to reduce it. Additionally, the remaining suggested DOI appears correct, so at some point, you will need to add it to the entry in the .bib file.

But before we get to that point, I'm going to ask the editors to discuss if it meets the substantial scholarly effort criterion for review by JOSS, due to the relatively small number of lines of code. You should hear back in couple of weeks or so.

As part of this review, editors will look at the repo's commit history. It appears very brief, making me suspect that development happened before the repository was created. Can you say anything about the work that isn't visible here? How many contributors have their been? How much work was involved (in person-months perhaps), and over what period?

danielskatz commented 5 days ago

@editorialbot query scope

editorialbot commented 5 days ago

Submission flagged for editorial review.

Jonathan-E-Gordon commented 4 days ago

@danielskatz The software was published on CRAN and PyPI in 2021. Due to lab policy, we developed the software in a private Bitbucket repository, which has accumulated over 400 commits since 2021. In January 2024, we initiated a redesign of the software, resulting in 110 commits from 9 authors, representing approximately 7 person-months of work. We can send the whole commit history if that is helpful. This software will also be cited in a Scientific Data paper currently under review, titled “Materials Data Science Ontology (MDS-Onto): Unifying Domain Knowledge in Materials and Applied Data Science” and we believe this software will be very valuable for those generating ontologies, addressing a need in various academic domains.