openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: BrightEyes-MCS: a control suite for multichannel scanning microscopy #6959

Closed editorialbot closed 2 months ago

editorialbot commented 4 months ago

Submitting author: !--author-handle-->@VicidominiLab<!--end-author-handle-- (Mattia Donato) Repository: https://github.com/VicidominiLab/BrightEyes-MCS Branch with paper.md (empty if default branch): paper Version: v0.9.0 Editor: !--editor-->@adamltyson<!--end-editor-- Reviewers: @raacampbell, @jacopoabramo, @beniroquai Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/2408d091c6e4214696e27d2684cb4432"><img src="https://joss.theoj.org/papers/2408d091c6e4214696e27d2684cb4432/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/2408d091c6e4214696e27d2684cb4432/status.svg)](https://joss.theoj.org/papers/2408d091c6e4214696e27d2684cb4432)

Author instructions

Thanks for submitting your paper to JOSS @VicidominiLab. Currently, there isn't a JOSS editor assigned to your paper.

@VicidominiLab if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 4 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 4 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.13 s (518.7 files/s, 218687.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          39           2789           1017          10753
Qt                               4              0              0           7135
SVG                              3              7              3           4870
Markdown                         3            317              0           1124
Cython                           3             84             31            394
HTML                             1              9              0            170
TeX                              1             16              0            152
DOS Batch                        7             17              0            115
XML                              7              0              0             82
Bourne Shell                     1              1              0              6
-------------------------------------------------------------------------------
SUM:                            69           3240           1051          24801
-------------------------------------------------------------------------------

Commit count by author:

    18  Developer (STED)
    10  Vicidomini Lab
     7  Mattia Donato
     6  Mattia D
     3  Developer FCS
     2  Developer ISMFLUX
     2  Mattia from Tracking PC
     1  Developer AO
editorialbot commented 4 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1103/PhysRevLett.104.198101 is OK
- 10.1088/1361-6420/accdc5 is OK
- 10.1016/j.bpr.2021.100025 is OK
- 10.21105/joss.03394 is OK
- 10.1002/0471142727.mb1420s92 is OK
- 10.1103/PhysRevResearch.5.023033 is OK

MISSING DOIs

- No DOI given, and none found for title: Super-resolution in confocal imaging
- No DOI given, and none found for title: Arkitekt : An open-source framework for modern bio...

INVALID DOIs

- 10.1038/s41592-018-0291-7 is INVALID
- 10.1038/s41467-022-31408-6 is INVALID
- 10.1038/s41467-023-15070-4 is INVALID
- 10.1038/s41566-023-01112-y is INVALID
- 10.1364/OPTICA.388600 is INVALID
- 10.1117/1.AP.6.1.015003 is INVALID
- 10.1038/s41467-022-35027-y is INVALID
- 10.1038/s41377-021-00515-w is INVALID
editorialbot commented 4 months ago

Paper file info:

📄 Wordcount for paper.md is 2635

🔴 Failed to discover a Statement of need section in paper

editorialbot commented 4 months ago

License info:

🟡 License found: Other (Check here for OSI approval)

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 4 months ago

Five most similar historical JOSS papers:

SenAOReFoc: A Closed-Loop Sensorbased Adaptive Optics and Remote Focusing Control Software Submitting author: @jiahecui Handling editor: @diehlpk (Active) Reviewers: @abhilash12iec002, @JackTyson, @alvesjnr Similarity score: 0.7179

Open Source Optical Coherence Tomography Software Submitting author: @spectralcode Handling editor: @arfon (Active) Reviewers: @jdavidli, @brandondube Similarity score: 0.7058

PiSCAT: A Python Package for Interferometric Scattering Microscopy Submitting author: @po60nani Handling editor: @emdupre (Active) Reviewers: @ziatdinovmax, @aquilesC Similarity score: 0.6996

LenslessPiCam: A Hardware and Software Platform for Lensless Computational Imaging with a Raspberry Pi Submitting author: @ebezzam Handling editor: @danasolav (Active) Reviewers: @raolivei13, @siddiquesalman Similarity score: 0.6967

LiberTEM: Software platform for scalable multidimensional data processing in transmission electron microscopy Submitting author: @uellue Handling editor: @majensen (Active) Reviewers: @alvarolopez, @fedorov Similarity score: 0.6949

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

Kevin-Mattheus-Moerman commented 3 months ago

@VicidominiLab Dear author, thanks for this submission. I am the AEiC on this track and here to help process the initial steps. Before we proceed, please can you have a look at the following points:

Finally I see this work features hardware requirements. I need to point out that although we have successfully reviewed/published software works that link with specialised hardware in the past, we have also seen severe difficulties in finding reviewers or completing the reviews fully which in some cases has led to the papers ending up retracted. So, since this work appears to require particular NI FPGA's, I just want to add a word of warning that finding reviewers may take long or be unsuccessful altogether, and that the review process may take longer than usual. The success strongly depends on how clear and well documented your package is in terms of what the hardware requirements are and how to set everything up for testing. If you feel these aspects are in good shape that is great, if not, then pushing now for these to be extended would be a good idea. Further more, when asked by the editor, it would be really helpful if you could help suggest any potential reviewers (provided there is no conflict of interest). So in short, hardware related submissions in JOSS are possible, however they can be tricky, so keep that in mind. Thanks.

Kevin-Mattheus-Moerman commented 3 months ago

@VicidominiLab :wave:

Kevin-Mattheus-Moerman commented 3 months ago

@VicidominiLab responding to queries on this issue in a timely manor is important. Please respond to the above points by the end of this week. If we do not hear from you we'll proceed to reject this submission due to inactivity.

Kevin-Mattheus-Moerman commented 2 months ago

@VicidominiLab last reminder, please respond to the above points. Thanks.

VicidominiLab commented 2 months ago

Dear @Kevin-Mattheus-Moerman,

Thank you for your feedback on our submission and your patience. Thank you for the comment about the bibliography issues and the contributing guidelines. In the next commit I will fix the .bib file, the contributing.md and I will try to push more clearly hardware requirements and setup process.

We chose JOSS for our submission because it aligns with our project goals and audience. We've noticed similar projects microscopy-related, like ImSwitch, which also involve hardware components. I understand the complexities involved in reviewing hardware-dependent software but in scientific-paper revision it is rare that the reviewer has the hardware/complete system in hand. In our case, while the NIFPGA hardware mentioned in the paper is essential for running the BrightEyes-MCS acquisition, the additional hardware components (such as detectors, optics, optoelectronics, lasers, etc...) are not strictly required for testing the software.

Regarding the review process, I understand the potential challenges in finding suitable reviewers due to the hardware aspect. To assist, I would like to suggest two potential reviewers who they should have a system similar to ours.

Thank you once again for your assistance. Please let me know if there's anything else I can do to support the process.

Kind regards,

Mattia

Kevin-Mattheus-Moerman commented 2 months ago

@editorialbot invite @adamltyson as editor

editorialbot commented 2 months ago

Invitation to edit this submission sent!

adamltyson commented 2 months ago

Thanks @Kevin-Mattheus-Moerman, happy to take this on.

adamltyson commented 2 months ago

@editorialbot assign @adamltyson as editor

editorialbot commented 2 months ago

Assigned! @adamltyson is now the editor

Kevin-Mattheus-Moerman commented 2 months ago

@adamltyson thanks! Please check all my comments above. Some work is still needed to proceed and I did raise the issue of hardware requirements. But, if we can find reviewers that can help, then I'm happy to proceed to review.

adamltyson commented 2 months ago

Hi @VicidominiLab, I'll take over the submission from now on.

As @Kevin-Mattheus-Moerman mentioned, it may be tricky, or even not possible for this to be reviewed, but we'll try our best! I will push ahead in finding reviewers, but in the mean time, can you make sure to address @Kevin-Mattheus-Moerman's comments about the references and the contributing guide?

Any questions, please let me know.

adamltyson commented 2 months ago

We have a bit of a head start, as @raacampbell has agreed offline to review.

adamltyson commented 2 months ago

@editorialbot add @raacampbell as reviewer

editorialbot commented 2 months ago

@raacampbell added to the reviewers list!

adamltyson commented 2 months ago

@jacopoabramo, @beniroquai, would you be able to review this submission to JOSS?

If you haven't reviewed for JOSS before, we carry out our checklist-driven reviews here in GitHub issues following these guidelines. If you have any questions, let me know.

jacopoabramo commented 2 months ago

Greetings @adamltyson, sorry for the late reply - I was on vacation until yesterday.

I'd be happy to review the paper. Since it's my first time reviewing for JOSS do you have any input on where I should start with the review? Any tip is appreciated. Thank you in advance.

beniroquai commented 2 months ago

Thanks @adamltyson, also sorry for the late reply. Same here. I'm in! :)

adamltyson commented 2 months ago

Hi @jacopoabramo, @beniroquai, thanks both for agreeing to review this. I will go ahead an start the review process. A new GitHub issue will be raised with information and links about how to go about the review, but feel free to ask me any questions.

adamltyson commented 2 months ago

@editorialbot add @jacopoabramo as reviewer

editorialbot commented 2 months ago

@jacopoabramo added to the reviewers list!

adamltyson commented 2 months ago

@editorialbot add @beniroquai as reviewer

editorialbot commented 2 months ago

@beniroquai added to the reviewers list!

adamltyson commented 2 months ago

@editorialbot start review

editorialbot commented 2 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/7125.