openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
707 stars 37 forks source link

[REVIEW]: WhaleConnect: A General-Purpose, Cross-Platform Network Communication Application #6964

Closed editorialbot closed 2 weeks ago

editorialbot commented 2 months ago

Submitting author: !--author-handle-->@AidanSun05<!--end-author-handle-- (Aidan Sun) Repository: https://github.com/WhaleConnect/whaleconnect Branch with paper.md (empty if default branch): paper Version: v1.0.2 Editor: !--editor-->@mahfuz05062<!--end-editor-- Reviewers: @harshadjs, @wob86 Archive: 10.5281/zenodo.13328366

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b8d7a821d1b047017f3bde87e147f7c8"><img src="https://joss.theoj.org/papers/b8d7a821d1b047017f3bde87e147f7c8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b8d7a821d1b047017f3bde87e147f7c8/status.svg)](https://joss.theoj.org/papers/b8d7a821d1b047017f3bde87e147f7c8)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@harshadjs & @wob86, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mahfuz05062 know.

āœØ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest āœØ

Checklists

šŸ“ Checklist for @wob86

šŸ“ Checklist for @harshadjs

editorialbot commented 2 weeks ago
Attempting dry run of processing paper acceptance...
editorialbot commented 2 weeks ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

āœ… OK DOIs

- 10.3389/friot.2022.1073780 is OK
- 10.1186/s40537-019-0268-2 is OK

šŸŸ” SKIP DOIs

- No DOI given, and none found for title: I/O Completion Ports
- No DOI given, and none found for title: Mac OS X Manual Page For kqueue(2)
- No DOI given, and none found for title: IOBluetooth
- No DOI given, and none found for title: liburing
- No DOI given, and none found for title: Coroutines (C++20)

āŒ MISSING DOIs

- None

āŒ INVALID DOIs

- None
editorialbot commented 2 weeks ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5823, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 2 weeks ago

@editorialbot accept

editorialbot commented 2 weeks ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 2 weeks ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Sun given-names: Aidan orcid: "https://orcid.org/0009-0000-6282-2497" doi: 10.5281/zenodo.13328366 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Sun given-names: Aidan orcid: "https://orcid.org/0009-0000-6282-2497" date-published: 2024-08-27 doi: 10.21105/joss.06964 issn: 2475-9066 issue: 100 journal: Journal of Open Source Software publisher: name: Open Journals start: 6964 title: "WhaleConnect: A General-Purpose, Cross-Platform Network Communication Application" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06964" volume: 9 title: "WhaleConnect: A General-Purpose, Cross-Platform Network Communication Application" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 2 weeks ago

šŸ˜šŸ˜šŸ˜ šŸ‘‰ Toot for this paper šŸ‘ˆ šŸ˜šŸ˜šŸ˜

editorialbot commented 2 weeks ago

šŸšØšŸšØšŸšØ THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! šŸšØšŸšØšŸšØ

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5824
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06964
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! šŸŽ‰šŸŒˆšŸ¦„šŸ’ƒšŸ‘»šŸ¤˜

Any issues? Notify your editorial technical team...

danielskatz commented 2 weeks ago

Congratulations to @AidanSun05 (Aidan Sun) on your publication!!

And thanks to @harshadjs and @wob86 for reviewing, and to @mahfuz05062 for editing! JOSS depends on volunteers and couldn't be successful without you

editorialbot commented 2 weeks ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06964/status.svg)](https://doi.org/10.21105/joss.06964)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06964">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06964/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06964/status.svg
   :target: https://doi.org/10.21105/joss.06964

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

AidanSun05 commented 2 weeks ago

Many thanks to @harshadjs @wob86 @mahfuz05062 @danielskatz for your time and effort during this review!