openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
707 stars 37 forks source link

[REVIEW]: Fortuna.jl: Structural and System Reliability Analysis in Julia #6967

Closed editorialbot closed 1 month ago

editorialbot commented 2 months ago

Submitting author: !--author-handle-->@AkchurinDA<!--end-author-handle-- (Damir Akchurin) Repository: https://github.com/AkchurinDA/Fortuna.jl Branch with paper.md (empty if default branch): JOSS Version: v0.10.1 Editor: !--editor-->@jbytecode<!--end-editor-- Reviewers: @baxmittens, @rafaelorozco Archive: 10.5281/zenodo.13222060

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9df63bb9d4f1722272f85a0fc2249856"><img src="https://joss.theoj.org/papers/9df63bb9d4f1722272f85a0fc2249856/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9df63bb9d4f1722272f85a0fc2249856/status.svg)](https://joss.theoj.org/papers/9df63bb9d4f1722272f85a0fc2249856)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@baxmittens & @rafaelorozco, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jbytecode know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @baxmittens

📝 Checklist for @rafaelorozco

AkchurinDA commented 1 month ago

@danielskatz,

A little off topic, but the paper preview is not showing on the journal's website. I have tried Safari and Chrome, but without success. Is the problem on my side or does it just need time to process?

danielskatz commented 1 month ago

Do you mean this?

Screenshot 2024-08-05 at 14 14 07

Or something else? If this, and if you didn't follow the instructions when the paper was accepted Wait five minutes, then verify that the paper DOI resolves you might have gotten a version that didn't resolve, which can be cached for a while.

AkchurinDA commented 1 month ago

Yes, but mine looks like this for some reason in both browsers...

Screenshot 2024-08-05 at 3 16 44 PM

I didn't use the DOI provided by the editorialbot, I just went on the JOSS' website and found the paper. It should be a problem on my side then, just wanted to make sure that others see the preview too. Thanks for checking.

danielskatz commented 1 month ago

It seems like the issue where you didn't get the right version initially as it was being generated, and the bad version got cached (in the network upstream of any particular browser). If you have access to another network (e.g., perhaps a phone network), you might try it there. Otherwise, it should be refreshed in a couple of hours.

jbytecode commented 1 month ago

@AkchurinDA - It is properly rendered in my side, it takes time to get it right, wait a couple of hours