openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[REVIEW]: snSMART: An R Package for Small Sample, Sequential, Multiple Assignment, Randomized Trial Data Analysis #6971

Closed editorialbot closed 2 months ago

editorialbot commented 4 months ago

Submitting author: !--author-handle-->@sidiwang<!--end-author-handle-- (Sidi Wang) Repository: https://github.com/sidiwang/snSMART Branch with paper.md (empty if default branch): JOSS Version: 0.2.4 Editor: !--editor-->@osorensen<!--end-editor-- Reviewers: @aghaynes, @ezraporter Archive: 10.5281/zenodo.13370298

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/119f9b14b157f475c25f737aca4a166e"><img src="https://joss.theoj.org/papers/119f9b14b157f475c25f737aca4a166e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/119f9b14b157f475c25f737aca4a166e/status.svg)](https://joss.theoj.org/papers/119f9b14b157f475c25f737aca4a166e)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@aghaynes & @ezraporter, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @osorensen know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

πŸ“ Checklist for @aghaynes

πŸ“ Checklist for @ezraporter

editorialbot commented 2 months ago
Attempting dry run of processing paper acceptance...
editorialbot commented 2 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

βœ… OK DOIs

- 10.1016/j.cct.2020.105989 is OK
- 10.1111/rssc.12406 is OK
- 10.1002/sim.7900 is OK
- 10.1080/10543406.2020.1815032 is OK
- 10.1002/sim.8813 is OK
- 10.1002/sim.8776 is OK
- 10.1016/S0140-6736(02)07283-5 is OK
- 10.1186/s13063-020-04285-3 is OK
- 10.2307/2348770 is OK
- 10.1111/1467-985X.00154 is OK
- 10.1002/sim.2022 is OK
- 10.1093/biostatistics/kxr016 is OK
- 10.32614/CRAN.package.geepack is OK
- 10.18637/jss.v015.i02 is OK
- 10.1002/sim.1650 is OK
- 10.2307/2531248 is OK
- 10.32614/CRAN.package.EnvStats is OK
- 10.32614/CRAN.package.rjags is OK

🟑 SKIP DOIs

- No DOI given, and none found for title: geepack: Yet Another Package for Generalized Estim...
- No DOI given, and none found for title: JAGS: A Program for Analysis of Bayesian Graphical...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
editorialbot commented 2 months ago

:wave: @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5876, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

samhforbes commented 2 months ago

@editorialbot accept

editorialbot commented 2 months ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 2 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Wang given-names: Sidi orcid: "https://orcid.org/0000-0003-4838-0842" - family-names: Fang given-names: Fang orcid: "https://orcid.org/0000-0002-7089-3591" - family-names: Tamura given-names: Roy - family-names: Braun given-names: Thomas orcid: "https://orcid.org/0000-0002-7113-6998" - family-names: Kidwell given-names: Kelley M orcid: "https://orcid.org/0000-0002-1717-4483" doi: 10.5281/zenodo.13370298 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Wang given-names: Sidi orcid: "https://orcid.org/0000-0003-4838-0842" - family-names: Fang given-names: Fang orcid: "https://orcid.org/0000-0002-7089-3591" - family-names: Tamura given-names: Roy - family-names: Braun given-names: Thomas orcid: "https://orcid.org/0000-0002-7113-6998" - family-names: Kidwell given-names: Kelley M orcid: "https://orcid.org/0000-0002-1717-4483" date-published: 2024-09-12 doi: 10.21105/joss.06971 issn: 2475-9066 issue: 101 journal: Journal of Open Source Software publisher: name: Open Journals start: 6971 title: "snSMART: An R Package for Small Sample, Sequential, Multiple Assignment, Randomized Trial Data Analysis" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06971" volume: 9 title: "snSMART: An R Package for Small Sample, Sequential, Multiple Assignment, Randomized Trial Data Analysis" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 2 months ago

🐘🐘🐘 πŸ‘‰ Toot for this paper πŸ‘ˆ 🐘🐘🐘

editorialbot commented 2 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5877
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06971
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! πŸŽ‰πŸŒˆπŸ¦„πŸ’ƒπŸ‘»πŸ€˜

Any issues? Notify your editorial technical team...

samhforbes commented 2 months ago

Congrats @sidiwang on a very nice package. Thanks to our reviewers @aghaynes, @ezraporter for taking the time, and of course to @osorensen for editing this submission.

editorialbot commented 2 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06971/status.svg)](https://doi.org/10.21105/joss.06971)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06971">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06971/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06971/status.svg
   :target: https://doi.org/10.21105/joss.06971

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: