[PRE REVIEW]: startinpy: A Python library for modelling and processing 2.5D triangulated terrains

[editorialbot]

Submitting author: !--author-handle-->@hugoledoux<!--end-author-handle-- (Hugo Ledoux) Repository: https://github.com/hugoledoux/startinpy Branch with paper.md (empty if default branch): Version: 0.11.0 Editor: !--editor-->@mikemahoney218<!--end-editor-- Reviewers: @weiji14, @kylemann16 Managing EiC: Kristen Thyng

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/eae73ba0c3b646cc562a010e58c5b7a5"><img src="https://joss.theoj.org/papers/eae73ba0c3b646cc562a010e58c5b7a5/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/eae73ba0c3b646cc562a010e58c5b7a5/status.svg)](https://joss.theoj.org/papers/eae73ba0c3b646cc562a010e58c5b7a5)

Author instructions

Thanks for submitting your paper to JOSS @hugoledoux. Currently, there isn't a JOSS editor assigned to your paper.

@hugoledoux if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/BFb0014497 is OK
- 10.1038/s41597-024-03091-9 is OK
- 10.1016/S0098-3004(03)00017-7 is OK
- 10.1142/S0218195905001580 is OK
- 10.1145/237218.237337 is OK
- 10.1145/235815.235821 is OK

MISSING DOIs

- No DOI given, and none found for title: A brief description of natural neighbour interpola...
- No DOI given, and none found for title: The non-Sibsonian interpolation: A new method of i...
- No DOI given, and none found for title: Fast polygonal approximation of terrain and height...

INVALID DOIs

- None

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (1762.8 files/s, 159064.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          26            182             93           1145
Rust                             1             62            418            901
Markdown                        12            275              0            778
YAML                             3             22              1            190
TeX                              1             19              0             82
TOML                             3             10              2             41
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            47            574            521           3146
-------------------------------------------------------------------------------

Commit count by author:

   392  Hugo Ledoux
    11  Ewout ter Hoeven
     1  Maarten Pronk

[editorialbot]

:warning: An error happened when generating the pdf. Author (Hugo Ledoux) is missing affiliation.

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 1932

✅ The paper includes a Statement of need section

[editorialbot]

License info:

✅ License found: MIT License (Valid open source OSI approved license)

[kthyng]

@hugoledoux Can you add your affiliation to the paper?

[hugoledoux]

@editorialbot generate pdf

[editorialbot]

:warning: An error happened when generating the pdf. Author (Hugo Ledoux) is missing affiliation.

[hugoledoux]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[editorialbot]

Five most similar historical JOSS papers:

SeismicMesh: Triangular meshing for seismology Submitting author: @krober10nd Handling editor: @meg-simula (Retired) Reviewers: @nschloe, @jorgensd Similarity score: 0.6465

TessPy: a python package for geographical tessellation Submitting author: @siavash-saki Handling editor: @martinfleis (Active) Reviewers: @jGaboardi, @BenjMy Similarity score: 0.6445

Efficient Polyhedral Gravity Modeling in Modern C++ and Python Submitting author: @schuhmaj Handling editor: @dfm (Active) Reviewers: @mikegrudic, @santisoler Similarity score: 0.6391

Ripser.py: A Lean Persistent Homology Library for Python Submitting author: @sauln Handling editor: @arokem (Retired) Reviewers: @lmcinnes Similarity score: 0.6317

Nanomesh: A Python workflow tool for generating meshes from image data Submitting author: @stefsmeets Handling editor: @prashjha (Active) Reviewers: @jameshgrn, @vijaysm Similarity score: 0.6257

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

[hugoledoux]

@kthyng okay fixed it. I was puzzled because the affiliation was there and I had successfully compiled it with the github action... but I wasn't using the latest v4 it seems, and things have changed. Mystery solved.

[kthyng]

Hi @hugoledoux and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:

• [x] OSI-approved license
• [x] Installation instructions
• [x] Documentation
• [x] Tests of some sort
• [x] Check paper (make sure compiles, read through, check for length 250-1000 words)
• [x] Substantial scholarly effort
• [x] Clear research application/in scope

In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them.

[hugoledoux]

5 suggested reviewers that seems to be a good fit, from the JOSS database: Anaphory ArcticSnow daniellivingston npucino weiji14

[kthyng]

Hi @hugoledoux! Two things:

• can you add a short statement in your summary or statement of need to clarify ties to research?
• please shorten the paper. I'd suggest either keeping the sections but shortening them (some of this is repetitive) or remove the implementation details and example (still try to tighten up the wording). We're trying to be better about keeping the papers shorter. Thanks!

[hugoledoux]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[editorialbot]

Five most similar historical JOSS papers:

3dfier: automatic reconstruction of 3D city models Submitting author: @hugoledoux Handling editor: @arfon (Active) Reviewers: @GANys, @chenkianwee Similarity score: 0.6987

DTCC Builder: A mesh generator for automatic, efficient, and robust mesh generation for large-scale city modeling and simulation Submitting author: @anderslogg Handling editor: @crvernon (Active) Reviewers: @ifthompson, @ipadjen Similarity score: 0.6930

lidar: A Python package for delineating nested surface depressions from digital elevation data Submitting author: @giswqs Handling editor: @kbarnhart (Retired) Reviewers: @laijingtao, @cheginit, @amanaster2 Similarity score: 0.6796

Ripser.py: A Lean Persistent Homology Library for Python Submitting author: @sauln Handling editor: @arokem (Retired) Reviewers: @lmcinnes Similarity score: 0.6718

fractopo: A Python package for fracture network analysis Submitting author: @nialov Handling editor: @elbeejay (Active) Reviewers: @dglaeser, @lachlangrose Similarity score: 0.6671

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

[hugoledoux]

@kthyng I have cut the paper in half, and moved the material to the docs online: https://startinpy.readthedocs.io/latest/

[kthyng]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[editorialbot]

Five most similar historical JOSS papers:

3dfier: automatic reconstruction of 3D city models Submitting author: @hugoledoux Handling editor: @arfon (Active) Reviewers: @GANys, @chenkianwee Similarity score: 0.6982

DTCC Builder: A mesh generator for automatic, efficient, and robust mesh generation for large-scale city modeling and simulation Submitting author: @anderslogg Handling editor: @crvernon (Active) Reviewers: @ifthompson, @ipadjen Similarity score: 0.6922

lidar: A Python package for delineating nested surface depressions from digital elevation data Submitting author: @giswqs Handling editor: @kbarnhart (Retired) Reviewers: @laijingtao, @cheginit, @amanaster2 Similarity score: 0.6791

Ripser.py: A Lean Persistent Homology Library for Python Submitting author: @sauln Handling editor: @arokem (Retired) Reviewers: @lmcinnes Similarity score: 0.6718

fractopo: A Python package for fracture network analysis Submitting author: @nialov Handling editor: @elbeejay (Active) Reviewers: @dglaeser, @lachlangrose Similarity score: 0.6669

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

[kthyng]

Ok thanks @hugoledoux. I'll add this to the waitlist while we wait for a relevant editor to have capacity. Thanks for your patience.

[kthyng]

@mikemahoney218 Can you edit this submission?

[kthyng]

@editorialbot invite @mikemahoney218 as editor

[editorialbot]

Invitation to edit this submission sent!

[mikemahoney218]

@editorialbot assign me as editor

[editorialbot]

Assigned! @mikemahoney218 is now the editor

[mikemahoney218]

Happy to take this one on! It's going to take me a little bit to start requesting reviews -- apologies, transitioning from a conference to a new position -- but I'll follow up as I hear back.

[mikemahoney218]

@weiji14 -- would you be willing to review a submission for the Journal of Open Source Software?

At JOSS, we carry out our checklist-driven reviews here in GitHub issues, encourage author-reviewer-editor conversations, and reviews involve downloading and installing the software, and inspecting the repository and submitted paper. See https://joss.readthedocs.io/en/latest/review_criteria.html for more about our review process.

Editors and reviewers post comments on the Review issue, and authors respond to the comments and improve their submission until acceptance (or withdrawal, if they feel unable to satisfy the review). We aim for the initial review to be completed within 4 weeks (which would bring us to September 9th), though we can of course be flexible as needed.

Would you be willing to review this submission for JOSS? If not, can you recommend any other potential reviewers?

[weiji14]

Oo nice, a maturin project, and working with LiDAR data! Yes I would be more than happy to review this. I will note that I'll be travelling for two weeks until 1st September, so there might be delays in finding time to review, but I'll let you know if I need more time beyond the 9th September date.

[mikemahoney218]

@editorialbot assign @weiji14 as reviewer

Fantastic, thank you so much! I'll formally start the review (and follow up with more details) when I get a second reviewer onboard 😄

[editorialbot]

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

[mikemahoney218]

@editorialbot add @weiji14 as reviewer

(apologies, I always mess that one up...)

[editorialbot]

@weiji14 added to the reviewers list!

[mikemahoney218]

Just for awareness here, I'm still searching for a second reviewer -- @hugoledoux , if you had additional ideas for who might be a good fit, that would be useful; otherwise I'll keep searching.

[evetion]

Given this PR, maybe @DanielVandH can review?

[hugoledoux]

or I think that anyone using terrains and Python is a suitable candidate here, so besides those I listed above I can think of LSDtopotools or martibosch

[mikemahoney218]

@editorialbot add @kylemann16 as reviewer

[editorialbot]

@kylemann16 added to the reviewers list!

[mikemahoney218]

@editorialbot start review

[editorialbot]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/7123.