openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
703 stars 36 forks source link

[PRE REVIEW]: CompressedBeliefMDPs.jl: A Julia Package for Solving Large POMDPs with Belief Compression #7011

Open editorialbot opened 1 month ago

editorialbot commented 1 month ago

Submitting author: !--author-handle-->@FlyingWorkshop<!--end-author-handle-- (Logan Bhamidipaty) Repository: https://github.com/JuliaPOMDP/CompressedBeliefMDPs.jl Branch with paper.md (empty if default branch): Version: v1.1.1 Editor: !--editor-->@bmcfee<!--end-editor-- Reviewers: !--reviewers-list-->@alcap23<!--end-reviewers-list-- Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/967acf3a5b70351313a995c12e03849b"><img src="https://joss.theoj.org/papers/967acf3a5b70351313a995c12e03849b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/967acf3a5b70351313a995c12e03849b/status.svg)](https://joss.theoj.org/papers/967acf3a5b70351313a995c12e03849b)

Author instructions

Thanks for submitting your paper to JOSS @FlyingWorkshop. Currently, there isn't a JOSS editor assigned to your paper.

@FlyingWorkshop if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 month ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 month ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (1460.6 files/s, 135224.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                           22            307            329           1297
Markdown                         7            157              0            436
TeX                              1             35              0            390
TOML                             3             72              1            314
YAML                             5              1              8            171
-------------------------------------------------------------------------------
SUM:                            38            572            338           2608
-------------------------------------------------------------------------------

Commit count by author:

   105  Logan Mondal Bhamidipaty
    29  Logan Bhamidipaty
     9  CompatHelper Julia
     5  dependabot[bot]
     1  Dylan Asmar
     1  Mykel Kochenderfer
editorialbot commented 1 month ago

Paper file info:

📄 Wordcount for paper.md is 1165

✅ The paper includes a Statement of need section

editorialbot commented 1 month ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 1 month ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1613/jair.1496 is OK
- 10.1016/S0004-3702(98)00023-X is OK
- 10.48550/arXiv.2304.09352 is OK
- 10.1038/s41598-019-47148-x is OK
- 10.1177/1729881421999587 is OK
- 10.1109/ICCVE45908.2019.8965237 is OK
- 10.1037/h0069792 is OK
- 10.1002/aic.690370209 is OK
- 10.48550/arXiv.1312.6114 is OK
- 10.48550/arXiv.1207.1412 is OK
- 10.1126/science.290.5500.2319 is OK
- 10.1145/361002.361007 is OK
- 10.48550/arXiv.1209.5145 is OK
- 10.15607/RSS.2008.IV.009 is OK
- 10.1613/jair.5328 is OK
- 10.1609/icaps.v28i1.13882 is OK
- 10.1007/11871842_29 is OK
- 10.7551/mitpress/1120.003.0084 is OK
- 10.1287/moor.12.3.441 is OK
- 10.1016/S0004-3702(02)00378-8 is OK
- 10.1037/e471672008-001 is OK
- 10.1037/h0070888 is OK
- 10.1162/089976698300017467 is OK
- 10.1111/1467-9868.00196 is OK
- 10.1016/B978-1-55860-377-6.50040-2 is OK
- 10.21105/joss.00602 is OK
- 10.1016/0022-247X(65)90154-X is OK

MISSING DOIs

- No DOI given, and none found for title: POMDPs.jl: a framework for sequential decision mak...
- No DOI given, and none found for title: Point-based value iteration: an anytime algorithm ...
- 10.1613/jair.1659 may be a valid DOI for title: Perseus: Randomized point-based value iteration fo...
- No DOI given, and none found for title: Algorithms for Decision Making
- No DOI given, and none found for title: Monte-Carlo planning in large POMDPs
- No DOI given, and none found for title: AEMS: An anytime online search algorithm for appro...
- No DOI given, and none found for title: E-PCA
- No DOI given, and none found for title: Multidimensional Triangulation and Interpolation f...

INVALID DOIs

- None
editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 month ago

Five most similar historical JOSS papers:

POMDPStressTesting.jl: Adaptive Stress Testing for Black-Box Systems Submitting author: @mossr Handling editor: @sbenthall (Active) Reviewers: @jarvist, @sambitdash Similarity score: 0.6590

EnsembleKalmanProcesses.jl: Derivative-free ensemble-based model calibration Submitting author: @odunbar Handling editor: @jbytecode (Active) Reviewers: @odow, @ziyiyin97 Similarity score: 0.6509

RxInfer: A Julia package for reactive real-time Bayesian inference Submitting author: @bvdmitri Handling editor: @jmschrei (Active) Reviewers: @dhvalden, @alstat Similarity score: 0.6505

A Julia package for bilevel optimization problems Submitting author: @matbesancon Handling editor: @poulson (Retired) Reviewers: @HaoZeke, @vissarion Similarity score: 0.6467

DynamicOED.jl: A Julia package for solving optimum experimental design problems Submitting author: @AlCap23 Handling editor: @diehlpk (Active) Reviewers: @KBodolai, @joshuaeh Similarity score: 0.6406

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

crvernon commented 1 month ago

Note: This was previously submitted and rejected here: https://github.com/openjournals/joss-reviews/issues/6673

The authors have made modifications to the codebase that now qualify this submission for consideration.

crvernon commented 1 month ago

@editorialbot invite @bmcfee as editor

:wave: @bmcfee - can you take this one on as editor? Thanks!

editorialbot commented 1 month ago

Invitation to edit this submission sent!

bmcfee commented 1 month ago

:wave: Sure, I can take this one. Note that I'm currently at a week-long seminar, but will be back in the office on Monday next week and can get on to the reviewer search.

crvernon commented 1 month ago

@editorialbot assign @bmcfee as editor

Thanks @bmcfee! Sounds good!

editorialbot commented 1 month ago

Assigned! @bmcfee is now the editor

FlyingWorkshop commented 1 month ago

Hi @bmcfee! Thanks for editing this paper. Here's a list of 5 reviewers I think would be well-suited to the paper:

  1. Sandesh Katakam: Has reinforcement learning (RL) experience and knows Julia.
  2. Lokesh Mohanty: Has RL experience. Doesn't list Julia as a language, but the syntax is similar enough to Python that I don't think it would be an issue.
  3. Mariana Meireles: Similarly has RL and Python experience, but doesn't list Julia.
  4. Lili Wu: Experience with decision-making, RL, and Python, but doesn't list Julia.
  5. Manuel Razo-Mejia: Lists Julia and has experience with machine learning (ML).

Happy to assist further if you'd like.

bmcfee commented 1 month ago

Thanks @FlyingWorkshop ! I've already been working on reviewer invitations and have one confirmed so far. I'll keep your suggestions in mind though.

bmcfee commented 1 month ago

@editorialbot add @alcap23 as reviewer

editorialbot commented 1 month ago

@alcap23 added to the reviewers list!

bmcfee commented 1 month ago

Note: reviewer @alcap23 will not be able to start immediately due to holidays

FlyingWorkshop commented 2 weeks ago

I added a minor patch to update some old dependencies, please refer to v1.1.2 instead of v1.1.1 @AlCap23, @bmcfee.

FlyingWorkshop commented 1 week ago

Thank you @AlCap23 and @bmcfee for agreeing to review our submission. I’m reaching out to PhD programs this coming month, so if there’s anything I can do to help expedite this review please let me know and I’d be happy to address them