openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[REVIEW]: densify: An R package to prune sparse data frames of typological linguistic data #7024

Closed editorialbot closed 1 month ago

editorialbot commented 3 months ago

Submitting author: !--author-handle-->@annagraff<!--end-author-handle-- (Anna Graff) Repository: https://github.com/annagraff/densify Branch with paper.md (empty if default branch): main Version: 1.0.0 Editor: !--editor-->@osorensen<!--end-editor-- Reviewers: @elenlefoll, @yjunechoe, @stefanocoretta Archive: 10.5281/zenodo.13384828

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e896a6a49ef4fd23d6b2c0c835f9954e"><img src="https://joss.theoj.org/papers/e896a6a49ef4fd23d6b2c0c835f9954e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e896a6a49ef4fd23d6b2c0c835f9954e/status.svg)](https://joss.theoj.org/papers/e896a6a49ef4fd23d6b2c0c835f9954e)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@elenlefoll, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @osorensen know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

πŸ“ Checklist for @elenlefoll

πŸ“ Checklist for @yjunechoe

πŸ“ Checklist for @stefanocoretta

editorialbot commented 2 months ago

Done! version is now 1.0.0

osorensen commented 2 months ago

@editorialbot set 10.5281/zenodo.13384828 as archive

editorialbot commented 2 months ago

Done! archive is now 10.5281/zenodo.13384828

osorensen commented 2 months ago

@editorialbot recommend-accept

editorialbot commented 2 months ago
Attempting dry run of processing paper acceptance...
editorialbot commented 2 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

βœ… OK DOIs

- 10.5281/zenodo.7385533 is OK
- 10.32614/cran.package.admmdensestsubmatrix is OK
- 10.32614/cran.package.fselector is OK
- 10.1093/bioinformatics/bty633 is OK
- 10.5281/zenodo.7976754 is OK
- 10.5281/zenodo.7836668 is OK
- 10.5281/zenodo.2677911 is OK
- 10.5281/zenodo.7740140 is OK
- 10.5281/zenodo.10804357 is OK
- 10.32614/cran.package.varrank is OK

🟑 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
editorialbot commented 2 months ago

:wave: @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5828, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

samhforbes commented 1 month ago

@editorialbot check references

editorialbot commented 1 month ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

βœ… OK DOIs

- 10.5281/zenodo.7385533 is OK
- 10.32614/cran.package.admmdensestsubmatrix is OK
- 10.32614/cran.package.fselector is OK
- 10.1093/bioinformatics/bty633 is OK
- 10.5281/zenodo.7976754 is OK
- 10.5281/zenodo.7836668 is OK
- 10.5281/zenodo.2677911 is OK
- 10.5281/zenodo.7740140 is OK
- 10.5281/zenodo.10804357 is OK
- 10.32614/cran.package.varrank is OK

🟑 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
samhforbes commented 1 month ago

@editorialbot accept

editorialbot commented 1 month ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 1 month ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Graff given-names: Anna orcid: "https://orcid.org/0000-0002-7703-3471" - family-names: Lischka given-names: Marc orcid: "https://orcid.org/0009-0007-9493-2392" - family-names: Zakharko given-names: Taras orcid: "https://orcid.org/0000-0001-7601-8424" - family-names: Furrer given-names: Reinhard orcid: "https://orcid.org/0000-0002-6319-2332" - family-names: Bickel given-names: Balthasar orcid: "https://orcid.org/0000-0002-9087-0565" contact: - family-names: Graff given-names: Anna orcid: "https://orcid.org/0000-0002-7703-3471" doi: 10.5281/zenodo.13384828 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Graff given-names: Anna orcid: "https://orcid.org/0000-0002-7703-3471" - family-names: Lischka given-names: Marc orcid: "https://orcid.org/0009-0007-9493-2392" - family-names: Zakharko given-names: Taras orcid: "https://orcid.org/0000-0001-7601-8424" - family-names: Furrer given-names: Reinhard orcid: "https://orcid.org/0000-0002-6319-2332" - family-names: Bickel given-names: Balthasar orcid: "https://orcid.org/0000-0002-9087-0565" date-published: 2024-09-06 doi: 10.21105/joss.07024 issn: 2475-9066 issue: 101 journal: Journal of Open Source Software publisher: name: Open Journals start: 7024 title: "densify: An R package to reduce empty cells in data frames of typological linguistic data" type: article url: "https://joss.theoj.org/papers/10.21105/joss.07024" volume: 9 title: "densify: An R package to reduce empty cells in data frames of typological linguistic data" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 month ago

🐘🐘🐘 πŸ‘‰ Toot for this paper πŸ‘ˆ 🐘🐘🐘

editorialbot commented 1 month ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5860
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.07024
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! πŸŽ‰πŸŒˆπŸ¦„πŸ’ƒπŸ‘»πŸ€˜

Any issues? Notify your editorial technical team...

samhforbes commented 1 month ago

Congrats @annagraff! Thank you to all of @elenlefoll, @yjunechoe, @stefanocoretta for taking the time to review, and also @osorensen for editing this submission

editorialbot commented 1 month ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.07024/status.svg)](https://doi.org/10.21105/joss.07024)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.07024">
  <img src="https://joss.theoj.org/papers/10.21105/joss.07024/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.07024/status.svg
   :target: https://doi.org/10.21105/joss.07024

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: