openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[PRE REVIEW]: osmapiR: An 'OpenStreetMap API' implementation for R #7036

Closed editorialbot closed 2 months ago

editorialbot commented 3 months ago

Submitting author: !--author-handle-->@jmaspons<!--end-author-handle-- (Joan Maspons) Repository: https://github.com/ropensci/osmapiR Branch with paper.md (empty if default branch): joss Version: v0.2.0 Editor: !--editor-->@arfon<!--end-editor-- Reviewers: @jonthegeek, @ccamara Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/eed311474b650ed64042431a537fbc35"><img src="https://joss.theoj.org/papers/eed311474b650ed64042431a537fbc35/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/eed311474b650ed64042431a537fbc35/status.svg)](https://joss.theoj.org/papers/eed311474b650ed64042431a537fbc35)

Author instructions

Thanks for submitting your paper to JOSS @jmaspons. Currently, there isn't a JOSS editor assigned to your paper.

@jmaspons if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 3 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 3 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.56 s (382.3 files/s, 459354.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               71           1523           4558         131563
XML                             89             32              0          88849
JSON                            31              3              0          25059
Markdown                        10            260              0           3214
SVG                              1             26              1           1104
YAML                             7             34             24            359
TeX                              1              7              0             75
Rmd                              4            110            302             45
-------------------------------------------------------------------------------
SUM:                           214           1995           4885         250268
-------------------------------------------------------------------------------

Commit count by author:

   308  Joan Maspons
     3  Carlos Cámara
     2  Maëlle Salmon
     1  Neal Richardson
editorialbot commented 3 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.32614/CRAN.package.osmapiR is OK
- 10.21105/joss.00305 is OK
- 10.32614/CRAN.package.osmextract is OK
- 10.32614/CRAN.package.OpenStreetMap is OK
- 10.32614/RJ-2018-009 is OK
- 10.32614/CRAN.package.xml2 is OK
- 10.32614/RJ-2019-041 is OK

MISSING DOIs

- No DOI given, and none found for title: R: A Language and Environment for Statistical Comp...

INVALID DOIs

- None
editorialbot commented 3 months ago

Paper file info:

📄 Wordcount for paper.md is 311

✅ The paper includes a Statement of need section

editorialbot commented 3 months ago

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

editorialbot commented 3 months ago

:warning: An error happened when generating the pdf.

arfon commented 3 months ago

@jmaspons - many thanks for your submission to JOSS. It looks like the paper isn't currently compiling, could you please take a look at this example paper https://joss.readthedocs.io/en/latest/example_paper.html for the exact formatting requirements and update your paper accordingly (both metadata/YAML but also the structure/content)?

jmaspons commented 3 months ago

Works with the gh action in my repo https://github.com/ropensci/osmapiR/actions/runs/10090439427

⚠️ An error happened when generating the pdf.

Seems a problem with the (lack of) affiliation. I will try to fix it

jmaspons commented 3 months ago

Seems related to https://github.com/openjournals/joss/issues/406. Hopefully fixed with the workaround

jmaspons commented 3 months ago

@editorialbot generate pdf

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 3 months ago

Five most similar historical JOSS papers:

OpenTripPlanner for R Submitting author: @mem48 Handling editor: @danielskatz (Active) Reviewers: @danielskatz Similarity score: 0.7265

PostcodesioR: An R package for UK geocoding Submitting author: @erzk Handling editor: @oliviaguest (Active) Reviewers: @oliviaguest Similarity score: 0.7095

osfr: An R Interface to the Open Science Framework Submitting author: @aaronwolen Handling editor: @kthyng (Active) Reviewers: @kthyng Similarity score: 0.7080

home2park: An R package to assess the spatial provision of urban parks Submitting author: @xp-song Handling editor: @martinfleis (Active) Reviewers: @aelissa, @nickbearman Similarity score: 0.6935

tidygeocoder: An R package for geocoding Submitting author: @jessecambon Handling editor: @elbeejay (Active) Reviewers: @cole-brokamp, @tsamsonov Similarity score: 0.6924

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

arfon commented 2 months ago

Related rOpenSci review here: https://github.com/ropensci/software-review/issues/633

arfon commented 2 months ago

@editorialbot assign me as editor

editorialbot commented 2 months ago

Assigned! @arfon is now the editor

arfon commented 2 months ago

@editorialbot add @jonthegeek as reviewer

editorialbot commented 2 months ago

@jonthegeek added to the reviewers list!

arfon commented 2 months ago

@editorialbot add @ccamara as reviewer

editorialbot commented 2 months ago

@ccamara added to the reviewers list!

arfon commented 2 months ago

:wave: @jonthegeek, @ccamara – there's no additional review work to do here, rather, we're crediting you for your efforts on the earlier rOpenSci review: https://github.com/ropensci/software-review/issues/633

arfon commented 2 months ago

@editorialbot start review

editorialbot commented 2 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/7151.