openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: RT-utils: A Minimal Python Library for RT-struct Manipulation #7056

Closed editorialbot closed 1 week ago

editorialbot commented 3 months ago

Submitting author: !--author-handle-->@qurit-frizi<!--end-author-handle-- (Fereshteh Yousefi Rizi) Repository: https://github.com/qurit/rt-utils Branch with paper.md (empty if default branch): development Version: V1.2.0 Editor: !--editor-->@adamltyson<!--end-editor-- Reviewers: @pchlap, @suyashkumar, @xtie97 Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/7eb925046a71e235658070b87ac1f301"><img src="https://joss.theoj.org/papers/7eb925046a71e235658070b87ac1f301/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/7eb925046a71e235658070b87ac1f301/status.svg)](https://joss.theoj.org/papers/7eb925046a71e235658070b87ac1f301)

Author instructions

Thanks for submitting your paper to JOSS @qurit-frizi. Currently, there isn't a JOSS editor assigned to your paper.

@qurit-frizi if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 3 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 3 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.02 s (990.1 files/s, 98130.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          13            294            130            925
Markdown                         2             58              0            203
TeX                              1              9              0            118
YAML                             2              7              2             38
-------------------------------------------------------------------------------
SUM:                            18            368            132           1284
-------------------------------------------------------------------------------

Commit count by author:

   119  Asim Shrestha
    27  Adam Watkins
     9  Adam
     8  Fereshteh Yousefirizi
     5  Zhack47
     4  ThomasBudd
     4  zhack47
     3  Adam Zyzik
     3  Pedro Esquinas
     2  Carlos F. Uribe
     2  Pedro
     2  Robin Hegering
     2  asim-shrestha
     2  igorhlx
     1  Maxence Larose
     1  Phillip Chlap
     1  Samuel Ouellet
     1  Tom Roberts
editorialbot commented 3 months ago

Paper file info:

📄 Wordcount for paper.md is 1723

✅ The paper includes a Statement of need section

editorialbot commented 3 months ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 3 months ago

:warning: An error happened when generating the pdf. Author (Arman Rahmim) is missing affiliation.

editorialbot commented 3 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1016/j.mri.2012.05.001 may be a valid DOI for title: 3D Slicer as an image computing platform for the Q...
- No DOI given, and none found for title: Project MONAI
- 10.1016/j.cmpb.2021.106236 may be a valid DOI for title: TorchIO: A Python library for efficient loading, p...
- 10.1016/j.prro.2021.02.003 may be a valid DOI for title: Simple Python Module for Conversions Between DICOM...
- 10.2139/ssrn.4251277 may be a valid DOI for title: PyRaDiSe: A Python package for DICOM-RT-based auto...
- 10.1038/s41598-023-41475-w may be a valid DOI for title: Sensitivity of standardised radiomics algorithms t...
- No DOI given, and none found for title: The Image Biomarker Standardization Initiative: St...
- No DOI given, and none found for title: Federated testing of AI techniques: Towards sharin...
- 10.1158/0008-5472.can-18-0125 may be a valid DOI for title: LIFEx: A Freeware for Radiomic Feature Calculation...

INVALID DOIs

- None
Kevin-Mattheus-Moerman commented 3 months ago

@editorialbot query scope

editorialbot commented 3 months ago

Submission flagged for editorial review.

Kevin-Mattheus-Moerman commented 3 months ago

@qurit-frizi Dear author, thanks for this submission. I am the AEiC on this track and here to help process the initial steps. Before we proceed, please can you have a look at the following points:

Note I have just added the query-scope label, to trigger a scope review by the editorial board. This is because of the relatively small size of the project. During this scope review we'll determine if the functionality offered is extensive enough and if the project conforms to our substantial scholarly effort criteria. The scope review should take about 2 weeks to complete.

Kevin-Mattheus-Moerman commented 2 months ago

@qurit-frizi :wave:

Kevin-Mattheus-Moerman commented 2 months ago

@qurit-frizi can you please respond to the above queries? It is important as an author that you respond to editor/reviewer queries in a timely manor. If we do not hear back by Friday August 30th we'll assume you are no longer interest and will proceed to reject this submission.

qurit-frizi commented 2 months ago

Sure I am addressing the mentioned issue. @Kevin-Mattheus-Moerman

qurit-frizi commented 2 months ago

@Kevin-Mattheus-Moerman I addressed the queries about the affiliation, and the DOI of the rereferences. This project includes automated testing.

qurit-frizi commented 1 month ago

@Kevin-Mattheus-Moerman CONTRIBUTING.md was now added to the readme in the development branch

Kevin-Mattheus-Moerman commented 1 month ago

@editorialbot generate pdf

editorialbot commented 1 month ago

:warning: An error happened when generating the pdf.

Kevin-Mattheus-Moerman commented 1 month ago

@editorialbot check references

editorialbot commented 1 month ago

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "doi" (NAME) ["@", #<BibTeX::Entry >, {:title=>["{3D} Slicer as an image computing platform for the Quantitative Imaging Network"], :author=>["Fedorov, Andriy and Beichel, Reinhard and Kalpathy-Cramer, Jayashree and Finet, Julien and Fillion-Robin, Jean-Christophe and Pujol, Sonia and Bauer, Christian and Jennings, Dominique and Fennessy, Fiona and Sonka, Milan and Buatti, John and Aylward, Stephen and Miller, James V and Pieper, Steve and Kikinis, Ron"], :journal=>["Magn. Reson. Imaging"], :publisher=>["Elsevier"], :volume=>"30", :number=>"9", :pages=>["1323--1341"], :month=>[:nov], :year=>"2012", :language=>["en"]}]
Kevin-Mattheus-Moerman commented 1 month ago

@qurit-frizi the above paper compilation error appears to relate to this .bib file error, and in particular your first reference to 3D slicer. Can you check your .bib file? Perhaps the dot at the end of this doi should be remove? i.e. doi = {10.1016/j.mri.2012.05.001.} should be doi = {10.1016/j.mri.2012.05.001}?

@openjournals/dev is this indeed the error? :point_up:

Kevin-Mattheus-Moerman commented 1 month ago

@qurit-frizi I have just removed the query-scope label as this submission as passed our initial scope check. Apologies that it took longer than usual. I will now proceed to find a handling editor for this submission.

Kevin-Mattheus-Moerman commented 1 month ago

@editorialbot invite @adamltyson as editor

editorialbot commented 1 month ago

Invitation to edit this submission sent!

Kevin-Mattheus-Moerman commented 1 month ago

@editorialbot invite @csoneson as editor

editorialbot commented 1 month ago

Invitation to edit this submission sent!

Kevin-Mattheus-Moerman commented 1 month ago

@csoneson just inviting you too since I think @adamltyson is at his max already in terms of handling submissions. Are you able to help as editor perhaps?

adamltyson commented 1 month ago

@Kevin-Mattheus-Moerman I can take this on. I think my other submissions will be in review for a while!

adamltyson commented 1 month ago

@editorialbot assign @adamltyson as editor

editorialbot commented 1 month ago

Assigned! @adamltyson is now the editor

adamltyson commented 1 month ago

Hi @qurit-frizi, I'll take over the submission from now on.

I won't start the review until the paper compiles properly. When you get the time, could you take a look at @Kevin-Mattheus-Moerman's comment above and see if this fixes the issue.

In the mean time, we may as well get started finding reviewers. Would you be able to recommend appropriate reviewers for this submission? You can use the list of potential reviewers to help. Please provide a list, but don't tag them (with @) so they aren't notified unnecessarily.

Thanks!

qurit-frizi commented 1 month ago

@adamltyson The appropriate reviewers could be: Astarakee, SimoneBendazzoli93, xtie97, AI-thecoder, Phillip Chlap, suyashkumar

qurit-frizi commented 1 month ago

@qurit-frizi the above paper compilation error appears to relate to this .bib file error, and in particular your first reference to 3D slicer. Can you check your .bib file? Perhaps the dot at the end of this doi should be remove? i.e. doi = {10.1016/j.mri.2012.05.001.} should be doi = {10.1016/j.mri.2012.05.001}?

@openjournals/dev is this indeed the error? ☝️

@adamltyson this issue is resolved.

adamltyson commented 1 month ago

@editorialbot generate pdf

adamltyson commented 1 month ago

@editorialbot check references

editorialbot commented 1 month ago

:warning: An error happened when generating the pdf.

editorialbot commented 1 month ago

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "doi" (NAME) ["@", #<BibTeX::Entry >, {:title=>["{3D} Slicer as an image computing platform for the Quantitative Imaging Network"], :author=>["Fedorov, Andriy and Beichel, Reinhard and Kalpathy-Cramer, Jayashree and Finet, Julien and Fillion-Robin, Jean-Christophe and Pujol, Sonia and Bauer, Christian and Jennings, Dominique and Fennessy, Fiona and Sonka, Milan and Buatti, John and Aylward, Stephen and Miller, James V and Pieper, Steve and Kikinis, Ron"], :journal=>["Magn. Reson. Imaging"], :publisher=>["Elsevier"], :volume=>"30", :number=>"9", :pages=>["1323--1341"], :month=>[:nov], :year=>"2012", :language=>["en"]}]
adamltyson commented 1 month ago

Hi @qurit-frizi,

The paper building is still failing. Taking a look at the bib file, some parts of each entry seem to be missing a comma at the end of the line (e.g. language in the 3D slicer entry). Could you correct these and we'll try again?

xuanxu commented 1 month ago

Merging this PR should fix the error

qurit-frizi commented 1 month ago

@adamltyson I think it is good now!

adamltyson commented 1 month ago

@editorialbot generate pdf

adamltyson commented 1 month ago

@editorialbot check references

editorialbot commented 1 month ago

Checking the BibTeX entries failed with the following error:

Lexical or syntactical errors: 

@ARTICLE{Rufenacht2023-astitle={PyRaDiSe}: A Python package for {DICOM}-{RT}-based auto-segmentation pipeline construction and {DICOM}-{RT} data conversion,author=R\{u}fenacht,EliasandKamath,AmithandSuter,YannickandPoel,RobertandErmi\
editorialbot commented 1 month ago

:warning: An error happened when generating the pdf.

adamltyson commented 1 month ago

Hi @qurit-frizi,

There still seems to be issues compiling the paper. Could you ensure that it compiles locally then we can try again here?

Thanks!

qurit-frizi commented 3 weeks ago

It was compiled correctly and worked. @adamltyson

adamltyson commented 3 weeks ago

@editorialbot generate pdf

editorialbot commented 3 weeks ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 3 weeks ago

Five most similar historical JOSS papers:

adrt: approximate discrete Radon transform for Python Submitting author: @karlotness Handling editor: @diehlpk (Active) Reviewers: @zhangjy-ge, @fruzsinaagocs Similarity score: 0.7007

CleanX: A Python library for data cleaning of large sets of radiology images Submitting author: @drcandacemakedamoore Handling editor: @cMadan (Retired) Reviewers: @henrykironde, @anki-xyz Similarity score: 0.6808

MRdataset : A unified and user-friendly interface to medical imaging datasets Submitting author: @sinhaharsh Handling editor: @mstimberg (Active) Reviewers: @htwangtw, @djmannion Similarity score: 0.6713

Pylinac: Image analysis for routine quality assurance in radiotherapy Submitting author: @jrkerns Handling editor: @kellyrowland (Active) Reviewers: @ProfLeao, @SimonBiggs Similarity score: 0.6600

Volume Segmantics: A Python Package for Semantic Segmentation of Volumetric Data Using Pre-trained PyTorch Deep Learning Models Submitting author: @OllyK Handling editor: @osorensen (Active) Reviewers: @jingpengw, @estenhl Similarity score: 0.6585

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

adamltyson commented 3 weeks ago

@editorialbot check references

editorialbot commented 3 weeks ago

Checking the BibTeX entries failed with the following error:

Lexical or syntactical errors: 

@ARTICLE{Rufenacht2023-astitle={PyRaDiSe}: A Python package for {DICOM}-{RT}-based auto-segmentation pipeline construction and {DICOM}-{RT} data conversion,author=R\{u}fenacht,EliasandKamath,AmithandSuter,YannickandPoel,RobertandErmi\
adamltyson commented 3 weeks ago

Thanks @qurit-frizi, the paper looks good now. Would you mind seeing if you can fix the one outstanding BibTeX issue? If you don't know where the problem lies, let me know and I'll see if someone from JOSS can help.