search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
703 stars 36 forks source link

[PRE REVIEW]: ASTE: An artificial solver testing environment for partitioned coupling with preCICE #7064

Closed editorialbot closed 2 weeks ago

editorialbot commented 1 month ago

Submitting author: !--author-handle-->@davidscn<!--end-author-handle-- (David Schneider) Repository: https://github.com/precice/aste Branch with paper.md (empty if default branch): paper Version: v3.2.0 Editor: !--editor-->@diehlpk<!--end-editor-- Reviewers: @asalmgren, @hverhelst Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/461395f81bcedd77828c4b44f53b7179"><img src="https://joss.theoj.org/papers/461395f81bcedd77828c4b44f53b7179/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/461395f81bcedd77828c4b44f53b7179/status.svg)](https://joss.theoj.org/papers/461395f81bcedd77828c4b44f53b7179)

Author instructions

Thanks for submitting your paper to JOSS @davidscn. Currently, there isn't a JOSS editor assigned to your paper.

@davidscn if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 month ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 month ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.11 s (933.2 files/s, 325065.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C/C++ Header                     8           3248           4216          17733
Python                          14            421            163           2512
JSON                             8              1              0           2086
C++                             15            266            109           1608
XML                             28            157             36           1583
Markdown                         4            122              0            359
YAML                             8              6             13            324
CMake                            2             40             64            150
TeX                              1             12              0            121
Bourne Shell                    13             41             30            100
make                             1              3              0              6
-------------------------------------------------------------------------------
SUM:                           102           4317           4631          26582
-------------------------------------------------------------------------------

Commit count by author:

   125  David Schneider
   117  Frédéric Simonis
   109  Florian Lindner
    67  Kursat Yurt
    56  Kürşat Yurt
    18  --global
    18  Frederic Simonis
     8  David Sommer
     7  Gerasimos Chourdakis
     6  Kursat_Yurt
     6  S0mmerD
     5  Kyle Davis
     4  Benjamin Uekermann
     4  Kursat
     4  dependabot[bot]
     3  Boris Martin
     1  Guillaume De Nayer
     1  Klaudius Scheufele
     1  timo-schrader
     1  uekerman
editorialbot commented 1 month ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.12688/openreseurope.14445.2 is OK
- 10.3390/a14060166 is OK
- 10.18419/darus-4167 is OK
- 10.18419/opus-10581 is OK
- 10.1002/nme.2579 is OK

MISSING DOIs

- 10.23967/c.coupled.2023.016 may be a valid DOI for title: Data-parallel radial-basis-function interpolation ...
- No DOI given, and none found for title: Robust and Efficient Barycentric Cell-Interpolatio...
- No DOI given, and none found for title: Second-order projection-based mapping methods for ...
- No DOI given, and none found for title: The Visualization Toolkit (4th ed.)
- 10.1007/978-3-030-47956-5_10 may be a valid DOI for title: ExaFSA: Parallel Fluid-Structure-Acoustic Simulati...
- No DOI given, and none found for title: MeTis: Unstructured Graph Partitioning and Sparse ...
- No DOI given, and none found for title: JSON for Modern C++

INVALID DOIs

- None
editorialbot commented 1 month ago

Paper file info:

📄 Wordcount for paper.md is 1133

✅ The paper includes a Statement of need section

editorialbot commented 1 month ago

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 month ago

Five most similar historical JOSS papers:

Micro Manager: a Python package for adaptive and flexible two-scale coupling Submitting author: @IshaanDesai Handling editor: @philipcardiff (Active) Reviewers: @mayrmt, @mrogowski, @mbkumar Similarity score: 0.7310

Akantu: an HPC finite-element library for contact and dynamic fracture simulations Submitting author: @nrichart Handling editor: @diehlpk (Active) Reviewers: @vijaysm, @chennachaos Similarity score: 0.7185

DMStag: Staggered, Structured Grids for PETSc Submitting author: @psanan Handling editor: @kyleniemeyer (Active) Reviewers: @elauksap, @mbarzegary Similarity score: 0.7119

ogs6py and VTUinterface: streamlining OpenGeoSys workflows in Python Submitting author: @joergbuchwald Handling editor: @leouieda (Retired) Reviewers: @cpgr, @TobbeTripitaka, @akaszynski Similarity score: 0.7108

AMReX: a framework for block-structured adaptive mesh refinement Submitting author: @asalmgren Handling editor: @kyleniemeyer (Active) Reviewers: @MatthewTurk, @RemiLehe, @cmsquared Similarity score: 0.7070

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

danielskatz commented 1 month ago

@davidscn - thanks for your submission. While I look for an editor, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

danielskatz commented 1 month ago

👋 @diehlpk - would you be willing to edit this submission?

danielskatz commented 1 month ago

@editorialbot invite @diehlpk as editor

editorialbot commented 1 month ago

Invitation to edit this submission sent!

diehlpk commented 1 month ago

@danielskatz yes, I can do it but only can start in the second week of August.

diehlpk commented 1 month ago

@editorialbot add @diehlpk as reviewer

editorialbot commented 1 month ago

Can't add reviewers: There is no editor assigned yet

danielskatz commented 1 month ago

@editorialbot add @diehlpk as editor

Thanks!

editorialbot commented 1 month ago

Assigned! @diehlpk is now the editor

davidscn commented 1 month ago

@editorialbot check references

editorialbot commented 1 month ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.12688/openreseurope.14445.2 is OK
- 10.3390/a14060166 is OK
- 10.18419/darus-4167 is OK
- 10.23967/c.coupled.2023.016 is OK
- 10.18419/opus-12128 is OK
- 10.18419/opus-10581 is OK
- 10.1007/978-3-030-47956-5_10 is OK
- 10.1002/nme.2579 is OK

MISSING DOIs

- No DOI given, and none found for title: Robust and Efficient Barycentric Cell-Interpolatio...
- No DOI given, and none found for title: The Visualization Toolkit (4th ed.)
- No DOI given, and none found for title: MeTis: Unstructured Graph Partitioning and Sparse ...
- No DOI given, and none found for title: JSON for Modern C++

INVALID DOIs

- None
davidscn commented 1 month ago

@editorialbot generate pdf

I added now missing DOIs where possible. For the remaining entries, there are at most URLs given and no DOIs available. If that's a problem, I would consider to embed the mentioned URL into the plain text rather than making it a full citation.

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

diehlpk commented 1 month ago

@IshaanDesai do you have time to review this paper?

diehlpk commented 1 month ago

Hi @psanan do you have time to review this paper?

diehlpk commented 1 month ago

Hi @asalmgren do you have time to review this paper?

IshaanDesai commented 4 weeks ago

@diehlpk I work in the same research group as the authors of this paper. If this is a conflict of interest, then I am not a good fit here. If this is not an issue, I am happy to be a reviewer.

diehlpk commented 3 weeks ago

@IshaanDesai that would be COI. Would you mind suggestion other reviewers?

diehlpk commented 3 weeks ago

@davidscn could you please recommend some potential reviewers?

asalmgren commented 3 weeks ago

Realistically I couldn't get to it until October.

On Fri, Aug 9, 2024 at 9:12 AM Patrick Diehl @.***> wrote:

Hi @asalmgren https://github.com/asalmgren do you have time to review this paper?

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/7064#issuecomment-2278292858, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACRE6YVU2MP7MBII5YSX6H3ZQTS5PAVCNFSM6AAAAABL22Y3HOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZYGI4TEOBVHA . You are receiving this because you were mentioned.Message ID: @.***>

-- Ann Almgren Senior Scientist; Dept. Head, Applied Mathematics Pronouns: she/her/hers

diehlpk commented 3 weeks ago

@asalmgren That would not be any problem.

diehlpk commented 3 weeks ago

@editorialbot add @asalmgren as reviewer

editorialbot commented 3 weeks ago

@asalmgren added to the reviewers list!

davidscn commented 3 weeks ago

@davidscn could you please recommend some potential reviewers?

Not entirely sure about the prerequisites to be a reviewer. Of course, we could suggest again the reviewers from https://github.com/openjournals/joss-reviews/issues/5842, as they are somewhat familiar with the preCICE-verse and JOSS. Other than that I could maybe suggest @hverhelst or @antRthorn. Would that comply with the JOSS formalities?

diehlpk commented 2 weeks ago

HI @hverhelst do you have time to review this paper?

diehlpk commented 2 weeks ago

Hi @antRthorn do you have time to review this paper?

diehlpk commented 2 weeks ago

Hi @IshaanDesai do you have time to review this paper?

hverhelst commented 2 weeks ago

Hi @diehlpk, thanks for the invite! I have time from the first week of September onwards, is that OK?

IshaanDesai commented 2 weeks ago

Hi @IshaanDesai do you have time to review this paper?

Due to the clear conflict of interest that we previously discussed, I have to decline here.

diehlpk commented 2 weeks ago

@editorialbot add @hverhelst as reviewer

editorialbot commented 2 weeks ago

@hverhelst added to the reviewers list!

diehlpk commented 2 weeks ago

@editorialbot start review

editorialbot commented 2 weeks ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/7127.