openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: ISL: A Julia package for training Implicit Generative Models via an Invariant Statistical Loss #7077

Closed editorialbot closed 2 months ago

editorialbot commented 3 months ago

Submitting author: !--author-handle-->@https://github.com/josemanuel22<!--end-author-handle-- (José Manuel de Frutos) Repository: https://github.com/josemanuel22/ISL Branch with paper.md (empty if default branch): Version: v0.1.0 Editor: !--editor-->@bmcfee<!--end-editor-- Reviewers: @ziyiyin97, @odunbar Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/4e31b0263f7fe7dd7e6d5f0d3d1b0db7"><img src="https://joss.theoj.org/papers/4e31b0263f7fe7dd7e6d5f0d3d1b0db7/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/4e31b0263f7fe7dd7e6d5f0d3d1b0db7/status.svg)](https://joss.theoj.org/papers/4e31b0263f7fe7dd7e6d5f0d3d1b0db7)

Author instructions

Thanks for submitting your paper to JOSS @https://github.com/josemanuel22. Currently, there isn't a JOSS editor assigned to your paper.

@https://github.com/josemanuel22 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 3 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 3 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.07 s (497.5 files/s, 317267.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSV                              1              0              0          17421
Julia                           18            752           1095           3027
Markdown                         6            172              0            479
TeX                              1             53              0            387
YAML                             6              8              9            123
TOML                             4              4              0             47
SVG                              1              0              1             20
-------------------------------------------------------------------------------
SUM:                            37            989           1105          21504
-------------------------------------------------------------------------------

Commit count by author:

   329  josemanuel22
    33  José Manuel de Frutos
    21  José Manuel Frutos
editorialbot commented 3 months ago

Paper file info:

📄 Wordcount for paper.md is 1031

✅ The paper includes a Statement of need section

editorialbot commented 3 months ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 3 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1080/00031305.2017.1380080 is OK

MISSING DOIs

- No DOI given, and none found for title: On the performance of particle filters with adapti...
- No DOI given, and none found for title: Enhancing the Locality and Breaking the Memory Bot...
- 10.1109/tsp.2016.2637324 may be a valid DOI for title: Adapting the number of particles in sequential Mon...
- 10.1109/icassp.2016.7472504 may be a valid DOI for title: Online adaptation of the number of particles of SM...
- No DOI given, and none found for title: GAN connoisseur: Can GANs learn simple 1D parametr...
- No DOI given, and none found for title: Generative adversarial nets
- No DOI given, and none found for title: Generalization and equilibrium in generative adver...
- No DOI given, and none found for title: Wasserstein generative adversarial networks
- No DOI given, and none found for title: MMD GAN: Towards deeper understanding of moment ma...
- No DOI given, and none found for title: Do GANs actually learn the distribution? an empiri...
- 10.1109/iccv.2019.00456 may be a valid DOI for title: Learning implicit generative models by matching pe...
- No DOI given, and none found for title: Probability and Measure
- No DOI given, and none found for title: f-GAN: Training generative neural samplers using v...
- No DOI given, and none found for title: Adversarial variational bayes: Unifying variationa...
- No DOI given, and none found for title: Generative moment matching networks
- No DOI given, and none found for title: A kernel two-sample test
- No DOI given, and none found for title: Function-space inference with sparse implicit proc...
- 10.1214/aoms/1177729394 may be a valid DOI for title: Remarks on a multivariate transformation
- No DOI given, and none found for title: Probabilistic time series forecasting with implici...
- No DOI given, and none found for title: Multivariate Probabilistic Time Series Forecasting...
- No DOI given, and none found for title: Deep State Space Models for Time Series Forecastin...
- No DOI given, and none found for title: Temporal Regularized Matrix Factorization for High...
- No DOI given, and none found for title: Time Series Analysis: Forecasting and Control, 5th...
- No DOI given, and none found for title: Autoregressive Denoising Diffusion Models for Mult...
- No DOI given, and none found for title: Do GANs learn the distribution? some theory and em...
- No DOI given, and none found for title: Deep autoregressive models with spectral attention
- No DOI given, and none found for title: Training generative neural networks via maximum me...
- No DOI given, and none found for title: Nonparametric density estimation & convergence rat...
- 10.1016/j.ijforecast.2019.07.001 may be a valid DOI for title: DeepAR: Probabilistic forecasting with autoregress...
- No DOI given, and none found for title: ElectricityLoadDiagrams20112014
- No DOI given, and none found for title: Enhancing the locality and breaking the memory bot...
- 10.1109/tsp.2010.2053707 may be a valid DOI for title: Assessment of nonlinear dynamic models by Kolmogor...
- No DOI given, and none found for title: Independent random sampling methods
- No DOI given, and none found for title: Adam: A method for stochastic optimization
- No DOI given, and none found for title: Improved techniques for training GANs
- No DOI given, and none found for title: Spectral normalization for generative adversarial ...
- No DOI given, and none found for title: Learning in implicit generative models
- No DOI given, and none found for title: 30 Years of European Wind Generation
- No DOI given, and none found for title: Gluonts: Probabilistic and neural time series mode...
- 10.1609/aaai.v35i12.17325 may be a valid DOI for title: Informer: Beyond efficient transformer for long se...
- No DOI given, and none found for title: Autoformer: Decomposition transformers with auto-c...
- 10.1609/aaai.v37i9.26317 may be a valid DOI for title: Are transformers effective for time series forecas...
- 10.1109/cvpr.2018.00367 may be a valid DOI for title: Generative modeling using the sliced wasserstein d...
- No DOI given, and none found for title: On the measure of Voronoi cells
- No DOI given, and none found for title: Understanding and contextualising diffusion models
- No DOI given, and none found for title: Training Implicit Generative Models via an Invaria...

INVALID DOIs

- None
editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 3 months ago

Five most similar historical JOSS papers:

GaussianRandomFields.jl: A Julia package to generate and sample from Gaussian random fields Submitting author: @PieterjanRobbe Handling editor: @jbytecode (Active) Reviewers: @ziyiyin97, @shahmoradi Similarity score: 0.7114

Surjectors: surjection layers for density estimation with normalizing flows Submitting author: @dirmeier Handling editor: @arfon (Active) Reviewers: @sandeshkatakam, @animikhaich Similarity score: 0.6960

RxInfer: A Julia package for reactive real-time Bayesian inference Submitting author: @bvdmitri Handling editor: @jmschrei (Active) Reviewers: @dhvalden, @alstat Similarity score: 0.6939

BlackBIRDS: Black-Box Inference foR Differentiable Simulators Submitting author: @arnauqb Handling editor: @rkurchin (Active) Reviewers: @rajeshrinet, @marvinschmitt Similarity score: 0.6919

IndividualDisplacements.jl: a Julia package to simulate and study particle displacements within the climate system Submitting author: @gaelforget Handling editor: @kthyng (Active) Reviewers: @milankl, @visr Similarity score: 0.6915

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

crvernon commented 3 months ago

@editorialbot invite @bmcfee as editor

:wave: @bmcfee - can you take this one on as editor?

editorialbot commented 3 months ago

Invitation to edit this submission sent!

bmcfee commented 3 months ago

Sure, i can edit this one. I'm currently traveling, but will be back in the office on Friday and can get on with the reviewer search.

danielskatz commented 3 months ago

@editorialbot assign @bmcfee as editor

(you can do this yourself, too)

editorialbot commented 3 months ago

Assigned! @bmcfee is now the editor

bmcfee commented 3 months ago

Back at a proper keyboard now and not trying to wrangle github responses with a toddler in hand. :) Reviewer invitations are flying through the ether now.

@josemanuel22 while we're working on finding reviewers, it would be helpful if you could fix the references section for the paper. Reviewers will ask for / need this anyway, so we may as well get out ahead of it.

bmcfee commented 3 months ago

@editorialbot add @ziyiyin97 as reviewer

editorialbot commented 3 months ago

@ziyiyin97 added to the reviewers list!

josemanuel22 commented 3 months ago

Back at a proper keyboard now and not trying to wrangle github responses with a toddler in hand. :) Reviewer invitations are flying through the ether now.

@josemanuel22 while we're working on finding reviewers, it would be helpful if you could fix the references section for the paper. Reviewers will ask for / need this anyway, so we may as well get out ahead of it.

I apologize for the delay; for some reason, I didn't receive the ping on GitHub. OK, I'll do it.

josemanuel22 commented 2 months ago

@bmcfee I'm sorry to bother you; this is the first time I've submitted something to JOSS. What is the current status of this?

crvernon commented 2 months ago

@bmcfee - what is you status on getting another review assigned and getting this one kicked off into full review?

bmcfee commented 2 months ago

Still working on getting a second reviewer (been sidelined with beginning of school year onslaught this week!) - hoping to have it moving within the next few days.

bmcfee commented 2 months ago

@editorialbot add @odunbar as reviewer

editorialbot commented 2 months ago

@odunbar added to the reviewers list!

bmcfee commented 2 months ago

@editorialbot start review

editorialbot commented 2 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/7272.