search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
707 stars 37 forks source link

[PRE REVIEW]: Mango.jl: A Julia-Based Multi-Agent Simulation Framework #7083

Closed editorialbot closed 1 month ago

editorialbot commented 1 month ago

Submitting author: !--author-handle-->@jsagerOffis<!--end-author-handle-- (Jens Sager) Repository: https://github.com/OFFIS-DAI/Mango.jl Branch with paper.md (empty if default branch): joss_paper Version: v0.3.0 Editor: !--editor-->@jbytecode<!--end-editor-- Reviewers: @aurorarossi, @Tortar Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0a7712eccc9ba5ccb2276d4f19c8f439"><img src="https://joss.theoj.org/papers/0a7712eccc9ba5ccb2276d4f19c8f439/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0a7712eccc9ba5ccb2276d4f19c8f439/status.svg)](https://joss.theoj.org/papers/0a7712eccc9ba5ccb2276d4f19c8f439)

Author instructions

Thanks for submitting your paper to JOSS @jsagerOffis. Currently, there isn't a JOSS editor assigned to your paper.

@jsagerOffis if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 month ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 month ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (1318.0 files/s, 142463.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                           28            716            616           2692
Markdown                        16            397              0            992
YAML                             6             17              8            162
TeX                              1             16              0            158
SVG                              2              0              0            130
TOML                             2              5              0             36
-------------------------------------------------------------------------------
SUM:                            55           1151            624           4170
-------------------------------------------------------------------------------

Commit count by author:

   130  Rico Schrage
    56  Jens Sager
     8  Jan-Hoerding
editorialbot commented 1 month ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/s41109-023-00553-8 is OK
- 10.1186/s42162-022-00209-4 is OK
- 10.1145/3447555.3465415 is OK
- 10.15439/2021F60 is OK
- 10.1177/00375497211068820 is OK
- 10.1145/375735.376120 is OK

MISSING DOIs

- 10.1016/j.softx.2024.101791 may be a valid DOI for title: mango: A modular python-based agent simulation fra...
- No DOI given, and none found for title: Artificial intelligence a modern approach
- No DOI given, and none found for title: A survey of distributed optimization
- No DOI given, and none found for title: Multi-agent deep reinforcement learning: a survey
- 10.1561/9781680835830 may be a valid DOI for title: On the control of multi-agent systems: A survey
- No DOI given, and none found for title: Netlogo: A simple environment for modeling complex...
- No DOI given, and none found for title: Utilizing Python for Agent-Based Modeling: The Mes...
- No DOI given, and none found for title: JIAC V: A MAS framework for industrial application...
- 10.1007/0-387-26350-0_7 may be a valid DOI for title: JACK™ intelligent agents: an industrial strength p...
- No DOI given, and none found for title: agentframework (2.0.1) [last access 13-11-2023]

INVALID DOIs

- None
editorialbot commented 1 month ago

Paper file info:

📄 Wordcount for paper.md is 1080

✅ The paper includes a Statement of need section

editorialbot commented 1 month ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 month ago

Five most similar historical JOSS papers:

FAME-Core: An open Framework for distributed Agent-based Modelling of Energy systems Submitting author: @KriNiTi Handling editor: @fraukewiese (Active) Reviewers: @xtruan, @pgranato Similarity score: 0.7179

AgentPy: A package for agent-based modeling in Python Submitting author: @JoelForamitti Handling editor: @sbenthall (Active) Reviewers: @jamesdamillington, @martibosch Similarity score: 0.7150

Abmarl: Connecting Agent-Based Simulations with Multi-Agent Reinforcement Learning Submitting author: @rusu24edward Handling editor: @drvinceknight (Active) Reviewers: @seba-1511, @abhiramm7 Similarity score: 0.6885

AMIRIS: Agent-based Market model for the Investigation of Renewable and Integrated energy Systems Submitting author: @KriNiTi Handling editor: @fraukewiese (Active) Reviewers: @sebastianboblest, @imcatta Similarity score: 0.6620

EvoDynamics.jl: a framework for modeling eco-evolutionary dynamics Submitting author: @kavir1698 Handling editor: @mikldk (Retired) Reviewers: @slwu89, @tijeco Similarity score: 0.6612

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

danielskatz commented 1 month ago

👋 @jsagerOffis - Thanks for your submission. While I look for an editor, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

danielskatz commented 1 month ago

👋 @fraukewiese & @jbytecode - I know both of you are currently at your editing limits, but I wanted to see if this might be of interest to either of you to edit (based on the energy/Julia aspects respectively); perhaps you are almost done with a current assignment... If neither of you are able to handle it, which is perfectly fine, I will take it.

jbytecode commented 1 month ago

I am always happy with Julia submissions, count me in

jsagerOffis commented 1 month ago

@editorialbot check references

editorialbot commented 1 month ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.softx.2024.101791 is OK
- 10.1007/s41109-023-00553-8 is OK
- 10.1186/s42162-022-00209-4 is OK
- 10.1145/3447555.3465415 is OK
- 10.15439/2021F60 is OK
- 10.1561/2600000019 is OK
- 10.1177/00375497211068820 is OK
- 10.1007/978-3-030-61255-9_30 is OK
- 10.1145/375735.376120 is OK
- 10.1007/0-387-26350-0_7 is OK

MISSING DOIs

- No DOI given, and none found for title: Artificial intelligence a modern approach
- No DOI given, and none found for title: Netlogo: A simple environment for modeling complex...
- No DOI given, and none found for title: JIAC V: A MAS framework for industrial application...
- No DOI given, and none found for title: agentframework (2.0.1) [last access 07-08-2024]

INVALID DOIs

- https://doi.org/10.1016/j.arcontrol.2019.05.006 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1007/s10462-021-09996-w is INVALID because of 'https://doi.org/' prefix
danielskatz commented 1 month ago

@editorialbot assign @jbytecode as editor

I am always happy with Julia submissions, count me in

Thanks!!

editorialbot commented 1 month ago

Assigned! @jbytecode is now the editor

jsagerOffis commented 1 month ago

Hi, I just realize it would have been smarter to assign the joss_paper branch to the submission to make these edits easier. Is there a way to set this branch at this point?

jsagerOffis commented 1 month ago

@editorialbot check references

editorialbot commented 1 month ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.softx.2024.101791 is OK
- 10.1007/s41109-023-00553-8 is OK
- 10.1186/s42162-022-00209-4 is OK
- 10.1145/3447555.3465415 is OK
- 10.15439/2021F60 is OK
- 10.1016/j.arcontrol.2019.05.006 is OK
- 10.1007/s10462-021-09996-w is OK
- 10.1561/2600000019 is OK
- 10.1177/00375497211068820 is OK
- 10.1007/978-3-030-61255-9_30 is OK
- 10.1145/375735.376120 is OK
- 10.1007/0-387-26350-0_7 is OK

MISSING DOIs

- No DOI given, and none found for title: Artificial intelligence a modern approach
- No DOI given, and none found for title: Netlogo: A simple environment for modeling complex...
- No DOI given, and none found for title: JIAC V: A MAS framework for industrial application...
- No DOI given, and none found for title: agentframework (2.0.1) [last access 07-08-2024]

INVALID DOIs

- None
jsagerOffis commented 1 month ago

@editorialbot generate pdf

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 month ago

Five most similar historical JOSS papers:

FAME-Core: An open Framework for distributed Agent-based Modelling of Energy systems Submitting author: @KriNiTi Handling editor: @fraukewiese (Active) Reviewers: @xtruan, @pgranato Similarity score: 0.7196

AgentPy: A package for agent-based modeling in Python Submitting author: @JoelForamitti Handling editor: @sbenthall (Active) Reviewers: @jamesdamillington, @martibosch Similarity score: 0.7167

Abmarl: Connecting Agent-Based Simulations with Multi-Agent Reinforcement Learning Submitting author: @rusu24edward Handling editor: @drvinceknight (Active) Reviewers: @seba-1511, @abhiramm7 Similarity score: 0.6892

AMIRIS: Agent-based Market model for the Investigation of Renewable and Integrated energy Systems Submitting author: @KriNiTi Handling editor: @fraukewiese (Active) Reviewers: @sebastianboblest, @imcatta Similarity score: 0.6659

EvoDynamics.jl: a framework for modeling eco-evolutionary dynamics Submitting author: @kavir1698 Handling editor: @mikldk (Retired) Reviewers: @slwu89, @tijeco Similarity score: 0.6630

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

jbytecode commented 1 month ago

@jsagerOffis - Hi, I am the handling editor.

Yes, you can change the branch of the paper. Please create the new branch and carry the manuscript and supplementary files into the new branch. Please ping me when you've done with it.

jbytecode commented 1 month ago

@jsagerOffis - Would you consider citing Julia in its first use?

Here is the bibtex entry:

@article{julia,
  doi       = {10.1137/141000671},
  url       = {https://doi.org/10.1137%2F141000671},
  year      = 2017,
  month     = {jan},
  publisher = {Society for Industrial {\&} Applied Mathematics ({SIAM})},
  volume    = {59},
  number    = {1},
  pages     = {65--98},
  author    = {Jeff Bezanson and Alan Edelman and Stefan Karpinski and Viral B. Shah},
  title     = {Julia: A Fresh Approach to Numerical Computing},
  journal   = {{SIAM} Review}
}
jsagerOffis commented 1 month ago

@jbytecode The paper is on the joss_paper branch and the correct 0.3.0 state of the software is now also merged to that branch.

I have also added the julia reference to the manuscript.

jbytecode commented 1 month ago

@editorialbot set joss_paper as branch

editorialbot commented 1 month ago

Done! branch is now joss_paper

jbytecode commented 1 month ago

@editorialbot check references

editorialbot commented 1 month ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.softx.2024.101791 is OK
- 10.1007/s41109-023-00553-8 is OK
- 10.1186/s42162-022-00209-4 is OK
- 10.1145/3447555.3465415 is OK
- 10.15439/2021F60 is OK
- 10.1016/j.arcontrol.2019.05.006 is OK
- 10.1007/s10462-021-09996-w is OK
- 10.1561/2600000019 is OK
- 10.1177/00375497211068820 is OK
- 10.1007/978-3-030-61255-9_30 is OK
- 10.1145/375735.376120 is OK
- 10.1007/0-387-26350-0_7 is OK
- 10.1137/141000671 is OK

MISSING DOIs

- No DOI given, and none found for title: Artificial intelligence a modern approach
- No DOI given, and none found for title: Netlogo: A simple environment for modeling complex...
- No DOI given, and none found for title: JIAC V: A MAS framework for industrial application...
- No DOI given, and none found for title: agentframework (2.0.1) [last access 07-08-2024]

INVALID DOIs

- None
jbytecode commented 1 month ago

@jsagerOffis - Have you performed a CrossRef search for the citations with missing DOIs?

jbytecode commented 1 month ago

@editorialbot generate pdf

jsagerOffis commented 1 month ago

@jsagerOffis - Have you performed a CrossRef search for the citations with missing DOIs?

Yes, I have added DOIs to all references where I could find one.

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 month ago

Five most similar historical JOSS papers:

FAME-Core: An open Framework for distributed Agent-based Modelling of Energy systems Submitting author: @KriNiTi Handling editor: @fraukewiese (Active) Reviewers: @xtruan, @pgranato Similarity score: 0.7200

AgentPy: A package for agent-based modeling in Python Submitting author: @JoelForamitti Handling editor: @sbenthall (Active) Reviewers: @jamesdamillington, @martibosch Similarity score: 0.7146

Abmarl: Connecting Agent-Based Simulations with Multi-Agent Reinforcement Learning Submitting author: @rusu24edward Handling editor: @drvinceknight (Active) Reviewers: @seba-1511, @abhiramm7 Similarity score: 0.6891

WorldDynamics.jl: A Julia Package for Developing and Simulating Integrated Assessment Models Submitting author: @aurorarossi Handling editor: @fraukewiese (Active) Reviewers: @ranocha, @StanczakDominik, @miguelraz Similarity score: 0.6665

EvoDynamics.jl: a framework for modeling eco-evolutionary dynamics Submitting author: @kavir1698 Handling editor: @mikldk (Retired) Reviewers: @slwu89, @tijeco Similarity score: 0.6614

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

jbytecode commented 1 month ago

@jsagerOffis - I tested the package, works well. Package is also registered in JuliaHub. However, I failed to see an instruction in README.md on how to install and get the whole stuff ready. Could you please add? Thank you in advance.

Now, our system suggests us some suitable and potential reviewers. I will investigate their submissions and pick them to invite.

Before sending invitations, I want to ask you if you have suggestions for potential reviewers.

jsagerOffis commented 1 month ago

@jbytecode I have no suggestions for reviewers and have just added installation instructions to the README.md

jbytecode commented 1 month ago

👋👋👋 Dear @KriNiTi, @rusu24edward, @aurorarossi 👋👋👋

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled:

[PRE REVIEW]: Mango.jl: A Julia-Based Multi-Agent Simulation Framework

You can find more information at the top of this Github issue (LINK).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be nearly 20 check items for each single reviewer.

Thank you in advance!

KriNiTi commented 1 month ago

Dear @jbytecode, Thank you very much for the invitation to review this very interesting project! Unfortunately, me and my team do not have any experience with Julia at all. Thus, I have to politely decline. Kind regards, Kristina

jbytecode commented 1 month ago

@KriNiTi - Thank you for the quick response!

aurorarossi commented 1 month ago

@jbytecode Yes, I am available to review this work.

jbytecode commented 1 month ago

@editorialbot add @aurorarossi as reviewer

@aurorarossi - thank you for accepting our invitation. Whenever we set at least two reviewers, the review will start in a saparate thread. I will provide the instructions there.

editorialbot commented 1 month ago

@aurorarossi added to the reviewers list!

jbytecode commented 1 month ago

👋👋👋 Dear @kavir1698 👋👋👋

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled:

[PRE REVIEW]: Mango.jl: A Julia-Based Multi-Agent Simulation Framework

You can find more information at the top of this Github issue (LINK).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be nearly 20 check items for each single reviewer.

Thank you in advance!

rusu24edward commented 1 month ago

Sorry, I am not able to do this review, I don't know anything about Julia :/

jbytecode commented 1 month ago

👋👋👋 Dear @Datseris 👋👋👋

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled:

[PRE REVIEW]: Mango.jl: A Julia-Based Multi-Agent Simulation Framework

You can find more information at the top of this Github issue (LINK).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be nearly 20 check items for each single reviewer.

Thank you in advance!

Datseris commented 1 month ago

Thank you for inviting me. I am sorry, in a different time I would be happy to review, but I don't have any spare time in the near future.

kavir1698 commented 1 month ago

Thank you for the invitation. Unfortunately, I will not be able to start the review until a few weeks later.

jbytecode commented 1 month ago

@Datseris, @kavir1698 - Thank you for the quick response.

jbytecode commented 1 month ago

👋👋👋 Dear @Libbum 👋👋👋

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled:

[PRE REVIEW]: Mango.jl: A Julia-Based Multi-Agent Simulation Framework

You can find more information at the top of this Github issue (LINK).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be nearly 20 check items for each single reviewer.

Thank you in advance!

Libbum commented 1 month ago

Hi @jbytecode. Bad timing I'm afraid. Just had a baby.

jbytecode commented 1 month ago

@Libbum - No, it's a good timing, congratulations!

jbytecode commented 1 month ago

👋👋👋 Dear @Tortar 👋👋👋

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled:

[PRE REVIEW]: Mango.jl: A Julia-Based Multi-Agent Simulation Framework

You can find more information at the top of this Github issue (LINK).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be nearly 20 check items for each single reviewer.

Thank you in advance!