[REVIEW]: Mango.jl: A Julia-Based Multi-Agent Simulation Framework

editorialbot commented 2 months ago

Submitting author: !--author-handle-->@jsagerOffis@jbytecode<!--end-editor-- Reviewers: @aurorarossi, @Tortar Archive: 10.5281/zenodo.13860452

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0a7712eccc9ba5ccb2276d4f19c8f439"><img src="https://joss.theoj.org/papers/0a7712eccc9ba5ccb2276d4f19c8f439/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0a7712eccc9ba5ccb2276d4f19c8f439/status.svg)](https://joss.theoj.org/papers/0a7712eccc9ba5ccb2276d4f19c8f439)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@aurorarossi & @Tortar, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jbytecode know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @Tortar

📝 Checklist for @aurorarossi

editorialbot commented 3 weeks ago

Done! version is now v0.4.0

jbytecode commented 3 weeks ago

@jsagerOffis - The author names, their DOIs, and the title of the manuscript should match that the ones in the Zenodo archive. Please fix this and then ping me again.

jsagerOffis commented 3 weeks ago

@jbytecode done

jbytecode commented 3 weeks ago

@editorialbot set 10.5281/zenodo.13860452 as archive

editorialbot commented 3 weeks ago

Done! archive is now 10.5281/zenodo.13860452

jbytecode commented 3 weeks ago

@editorialbot check references

editorialbot commented 3 weeks ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.softx.2024.101791 is OK
- 10.1007/s41109-023-00553-8 is OK
- 10.1186/s42162-022-00209-4 is OK
- 10.1145/3447555.3465415 is OK
- 10.15439/2021F60 is OK
- 10.1016/j.arcontrol.2019.05.006 is OK
- 10.1007/s10462-021-09996-w is OK
- 10.1561/2600000019 is OK
- 10.1177/00375497211068820 is OK
- 10.1007/978-3-030-61255-9_30 is OK
- 10.1145/375735.376120 is OK
- 10.1007/0-387-26350-0_7 is OK
- 10.1137/141000671 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Artificial intelligence a modern approach
- No DOI given, and none found for title: Netlogo: A simple environment for modeling complex...
- No DOI given, and none found for title: JIAC V: A MAS framework for industrial application...
- No DOI given, and none found for title: agentframework (2.0.1) [last access 07-08-2024]

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

jbytecode commented 3 weeks ago

@editorialbot generate pdf

editorialbot commented 3 weeks ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jbytecode commented 3 weeks ago

@jsagerOffis - I've just sent a pull request about minor fixes in both the manuscript and bibtex. Please review the PR and tell me if there is something you are not agreed with. If it looks okay to you, please merge. Thank you in advance.

https://github.com/OFFIS-DAI/Mango.jl/pull/72

jbytecode commented 3 weeks ago

I might have mixed up the branches. If you want, you can recreate the joss_paper branch after merging. I apologize for the confusion.

jsagerOffis commented 3 weeks ago

@jbytecode I just merged it to development and also merged those changes back into the joss_paper branch so no worries.

I will also move the final paper state up to the main branch and move the release tag to that commit once its all final.

jbytecode commented 3 weeks ago

@editorialbot check references

editorialbot commented 3 weeks ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.softx.2024.101791 is OK
- 10.1007/s41109-023-00553-8 is OK
- 10.1186/s42162-022-00209-4 is OK
- 10.1145/3447555.3465415 is OK
- 10.15439/2021F60 is OK
- 10.1016/j.arcontrol.2019.05.006 is OK
- 10.1007/s10462-021-09996-w is OK
- 10.1561/2600000019 is OK
- 10.1177/00375497211068820 is OK
- 10.1007/978-3-030-61255-9_30 is OK
- 10.1145/375735.376120 is OK
- 10.1007/0-387-26350-0_7 is OK
- 10.1137/141000671 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Artificial intelligence a modern approach
- No DOI given, and none found for title: Netlogo: A simple environment for modeling complex...
- No DOI given, and none found for title: JIAC V: A MAS framework for industrial application...
- No DOI given, and none found for title: agentframework (2.0.1) [last access 07-08-2024]

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

jbytecode commented 3 weeks ago

@editorialbot generate pdf

editorialbot commented 3 weeks ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jbytecode commented 3 weeks ago

@jsagerOffis - In their current form the manuscript and the bibtex look good to me. Please have a proof-reading one more time and then ping me.

jsagerOffis commented 3 weeks ago

@jbytecode I gave it another read and found no issues.

jbytecode commented 3 weeks ago

@editorialbot recommend-accept

editorialbot commented 3 weeks ago

Attempting dry run of processing paper acceptance...

editorialbot commented 3 weeks ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.softx.2024.101791 is OK
- 10.1007/s41109-023-00553-8 is OK
- 10.1186/s42162-022-00209-4 is OK
- 10.1145/3447555.3465415 is OK
- 10.15439/2021F60 is OK
- 10.1016/j.arcontrol.2019.05.006 is OK
- 10.1007/s10462-021-09996-w is OK
- 10.1561/2600000019 is OK
- 10.1177/00375497211068820 is OK
- 10.1007/978-3-030-61255-9_30 is OK
- 10.1145/375735.376120 is OK
- 10.1007/0-387-26350-0_7 is OK
- 10.1137/141000671 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Artificial intelligence a modern approach
- No DOI given, and none found for title: Netlogo: A simple environment for modeling complex...
- No DOI given, and none found for title: JIAC V: A MAS framework for industrial application...
- No DOI given, and none found for title: agentframework (2.0.1) [last access 07-08-2024]

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

editorialbot commented 3 weeks ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5946, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 3 weeks ago

👋 @jsagerOffis - As the AEiC who will complete the processing of this paper, I've proofread it and suggest the changes in https://github.com/OFFIS-DAI/Mango.jl/pull/73. Please merge this, or let me know what you disagree with, then we can continue the acceptance and publication process.

jsagerOffis commented 3 weeks ago

@danielskatz done

danielskatz commented 3 weeks ago

@editorialbot recommend-accept

editorialbot commented 3 weeks ago

Attempting dry run of processing paper acceptance...

editorialbot commented 3 weeks ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.softx.2024.101791 is OK
- 10.1007/s41109-023-00553-8 is OK
- 10.1186/s42162-022-00209-4 is OK
- 10.1145/3447555.3465415 is OK
- 10.15439/2021F60 is OK
- 10.1016/j.arcontrol.2019.05.006 is OK
- 10.1007/s10462-021-09996-w is OK
- 10.1561/2600000019 is OK
- 10.1177/00375497211068820 is OK
- 10.1007/978-3-030-61255-9_30 is OK
- 10.1145/375735.376120 is OK
- 10.1007/0-387-26350-0_7 is OK
- 10.1137/141000671 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Artificial intelligence: a modern approach
- No DOI given, and none found for title: Netlogo: A simple environment for modeling complex...
- No DOI given, and none found for title: JIAC V: A MAS framework for industrial application...
- No DOI given, and none found for title: agentframework (2.0.1) [last access 07-08-2024]

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

editorialbot commented 3 weeks ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5948, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 3 weeks ago

@editorialbot accept

editorialbot commented 3 weeks ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 3 weeks ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Sager given-names: Jens orcid: "https://orcid.org/0000-0001-6352-4213" - family-names: Schrage given-names: Rico orcid: "https://orcid.org/0000-0001-5339-6553" doi: 10.5281/zenodo.13860452 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Sager given-names: Jens orcid: "https://orcid.org/0000-0001-6352-4213" - family-names: Schrage given-names: Rico orcid: "https://orcid.org/0000-0001-5339-6553" date-published: 2024-10-01 doi: 10.21105/joss.07098 issn: 2475-9066 issue: 102 journal: Journal of Open Source Software publisher: name: Open Journals start: 7098 title: "Mango.jl: A Julia-Based Multi-Agent Simulation Framework" type: article url: "https://joss.theoj.org/papers/10.21105/joss.07098" volume: 9 title: "Mango.jl: A Julia-Based Multi-Agent Simulation Framework" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 3 weeks ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 3 weeks ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5949
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.07098
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

danielskatz commented 3 weeks ago

Congratulations to @jsagerOffis (Jens Sager) and Rico Schrage on your publication!!

And thanks to @aurorarossi and @Tortar for reviewing, and to @jbytecode for editing! JOSS depends on volunteers and we couldn't do this without you

editorialbot commented 3 weeks ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following

code snippets

``` Markdown: [![DOI](https://joss.theoj.org/papers/10.21105/joss.07098/status.svg)](https://doi.org/10.21105/joss.07098) HTML: reStructuredText: .. image:: https://joss.theoj.org/papers/10.21105/joss.07098/status.svg :target: https://doi.org/10.21105/joss.07098 ```

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews