openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[PRE REVIEW]: constrained_manipulability: A ROS 2 library to Compute and Visualize Constrained Capacities for Robotic Manipulators #7106

Closed editorialbot closed 2 days ago

editorialbot commented 3 months ago

Submitting author: !--author-handle-->@mazrk7<!--end-author-handle-- (Mark Zolotas) Repository: https://github.com/philip-long/constrained_manipulability Branch with paper.md (empty if default branch): paper Version: v1.0.0 Editor: !--editor-->@crvernon<!--end-editor-- Reviewers: @askuric, @JHartzer Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/02f7e4e6e7e542ee3b96b0f1d2524d20"><img src="https://joss.theoj.org/papers/02f7e4e6e7e542ee3b96b0f1d2524d20/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/02f7e4e6e7e542ee3b96b0f1d2524d20/status.svg)](https://joss.theoj.org/papers/02f7e4e6e7e542ee3b96b0f1d2524d20)

Author instructions

Thanks for submitting your paper to JOSS @mazrk7. Currently, there isn't a JOSS editor assigned to your paper.

@mazrk7 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 3 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 3 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (1453.4 files/s, 180689.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C++                              6            291            135           1616
C/C++ Header                     3            111            119            484
Python                           8            122             43            484
YAML                            10              1             12            379
Markdown                         2             70              0            323
CMake                            2             35              7            160
TeX                              1             13              0            118
XML                              2             13              0             53
Gencat NLS                       3              0              0             11
-------------------------------------------------------------------------------
SUM:                            37            656            316           3628
-------------------------------------------------------------------------------

Commit count by author:

    61  mazrk7
    40  philip-long
    34  Mark Zolotas
    10  philip long
     6  philip
     1  Tarik Kelestemur
editorialbot commented 3 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1126/scirobotics.abm6074 is OK
- 10.1109/ICRA.2012.6225337 is OK
- 10.3389/frobt.2021.730433 is OK
- 10.21105/joss.05670 is OK
- 10.1109/LRA.2023.3313926 is OK

MISSING DOIs

- No DOI given, and none found for title: ROS: an open-source Robot Operating System
- No DOI given, and none found for title: Analysis and control of robot manipulators with re...
- 10.1109/icra.2019.8794071 may be a valid DOI for title: Optimization-Based Human-in-the-Loop Manipulation ...
- 10.1109/humanoids.2018.8624962 may be a valid DOI for title: Evaluating Robot Manipulability in Constrained Env...
- 10.1007/3-540-61576-8_77 may be a valid DOI for title: Double description method revisited
- 10.1007/s10514-012-9321-0 may be a valid DOI for title: OctoMap: An efficient probabilistic 3D mapping fra...
- 10.1109/tro.2016.2623338 may be a valid DOI for title: Zmp support areas for multicontact mobility under ...
- 10.1007/978-3-319-61431-1_23 may be a valid DOI for title: Tension distribution algorithm for planar mobile c...

INVALID DOIs

- None
editorialbot commented 3 months ago

Paper file info:

šŸ“„ Wordcount for paper.md is 2328

āœ… The paper includes a Statement of need section

editorialbot commented 3 months ago

License info:

āœ… License found: MIT License (Valid open source OSI approved license)

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 3 months ago

Five most similar historical JOSS papers:

A C++ Implementation of a Cartesian Impedance Controller for Robotic Manipulators Submitting author: @matthias-mayr Handling editor: @adi3 (Active) Reviewers: @JHartzer, @ShravanTata Similarity score: 0.6950

TriP: A Python package for the kinematic modeling of serial-parallel hybrid robots Submitting author: @liquidcronos Handling editor: @danielskatz (Active) Reviewers: @SeungBack, @bmagyar Similarity score: 0.6673

Automatic Computation for Robot Design (ACRoD): A Python package for numerical calculation of Jacobian of a robot at a given configuration around a specified end-effector point Submitting author: @suneeshjacob Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @gfadini, @CameronDevine, @JHartzer Similarity score: 0.6633

Kinematics-vis: A Visualization Tool for the Mathematics of Human Motion Submitting author: @heath-henninger Handling editor: @adi3 (Active) Reviewers: @destogl, @nnadeau Similarity score: 0.6450

sbp-env: A Python Package for Sampling-based Motion Planner and Samplers Submitting author: @soraxas Handling editor: @danielskatz (Active) Reviewers: @KanishAnand, @OlgerSiebinga Similarity score: 0.6209

āš ļø Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

crvernon commented 2 months ago

@editorialbot invite @Nikoleta-v3 as editor

:wave: @Nikoleta-v3 are you able to take this one on as editor? If so, there is also a companion submission that the authors submitted at the same time that uses this package as a dependency (see https://github.com/openjournals/joss-reviews/issues/7107#issuecomment-2291721853). Would you also consider taking that one to keep the process cleaner?

editorialbot commented 2 months ago

Invitation to edit this submission sent!

Nikoleta-v3 commented 2 months ago

Hello @crvernon šŸ˜„, Iā€™m sorry, but Iā€™m currently editing two submissions and reviewing a third one. I could potentially take on one more, but definitely not two

crvernon commented 2 months ago

@editorialbot assign me as editor

editorialbot commented 2 months ago

Assigned! @crvernon is now the editor

crvernon commented 2 months ago

:wave: @mazrk7 - I think I'll take these submissions myself. Please do me a favor up front and lower the word count of the paper to about 1000 words. Most detail can usually be moved to the package documentation.

Also, do you have recommendations for reviewers that you would like me to check out? Thanks!

mark-zolotas-tri commented 2 months ago

šŸ‘‹ @crvernon thank you! Yes ofcourse, @philip-long and I will reduce the word count for this submission.

If @askuric is available then he would be a good reviewer! Thanks.

askuric commented 2 months ago

Hi guys, I'd be available and happy to review this submission :)

crvernon commented 2 months ago

@editorialbot add @askuric as reviewer

editorialbot commented 2 months ago

@askuric added to the reviewers list!

mazrk7 commented 2 months ago

@philip-long has reduced the word count. Thanks @askuric

askuric commented 1 month ago

Hi all, I did not receive any notifications, so I just waned to clarify. :D Did the review start or are we still in the pre-review process for this submission?

crvernon commented 1 month ago

Hi @askuric, I am trying to find one more reviewer for this submission, then I will kick it over into full review and provide more instructions. Thanks for checking in!

crvernon commented 4 days ago

šŸ‘‹ @JHartzer - Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

JHartzer commented 3 days ago

Howdy @crvernon, yes I can review this submission!

crvernon commented 2 days ago

@editorialbot add @JHartzer as reviewer

Thanks @JHartzer!

editorialbot commented 2 days ago

@JHartzer added to the reviewers list!

crvernon commented 2 days ago

@editorialbot start review

šŸ‘‹ - Alright @mazrk7, @askuric, and @JHartzer - I am going to close this Pre-Review and kick off the full review which you should receive a notification for. Thanks!

editorialbot commented 2 days ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/7481.