openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
712 stars 38 forks source link

[PRE REVIEW]: Parallel LSH Ontology Matching #7109

Closed editorialbot closed 1 month ago

editorialbot commented 1 month ago

Submitting author: !--author-handle-->@Iconoclastic0428<!--end-author-handle-- (Shengqi Li) Repository: https://github.com/Iconoclastic0428/OntologyMatching Branch with paper.md (empty if default branch): Version: v 1.0.0 Editor: Pending Reviewers: Pending Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/8c2e2ccb3e92945eb7359953517eb16b"><img src="https://joss.theoj.org/papers/8c2e2ccb3e92945eb7359953517eb16b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/8c2e2ccb3e92945eb7359953517eb16b/status.svg)](https://joss.theoj.org/papers/8c2e2ccb3e92945eb7359953517eb16b)

Author instructions

Thanks for submitting your paper to JOSS @Iconoclastic0428. Currently, there isn't a JOSS editor assigned to your paper.

@Iconoclastic0428 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 month ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 month ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- No DOI given, and none found for title: Practical and optimal LSH for angular distance
- 10.1186/2041-1480-5-44 may be a valid DOI for title: An effective method of large scale ontology matchi...
- 10.1109/tkde.2011.253 may be a valid DOI for title: Ontology matching: state of the art and future cha...
- No DOI given, and none found for title: Ontology matching: A literature review
- No DOI given, and none found for title: Ontology matching
- 10.4018/ijswis.297042 may be a valid DOI for title: Deep embedding learning with auto-encoder for larg...
- 10.1145/3447548.3467138 may be a valid DOI for title: Medto: Medical data to ontology matching using hyb...
- No DOI given, and none found for title: Integrating unsupervised language model with tripl...
- 10.3233/sw-160218 may be a valid DOI for title: Knowledge graph refinement: A survey of approaches...
- 10.4018/jdm.2021100102 may be a valid DOI for title: Biomedical ontology matching through attention-bas...
- No DOI given, and none found for title: Ontology matching with word embeddings
- 10.1007/s10994-021-05997-6 may be a valid DOI for title: Owl2vec*: Embedding of owl ontologies
- 10.1109/wi-iat.2014.26 may be a valid DOI for title: Locality-sensitive hashing for massive string-base...
- 10.1007/978-3-642-35176-1_4 may be a valid DOI for title: Instance-based matching of large ontologies using ...
- No DOI given, and none found for title: LexMapr

INVALID DOIs

- None
editorialbot commented 1 month ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.01 s (1245.8 files/s, 116526.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C/C++ Header                     7            128             23            535
C++                              1             37              0            203
TeX                              1             14              0            133
Markdown                         2             65              0            109
Python                           1             22              5             80
YAML                             1              1              0             18
make                             1              7              5             10
CMake                            1              3              0              5
-------------------------------------------------------------------------------
SUM:                            15            277             33           1093
-------------------------------------------------------------------------------

Commit count by author:

    18  Shengqi Li
     1  Iconoclastic0428
editorialbot commented 1 month ago

Paper file info:

📄 Wordcount for paper.md is 1371

✅ The paper includes a Statement of need section

editorialbot commented 1 month ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 month ago

Five most similar historical JOSS papers:

SimilaritySearch.jl: Autotuned nearest neighbor indexes for Julia Submitting author: @sadit Handling editor: @jbytecode (Active) Reviewers: @kose-y, @ahwillia Similarity score: 0.6137

Zoomerjoin: Superlatively-Fast Fuzzy Joins Submitting author: @beniaminogreen Handling editor: @samhforbes (Active) Reviewers: @cjbarrie, @wincowgerDEV Similarity score: 0.6111

None Submitting author: None Handling editor: None (None) Reviewers: None Similarity score: 0.6074

shmlast: An improved implementation of Conditional Reciprocal Best Hits with LAST and Python Submitting author: @camillescott Handling editor: @biorelated (Retired) Reviewers: @genomematt Similarity score: 0.6062

matchms - processing and similarity evaluation of mass spectrometry data. Submitting author: @florian-huber Handling editor: @arfon (Active) Reviewers: @bittremieux, @kaibioinfo Similarity score: 0.6035

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

danielskatz commented 1 month ago

@Iconoclastic0428 - thanks for your submission.

Due to the relatively small amount of code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. You should hear back in a week or so.

If it does pass this step, you will need to actually add the references in the paper, by adding a "References" heading at the end of the md file and then citing the references within the paper. See the example paper.

Additionally, there appear to be missing DOIs in your references. If this passes, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

But you don't need to do any of these steps for now, since if the work is considered out of scope, you would be doing this work for nothing.

danielskatz commented 1 month ago

@editorialbot query scope

editorialbot commented 1 month ago

Submission flagged for editorial review.

danielskatz commented 1 month ago

👋 @Iconoclastic0428 - I'm sorry to say that after discussion amongst the JOSS editors, we have decided that this submission does not meet the substantial scholarly effort criterion for review by JOSS.

Other issues include the fact that main.cpp is responsible for performing calculations, which makes the submission an application but not an extensible reusable library, and the lack of unit tests.

The README.md is also too brief and missing elements required for JOSS, though this could have been fixed during the review process.

Please see https://joss.readthedocs.io/en/latest/submitting.html#other-venues-for-reviewing-and-publishing-software-packages for other suggestions for how you might receive credit for your work.

danielskatz commented 1 month ago

@editorialbot reject

editorialbot commented 1 month ago

Paper rejected.