openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[PRE REVIEW]: bayes_spec: A Bayesian Spectral Line Modeling Framework for Astrophysics #7112

Closed editorialbot closed 2 months ago

editorialbot commented 3 months ago

Submitting author: !--author-handle-->@tvwenger<!--end-author-handle-- (Trey Wenger) Repository: https://github.com/tvwenger/bayes_spec Branch with paper.md (empty if default branch): Version: v1.5.0 Editor: !--editor-->@ivastar<!--end-editor-- Reviewers: @ConorMacBride, @kbwestfall, @larryshamalama Managing EiC: Dan Foreman-Mackey

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ac05a353639c3268883cae19ca6a9cf9"><img src="https://joss.theoj.org/papers/ac05a353639c3268883cae19ca6a9cf9/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ac05a353639c3268883cae19ca6a9cf9/status.svg)](https://joss.theoj.org/papers/ac05a353639c3268883cae19ca6a9cf9)

Author instructions

Thanks for submitting your paper to JOSS @tvwenger. Currently, there isn't a JOSS editor assigned to your paper.

@tvwenger if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 3 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 3 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3847/1538-4357/ac2f42 is OK
- 10.7717/peerj-cs.1516 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 3 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.05 s (766.7 files/s, 247863.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          20            475            910           1592
Jupyter Notebook                 4              0           8986            604
Markdown                         2             73              0            149
YAML                             6             11             21            149
reStructuredText                 4             37             63             41
TOML                             1              5              0             32
TeX                              1              1              0             28
DOS Batch                        1              8              1             26
JSON                             1              0              0             23
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            41            614           9988           2653
-------------------------------------------------------------------------------

Commit count by author:

    15  Trey Wenger
editorialbot commented 3 months ago

Paper file info:

📄 Wordcount for paper.md is 291

✅ The paper includes a Statement of need section

editorialbot commented 3 months ago

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

dfm commented 3 months ago

@tvwenger — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience!

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 3 months ago

Five most similar historical JOSS papers:

Astronomical échelle spectroscopy data analysis with muler Submitting author: @gully Handling editor: @xuanxu (Active) Reviewers: @bmorris3, @wtgee Similarity score: 0.7127

PySPI: A python analysis framework for INTEGRAL/SPI Submitting author: @BjoernBiltzinger Handling editor: @christinahedges (Retired) Reviewers: @tohuvavohu, @dfm Similarity score: 0.7115

MCALF: Multi-Component Atmospheric Line Fitting Submitting author: @ConorMacBride Handling editor: @mbobra (Active) Reviewers: @mgalloy, @Goobley Similarity score: 0.7100

pyradiosky: A Python package for Radio Sky Models Submitting author: @bhazelton Handling editor: @xuanxu (Active) Reviewers: @pritchardn, @0xCoto Similarity score: 0.7065

DBSP_DRP: A Python package for automated spectroscopic data reduction of DBSP data Submitting author: @finagle29 Handling editor: @arfon (Active) Reviewers: @crhea93, @arjunsavel Similarity score: 0.7057

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

tvwenger commented 2 months ago

larryshamalama would be an excellent referee, I think!

tvwenger commented 2 months ago

For the future editor: I am aware that JOSS has substantial "scholarly effort" criteria, and that the age of this repository might suggest that it does not meet these criteria. I wanted to give a bit of context for the project to justify its significant scholarly effort.

bayes_spec has been developed over the past ~18 months, originally forming the foundation of a specific model: https://github.com/tvwenger/amoeba2

Given the general-use applicability of this Bayesian spectral modeling framework, the core framework from amoeba2 was split into bayes_spec so that it could be extended to any user-specified model.

There are now several models implemented in the bayes_spec framework, and the applications of each are being prepared for astronomy journals. https://github.com/tvwenger/bayes_cn_hfs https://github.com/tvwenger/amoeba2 https://github.com/tvwenger/bayes_yplus https://github.com/tvwenger/caribou_hi

It would be great to be able to point to the JOSS paper for bayes_spec in each of these astronomy papers!

ivastar commented 2 months ago

@editorialbot assign @ivastar as editor

editorialbot commented 2 months ago

Assigned! @ivastar is now the editor

ivastar commented 2 months ago

Hi @tvwenger! I will be the editor for this submission. I will be looking for reviewers in the next week or so. Thank you for the suggestion above!

ivastar commented 2 months ago

@editorialbot add @ConorMacBride as reviewer

editorialbot commented 2 months ago

@ConorMacBride added to the reviewers list!

ivastar commented 2 months ago

@editorialbot add @larryshamalama as reviewer

ivastar commented 2 months ago

@editorialbot add @kbwestfall as reviewer

editorialbot commented 2 months ago

@kbwestfall added to the reviewers list!

ivastar commented 2 months ago

@editorialbot add @larryshamalama as reviewer

editorialbot commented 2 months ago

@larryshamalama added to the reviewers list!

ivastar commented 2 months ago

@editorialbot start review

editorialbot commented 2 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/7201.