search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[PRE REVIEW]: ler : LVK (LIGO-Virgo-KAGRA collaboration) event (compact-binary mergers) rate calculator and simulator #7113

Closed editorialbot closed 1 week ago

editorialbot commented 3 months ago

Submitting author: !--author-handle-->@hemantaph<!--end-author-handle-- (Hemantakumar Phurailatpam) Repository: https://github.com/hemantaph/ler/ Branch with paper.md (empty if default branch): main Version: v0.4.0 Editor: !--editor-->@dfm<!--end-editor-- Reviewers: !--reviewers-list-->@michellegurevich<!--end-reviewers-list-- Managing EiC: Dan Foreman-Mackey

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/fa0b14e4c1d1eaf09cb34cc0aedd7881"><img src="https://joss.theoj.org/papers/fa0b14e4c1d1eaf09cb34cc0aedd7881/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/fa0b14e4c1d1eaf09cb34cc0aedd7881/status.svg)](https://joss.theoj.org/papers/fa0b14e4c1d1eaf09cb34cc0aedd7881)

Author instructions

Thanks for submitting your paper to JOSS @hemantaph. Currently, there isn't a JOSS editor assigned to your paper.

@hemantaph if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 3 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 3 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.43 s (523.2 files/s, 349397.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            68           3986            205          56527
Jupyter Notebook                50              0          33091           5916
Python                          23           1431           5660           4746
SVG                              5              0              0           2698
XML                              2              0             21           2459
TeX                              5            193             74           1365
JavaScript                      16            188            309           1208
CSS                             10            258             81           1193
Markdown                         6            124              0            460
reStructuredText                34          15765          13068            349
YAML                             5              8             33             79
make                             2             15             11             48
DOS Batch                        1              8              1             26
-------------------------------------------------------------------------------
SUM:                           227          21976          52554          77074
-------------------------------------------------------------------------------

Commit count by author:

   255  Hemantakumar Phurailatpam
    67  hemantakumar.phurailatpam
    34  hemantaph
    27  Phurailatpam Hemantakumar
     2  David Keitel
     1  Narola Harsh
     1  Otto Akseli Hannuksela
editorialbot commented 3 months ago

Paper file info:

📄 Wordcount for paper.tex is 2798

🔴 Failed to discover a Statement of need section in paper

editorialbot commented 3 months ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 3 months ago

:warning: An error happened when generating the pdf.

dfm commented 3 months ago

@hemantaph — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience!

In the meantime, can you clean up the paper directory and subdirectory? There are a lot of temporary and autogenerated files in there that shouldn't be. I think that's part of the reason why it's not successfully compiling. Then try commenting @editorialbot generate pdf on this thread to make sure it works. Thanks!

hemantaph commented 2 months ago

@editorialbot generate pdf

editorialbot commented 2 months ago

:warning: An error happened when generating the pdf.

hemantaph commented 2 months ago

@dfm I have made the necessary changes but the '@editorialbot' still gives an error "An error happened when generating the pdf." Can you please clarify and help me deal with this confusing issue? Thanks in advance.

hemantaph commented 2 months ago

@editorialbot generate pdf

editorialbot commented 2 months ago

:warning: An error happened when generating the pdf.

hemantaph commented 2 months ago

@editorialbot generate pdf

editorialbot commented 2 months ago

:warning: An error happened when generating the pdf.

hemantaph commented 2 months ago

@editorialbot generate pdf

editorialbot commented 2 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 2 months ago

Five most similar historical JOSS papers:

deeplenstronomy: A dataset simulation package for strong gravitational lensing Submitting author: @rmorgan10 Handling editor: @pdebuyl (Active) Reviewers: @shreyasbapat, @jiwoncpark Similarity score: 0.7361

pygwb: a Python-based library for gravitational-wave background searches Submitting author: @a-renzini Handling editor: @plaplant (Active) Reviewers: @Sbozzolo, @cmbiwer Similarity score: 0.7312

PyAutoLens: Open-Source Strong Gravitational Lensing Submitting author: @Jammy2211 Handling editor: @xuanxu (Active) Reviewers: @aureliocarnero, @zonca Similarity score: 0.7309

Mayawaves: Python Library for Interacting with the Einstein Toolkit and the MAYA Catalog Submitting author: @deborahferguson Handling editor: @eloisabentivegna (Retired) Reviewers: @cjoana, @Sbozzolo Similarity score: 0.7274

LEGWORK: A python package for computing the evolution and detectability of stellar-origin gravitational-wave sources with space-based detectors Submitting author: @TomWagg Handling editor: @arfon (Active) Reviewers: @dbkeitel, @cmbiwer Similarity score: 0.7219

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

hemantaph commented 2 months ago

@dfm It has been more than three weeks. I am worried that a reviewer hasn't been allocated yet. What can I do from my side?

dfm commented 2 months ago

@hemantaph — Thanks for checking in. Unfortunately our backlog is large coming out of the summer so it might still be a little bit before we can assign an editor. Thanks for your patience!

dbkeitel commented 2 months ago

As for possible reviewers, I think the bot found at least 2 good matches of previous JOSS papers with similarities in scope / type of software: deeplenstronomy and LEGWORK. Their authors could be good candidates. (For disclosure, I was a reviewer of the latter; not sure if such a "closed loop" would count as a conflict of interest.)

hemantaph commented 2 months ago

As for possible reviewers, I think the bot found at least 2 good matches of previous JOSS papers with similarities in scope / type of software: deeplenstronomy and LEGWORK. Their authors could be good candidates. (For disclosure, I was a reviewer of the latter; not sure if such a "closed loop" would count as a conflict of interest.)

Thanks for the suggestion @dbkeitel . I will try contacting the authors of deeplenstronomy and LEGWORK, or is there a formal channel where I can ask them to be reviewers?

dfm commented 1 month ago

@hemantaph — Please don't reach out to reviewers! The editor will do that once they are assigned, but unfortunately we still have a bit of a backlog after the summer. We'll get an editor assigned as soon as possible. Thank you for your patience!

dfm commented 1 month ago

@editorialbot assign me as editor

@hemantaph — Thanks for your patience! I'm now available to start editing your submission. I'll start reaching out to reviewers in the coming days, and then, once we have two reviewers, we will start the main review in a new thread. Let me know if you have any questions as we go.

editorialbot commented 1 month ago

Assigned! @dfm is now the editor

hemantaph commented 1 month ago

@dfm Thanks a lot.

dfm commented 1 month ago

:wave: @Jammy2211, @michellegurevich, @maxisi — would any of you be willing to review this submission for The Journal of Open Source Software? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

michellegurevich commented 2 weeks ago

@dfm , hello! Happy to review.

hemantaph commented 2 weeks ago

@dfm , hello! Happy to review.

Thanks a lot.

dfm commented 1 week ago

@editorialbot add @michellegurevich as reviewer

Thanks @michellegurevich!!

editorialbot commented 1 week ago

@michellegurevich added to the reviewers list!

dfm commented 1 week ago

@editorialbot start review

I'm going to start this review in a new thread even though we only have one reviewer so far. I'll keep reaching out to folks here and over email and add the second reviewer later. For now, I'd like @michellegurevich to be able to start reviewing!

editorialbot commented 1 week ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/7420.