[PRE REVIEW]: GridapSolvers.jl: Scalable multiphysics finite element solvers in Julia

editorialbot commented 4 weeks ago

Submitting author: !--author-handle-->@JordiManyer@diehlpk<!--end-editor-- Reviewers: @PetrKryslUCSD, @Leticia-maria Managing EiC: Daniel S. Katz

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/889d03e60fd6e4c267ca5cbc1cf84e12"><img src="https://joss.theoj.org/papers/889d03e60fd6e4c267ca5cbc1cf84e12/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/889d03e60fd6e4c267ca5cbc1cf84e12/status.svg)](https://joss.theoj.org/papers/889d03e60fd6e4c267ca5cbc1cf84e12)

Author instructions

Thanks for submitting your paper to JOSS @JordiManyer. Currently, there isn't a JOSS editor assigned to your paper.

@JordiManyer if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

editorialbot commented 4 weeks ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot commented 4 weeks ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.cpc.2022.108341 is OK
- 10.1137/141000671 is OK
- 10.21105/JOSS.02520 is OK
- 10.1137/20M1328786 is OK
- 10.1137/100791634 is OK
- 10.1016/j.camwa.2020.06.009 is OK
- 10.1515/jnum-2012-0013 is OK
- 10.1007/s00366-006-0049-3 is OK
- 10.1515/jnma-2021-0081 is OK
- 10.1145/1163641.1163644 is OK
- 10.1007/978-3-642-23099-8 is OK
- 10.1093/acprof:oso/9780199678792.001.0001 is OK
- 10.1137/1.9780898719505 is OK
- 10.1007/978-0-387-09766-4_90 is OK
- 10.21105/joss.04157 is OK
- 10.1145/3445791 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: PETSc/TAO Users Manual
- No DOI given, and none found for title: MPI: A Message-Passing Interface Standard Version ...
- No DOI given, and none found for title: GridapPETSc
- No DOI given, and none found for title: GridapP4est
- No DOI given, and none found for title: PartitionedArrays
- No DOI given, and none found for title: The Trilinos Project Website
- No DOI given, and none found for title: \sl hypre: High Performance Preconditioners
- No DOI given, and none found for title: Preconditing in H(div) and applications
- No DOI given, and none found for title: An implementation of tensor product patch smoother...

❌ MISSING DOIs

- 10.1137/s0895479899358194 may be a valid DOI for title: A Fully Asynchronous Multifrontal Solver Using Dis...
- 10.1145/3242094 may be a valid DOI for title: Performance and Scalability of the Block Low-Rank ...
- 10.1007/pl00005386 may be a valid DOI for title: Multigrid in H (div) and H (curl)

❌ INVALID DOIs

- None

editorialbot commented 4 weeks ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.12 s (1367.5 files/s, 142935.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                          140           2383           1444          10603
TOML                             5            349              2           1496
Markdown                        10            128              0            388
TeX                              1             25              0            308
YAML                             4              1              8            177
Bourne Shell                     6             16             32             76
XML                              1              0              0             20
-------------------------------------------------------------------------------
SUM:                           167           2902           1486          13068
-------------------------------------------------------------------------------

Commit count by author:

   378  JordiManyer
    10  Alberto F. Martin
     2  CompatHelper Julia
     2  amartin
     1  Santiago Badia

editorialbot commented 4 weeks ago

Paper file info:

📄 Wordcount for paper.md is 1728

🔴 Failed to discover a Statement of need section in paper

editorialbot commented 4 weeks ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 4 weeks ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 4 weeks ago

Five most similar historical JOSS papers:

Gridap: An extensible Finite Element toolbox in Julia Submitting author: @fverdugo Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @PetrKryslUCSD, @TeroFrondelius, @KristofferC Similarity score: 0.7520

PyAMG: Algebraic Multigrid Solvers in Python Submitting author: @lukeolson Handling editor: @jedbrown (Active) Reviewers: @mayrmt, @mattmartineau Similarity score: 0.7389

Krylov.jl: A Julia basket of hand-picked Krylov methods Submitting author: @amontoison Handling editor: @jedbrown (Active) Reviewers: @prj-, @LeilaGhaffari Similarity score: 0.7265

BasicTools: a numerical simulation toolbox Submitting author: @fbordeu Handling editor: @diehlpk (Active) Reviewers: @hvonwah, @sthavishtha Similarity score: 0.7248

PDENLPModels.jl: An NLPModel API for Optimization Problems with PDE-Constraints Submitting author: @tmigot Handling editor: @jbytecode (Active) Reviewers: @jmejia8, @HaoZeke Similarity score: 0.7231

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

danielskatz commented 4 weeks ago

👋 @JordiManyer - thanks for your submission. As the track editor, I'll work on finding an editor. On your side:

Please work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.
Also, please see the example paper about how to cite multiple papers at the same time, and make changes to your .md file.
In your references, please be sure you are not using {{}} around titles that preserve cases, as the JOSS processing determines the cases of words. If you need to preserve a the same in a word or letter, do that with just an extra internal {} where needed. For example, Julia should be {J}ulia in one place I see.
The paper is also a little long - it's about 1800 words, where JOSS papers are typically around 1000 max. Please see if there's anything you can shorten, perhaps by moving it to the repo/documentation and pointing to it there. You can use @editorialbot check repository to see how many words are in the paper.

danielskatz commented 4 weeks ago

👋 @diehlpk - would you be willing to edit this submission?

danielskatz commented 4 weeks ago

@editorialbot invite @diehlpk as editor

editorialbot commented 4 weeks ago

Invitation to edit this submission sent!

JordiManyer commented 4 weeks ago

Hi @danielskatz, thank you for your time. I will look into your comments and let you know if I have any doubts.

JordiManyer commented 4 weeks ago

@danielskatz A first comment: I believe a lot of words are tied to the example. I believe the actual paper is around 1000/1200 words (which is what I thought you guys would be counting). Could I remove the embedded script and point to a file in the repo? I also think it would help readability, but was under the impression that a demo code within the paper was compulsory.

danielskatz commented 4 weeks ago

The review criteria (https://joss.readthedocs.io/en/latest/review_criteria.html) and review checklist (https://joss.readthedocs.io/en/latest/review_checklist.html) do not require or suggest an example in the paper, so moving the example to the repo/docs would be fine.

diehlpk commented 4 weeks ago

@editorialbot add @diehlpk as reviewer

editorialbot commented 4 weeks ago

Can't add reviewers: There is no editor assigned yet

JordiManyer commented 4 weeks ago

@editorialbot check references

editorialbot commented 4 weeks ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.cpc.2022.108341 is OK
- 10.1137/141000671 is OK
- 10.21105/JOSS.02520 is OK
- 10.1137/20M1328786 is OK
- 10.1137/100791634 is OK
- 10.1016/j.camwa.2020.06.009 is OK
- 10.1515/jnum-2012-0013 is OK
- 10.1007/s00366-006-0049-3 is OK
- 10.1515/jnma-2021-0081 is OK
- 10.1145/1163641.1163644 is OK
- 10.1007/978-3-642-23099-8 is OK
- 10.1093/acprof:oso/9780199678792.001.0001 is OK
- 10.1137/1.9780898719505 is OK
- 10.1007/978-0-387-09766-4_90 is OK
- 10.1137/s0895479899358194 is OK
- 10.1145/3242094 is OK
- 10.21105/joss.04157 is OK
- 10.1090/S0025-5718-97-00826-0 is OK
- 10.1007/PL00005386 is OK
- 10.1145/3445791 is OK
- 10.48550/arXiv.2405.19004 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: PETSc/TAO Users Manual
- No DOI given, and none found for title: MPI: A Message-Passing Interface Standard Version ...
- No DOI given, and none found for title: GridapPETSc
- No DOI given, and none found for title: GridapP4est
- No DOI given, and none found for title: PartitionedArrays
- No DOI given, and none found for title: The Trilinos Project Website
- No DOI given, and none found for title: \sl hypre: High Performance Preconditioners

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

JordiManyer commented 4 weeks ago

I think the DOIs missing at this point are just websites and misc references.

JordiManyer commented 4 weeks ago

@editorialbot generate pdf

editorialbot commented 4 weeks ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 4 weeks ago

Five most similar historical JOSS papers:

Gridap: An extensible Finite Element toolbox in Julia Submitting author: @fverdugo Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @PetrKryslUCSD, @TeroFrondelius, @KristofferC Similarity score: 0.7440

PyAMG: Algebraic Multigrid Solvers in Python Submitting author: @lukeolson Handling editor: @jedbrown (Active) Reviewers: @mayrmt, @mattmartineau Similarity score: 0.7357

Krylov.jl: A Julia basket of hand-picked Krylov methods Submitting author: @amontoison Handling editor: @jedbrown (Active) Reviewers: @prj-, @LeilaGhaffari Similarity score: 0.7331

PyAMG: Algebraic Multigrid Solvers in Python Submitting author: @lukeolson Handling editor: @jedbrown (Active) Reviewers: @mayrmt, @Jeff-Hadley, @victorapm Similarity score: 0.7236

BasicTools: a numerical simulation toolbox Submitting author: @fbordeu Handling editor: @diehlpk (Active) Reviewers: @hvonwah, @sthavishtha Similarity score: 0.7197

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

JordiManyer commented 4 weeks ago

@editorialbot check repository

editorialbot commented 4 weeks ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.12 s (1377.4 files/s, 143900.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                          140           2383           1444          10603
TOML                             5            349              2           1496
TeX                              1             25              0            313
Markdown                        10            111              0            306
YAML                             4              1              8            177
Bourne Shell                     6             16             32             76
-------------------------------------------------------------------------------
SUM:                           166           2885           1486          12971
-------------------------------------------------------------------------------

Commit count by author:

   379  JordiManyer
    10  Alberto F. Martin
     2  CompatHelper Julia
     2  amartin
     1  Santiago Badia

editorialbot commented 4 weeks ago

Paper file info:

📄 Wordcount for paper.md is 1487

🔴 Failed to discover a Statement of need section in paper

editorialbot commented 4 weeks ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

JordiManyer commented 4 weeks ago

@editorialbot generate pdf

editorialbot commented 4 weeks ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 4 weeks ago

Five most similar historical JOSS papers:

Gridap: An extensible Finite Element toolbox in Julia Submitting author: @fverdugo Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @PetrKryslUCSD, @TeroFrondelius, @KristofferC Similarity score: 0.7486

PyAMG: Algebraic Multigrid Solvers in Python Submitting author: @lukeolson Handling editor: @jedbrown (Active) Reviewers: @mayrmt, @mattmartineau Similarity score: 0.7398

Krylov.jl: A Julia basket of hand-picked Krylov methods Submitting author: @amontoison Handling editor: @jedbrown (Active) Reviewers: @prj-, @LeilaGhaffari Similarity score: 0.7289

PyAMG: Algebraic Multigrid Solvers in Python Submitting author: @lukeolson Handling editor: @jedbrown (Active) Reviewers: @mayrmt, @Jeff-Hadley, @victorapm Similarity score: 0.7243

BasicTools: a numerical simulation toolbox Submitting author: @fbordeu Handling editor: @diehlpk (Active) Reviewers: @hvonwah, @sthavishtha Similarity score: 0.7221

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

JordiManyer commented 4 weeks ago

@danielskatz I've applied a first round of edits. Fixed all the doi-related stuff. We are down to 1500 words, and I don't think there is anything superfluous to remove. I'll be happy to shorten it if the reviewers deem it necessary.

@diehlpk On the topic of reviewers : Since this paper is a natural extension of GridapDistributed.jl, we could probably consider the same list that was considered back then. Namely,

jedbrown
PetrKryslUCSD
Leticia-maria
TeroFrondelius
KristofferC
rouson
tjhei
chrisrichardson
vijaysm
likask

but we would be happy with any other reviewer you consider relevant.

diehlpk commented 4 weeks ago

@editorialbot add @diehlpk as editor

editorialbot commented 4 weeks ago

Assigned! @diehlpk is now the editor

diehlpk commented 2 weeks ago

Hi @PetrKryslUCSD do you have time to review this paper?

diehlpk commented 2 weeks ago

Hi @likask do you have time to review this paper?

diehlpk commented 2 weeks ago

Hi @Leticia-maria do you have time to review this paper?

Leticia-maria commented 2 weeks ago

Hi @Leticia-maria do you have time to review this paper?

Yes! I can review it by the end of next week.

PetrKryslUCSD commented 2 weeks ago

Hi @PetrKryslUCSD do you have time to review this paper?

Yes.

diehlpk commented 2 weeks ago

@editorialbot add @PetrKryslUCSD as reviewer

editorialbot commented 2 weeks ago

@PetrKryslUCSD added to the reviewers list!

diehlpk commented 2 weeks ago

@editorialbot add @Leticia-maria as reviewer

editorialbot commented 2 weeks ago

@Leticia-maria added to the reviewers list!

diehlpk commented 2 weeks ago

@editorialbot start review

editorialbot commented 2 weeks ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/7162.

openjournals / joss-reviews

[PRE REVIEW]: GridapSolvers.jl: Scalable multiphysics finite element solvers in Julia #7126

Status