openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: wrenfold: Symbolic code generation for robotics #7130

Closed editorialbot closed 1 month ago

editorialbot commented 2 months ago

Submitting author: !--author-handle-->@gareth-cross<!--end-author-handle-- (Gareth Cross) Repository: https://github.com/wrenfold/wrenfold Branch with paper.md (empty if default branch): gareth/joss Version: v0.0.7 Editor: !--editor-->@boisgera<!--end-editor-- Reviewers: @ushu, @abougouffa Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/783b80991d243d90e0346e2ddf9f1483"><img src="https://joss.theoj.org/papers/783b80991d243d90e0346e2ddf9f1483/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/783b80991d243d90e0346e2ddf9f1483/status.svg)](https://joss.theoj.org/papers/783b80991d243d90e0346e2ddf9f1483)

Author instructions

Thanks for submitting your paper to JOSS @gareth-cross. Currently, there isn't a JOSS editor assigned to your paper.

@gareth-cross if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.18 s (2040.7 files/s, 286442.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C++                            104           3290           2160          17824
C/C++ Header                   110           2716           2577          10053
Python                          36            994           1078           3118
Rust                            19            296            320           2495
CMake                           23            118            111            941
reStructuredText                30            618           1074            575
YAML                            11             70             16            405
Markdown                         9             86              0            285
TOML                            11             35              6            208
TeX                              1              7              0             69
DOS Batch                        2             10              1             35
HTML                             8              0              0             16
JSON                             1              0              0             12
make                             1              4              7              9
Bourne Shell                     1              2              3              7
SVG                              1              0              1              3
-------------------------------------------------------------------------------
SUM:                           368           8246           7354          36055
-------------------------------------------------------------------------------

Commit count by author:

   227  Gareth
    24  gareth-cross
     1  Himel Mondal
editorialbot commented 2 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.15607/RSS.2022.XVIII.041 is OK
- 10.5281/zenodo.5794541 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Ceres Solver
- No DOI given, and none found for title: State estimation for Robotics
- No DOI given, and none found for title: Modern Robotics: Mechanics, planning, and Control
- No DOI given, and none found for title: SymEngine
- No DOI given, and none found for title: Open-sourcing SymForce

❌ MISSING DOIs

- 10.1109/iros.2017.8202230 may be a valid DOI for title: FROST: Fast Robot Optimization and Simulation Tool...

❌ INVALID DOIs

- None
editorialbot commented 2 months ago

Paper file info:

📄 Wordcount for paper.md is 1182

✅ The paper includes a Statement of need section

editorialbot commented 2 months ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 2 months ago

:warning: An error happened when generating the pdf.

crvernon commented 2 months ago

@editorialbot invite @boisgera as editor

:wave: @boisgera - can you take this one on as editor?

editorialbot commented 2 months ago

Invitation to edit this submission sent!

crvernon commented 2 months ago

:wave: @gareth-cross - I believe the compilation of your paper is failing because you are missing an affiliation declaration. Could you take a look at this? Thanks.

gareth-cross commented 2 months ago

👋 @gareth-cross - I believe the compilation of your paper is failing because you are missing an affiliation declaration. Could you take a look at this? Thanks.

Updated with affiliation section, thanks.

@editorialbot generate pdf

crvernon commented 2 months ago

@editorialbot generate pdf

editorialbot commented 2 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 2 months ago

Five most similar historical JOSS papers:

Automatic Computation for Robot Design (ACRoD): A Python package for numerical calculation of Jacobian of a robot at a given configuration around a specified end-effector point Submitting author: @suneeshjacob Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @gfadini, @CameronDevine, @JHartzer Similarity score: 0.6324

dcgp: Differentiable Cartesian Genetic Programming made easy. Submitting author: @darioizzo Handling editor: @VivianePons (Retired) Reviewers: @Ohjeah, @shah314 Similarity score: 0.6262

BridgeStan: Efficient in-memory access to the methods of a Stan model Submitting author: @roualdes Handling editor: @Nikoleta-v3 (Active) Reviewers: @salleuska, @saumil-sh Similarity score: 0.6257

Efficient Polyhedral Gravity Modeling in Modern C++ and Python Submitting author: @schuhmaj Handling editor: @dfm (Active) Reviewers: @mikegrudic, @santisoler Similarity score: 0.6208

CoreRobotics: An object-oriented C++ library with cross-language wrappers for cross-platform robot control Submitting author: @CoreRobotics Handling editor: @danielskatz (Active) Reviewers: @bmagyar @amjaeger17 Similarity score: 0.6110

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

boisgera commented 2 months ago

@editorialbot invite @boisgera as editor

👋 @boisgera - can you take this one on as editor?

Yes, sure! You may need to increase my max number of papers from 4 to 5 (if this limit is automatically enforced).

boisgera commented 2 months ago

@editorialbot assign @boisgera as editor

editorialbot commented 2 months ago

Assigned! @boisgera is now the editor

boisgera commented 2 months ago

@editorialbot add @ushu as reviewer

editorialbot commented 2 months ago

@ushu added to the reviewers list!

boisgera commented 1 month ago

For the record: a couple of academics in my university declined to review the project; I am contacting a new batch of potential reviewers internally.

gareth-cross commented 1 month ago

I am contacting a new batch of potential reviewers internally.

Ok, thank you @boisgera.

gareth-cross commented 1 month ago

@boisgera Per the suggestion in the original post, I scrolled through the list of reviewers and picked a few that might be roughly suitable for this project, based on background:

gareth-cross commented 1 month ago

Hi @boisgera - any updates? I can trawl through the list again and find some more names if need be.

boisgera commented 1 month ago

Hi @boisgera - any updates? I can trawl through the list again and find some more names if need be.

Hi @gareth-cross, sorry for the delay.

I have not received any answer from my previous batch of invites (in my institution).

I have not tried any names in the editorial bot suggestion list or your own list yet ; I'll start to invite people from theses sources today (starting with your list).

Best regards,

Sébastien

boisgera commented 1 month ago

@editorialbot add @abougouffa as reviewer

Abdelhak Bougouffa has accepted to review the project. Thank you ! 🙏

editorialbot commented 1 month ago

@abougouffa added to the reviewers list!

boisgera commented 1 month ago

@editorialbot start review

editorialbot commented 1 month ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/7303.

gareth-cross commented 1 month ago

Thank you @boisgera and @abougouffa

editorialbot commented 42 minutes ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 41 minutes ago

Five most similar historical JOSS papers:

BridgeStan: Efficient in-memory access to the methods of a Stan model Submitting author: @roualdes Handling editor: @Nikoleta-v3 (Active) Reviewers: @salleuska, @saumil-sh Similarity score: 0.6210

dcgp: Differentiable Cartesian Genetic Programming made easy. Submitting author: @darioizzo Handling editor: @VivianePons (Retired) Reviewers: @Ohjeah, @shah314 Similarity score: 0.6127

Automatic Computation for Robot Design (ACRoD): A Python package for numerical calculation of Jacobian of a robot at a given configuration around a specified end-effector point Submitting author: @suneeshjacob Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @gfadini, @CameronDevine, @JHartzer Similarity score: 0.6126

Efficient Polyhedral Gravity Modeling in Modern C++ and Python Submitting author: @schuhmaj Handling editor: @dfm (Active) Reviewers: @mikegrudic, @santisoler Similarity score: 0.6032

cppduals: a nestable vectorized templated dual number library for C++11 Submitting author: @tesch1 Handling editor: @danielskatz (Active) Reviewers: @StewMH, @mdavezac Similarity score: 0.5981

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.