openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
712 stars 38 forks source link

[PRE REVIEW]: AstronomyCalc: A python toolkit for teaching Astronomical Calculations and Data Analysis methods #7160

Closed editorialbot closed 4 weeks ago

editorialbot commented 4 weeks ago

Submitting author: !--author-handle-->@sambit-giri<!--end-author-handle-- (Sambit Kumar Giri) Repository: https://github.com/sambit-giri/AstronomyCalc Branch with paper.md (empty if default branch): Version: v1.0 Editor: Pending Reviewers: Pending Managing EiC: Dan Foreman-Mackey

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e2b92da4813ab306e127d12878fa3177"><img src="https://joss.theoj.org/papers/e2b92da4813ab306e127d12878fa3177/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e2b92da4813ab306e127d12878fa3177/status.svg)](https://joss.theoj.org/papers/e2b92da4813ab306e127d12878fa3177)

Author instructions

Thanks for submitting your paper to JOSS @sambit-giri. Currently, there isn't a JOSS editor assigned to your paper.

@sambit-giri if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 4 weeks ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 4 weeks ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.05 s (979.5 files/s, 219040.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Jupyter Notebook                 9              0           6172           2208
Python                          16            219            382            607
TeX                              1             27              0            324
Markdown                         5             61              0            126
YAML                             4             19             26            110
reStructuredText                 9             46             38             95
make                             1              4              7              9
Bourne Shell                     2              6             17              7
-------------------------------------------------------------------------------
SUM:                            47            382           6642           3486
-------------------------------------------------------------------------------

Commit count by author:

   109  sambit-giri
     9  Sambit Kumar Giri
editorialbot commented 4 weeks ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.physrep.2006.08.002 is OK
- 10.1088/0034-4885/75/8/086901 is OK
- 10.1111/j.1365-2966.2012.21293.x is OK
- 10.1093/mnras/stx2539 is OK
- 10.1093/mnras/stt1341 is OK
- 10.1093/mnras/stv2679 is OK
- 10.1093/mnras/stx649 is OK
- 10.1093/mnras/stz1220 is OK
- 10.1093/mnras/stz2224 is OK
- 10.1088/1475-7516/2019/02/058 is OK
- 10.1093/mnras/sty1786 is OK
- 10.1093/mnras/stv571 is OK
- 10.1007/s10686-013-9334-5 is OK
- 10.1051/0004-6361/201220873 is OK
- 10.1017/pasa.2018.37 is OK
- 10.1017/pasa.2012.007 is OK
- 10.1109/JPROC.2009.2017564 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Towards a science of the art of teaching: Using va...
- No DOI given, and none found for title: Variation theory and the improvement of teaching a...
- No DOI given, and none found for title: Introduction to cosmology
- No DOI given, and none found for title: The Pantheon+ analysis: cosmological constraints
- No DOI given, and none found for title: The metropolis—hastings algorithm
- No DOI given, and none found for title: Tomographic studies of the 21-cm signal during rei...
- No DOI given, and none found for title: Hydrogen epoch of reionization array (HERA)

❌ MISSING DOIs

- 10.1109/cidu.2012.6382200 may be a valid DOI for title: Introduction to astroML: Machine learning for astr...
- 10.3847/0004-6256/152/6/157 may be a valid DOI for title: SPARC: Mass models for 175 disk galaxies with Spit...

❌ INVALID DOIs

- None
editorialbot commented 4 weeks ago

Paper file info:

📄 Wordcount for paper.md is 940

✅ The paper includes a Statement of need section

editorialbot commented 4 weeks ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 4 weeks ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 4 weeks ago

Five most similar historical JOSS papers:

ZodiPy: A Python package for zodiacal light simulations Submitting author: @MetinSa Handling editor: @dfm (Active) Reviewers: @dfm Similarity score: 0.7550

deeplenstronomy: A dataset simulation package for strong gravitational lensing Submitting author: @rmorgan10 Handling editor: @pdebuyl (Active) Reviewers: @shreyasbapat, @jiwoncpark Similarity score: 0.7346

The Python Sky Model 3 software Submitting author: @zonca Handling editor: @christinahedges (Retired) Reviewers: @patricialarsen, @smsharma Similarity score: 0.7304

scida: scalable analysis for scientific big data Submitting author: @cbyrohl Handling editor: @mbobra (Active) Reviewers: @egaraldi, @kyleaoman Similarity score: 0.7292

MARTINI: Mock Array Radio Telescope Interferometry of the Neutral ISM Submitting author: @kyleaoman Handling editor: @dfm (Active) Reviewers: @dfm Similarity score: 0.7249

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

dfm commented 4 weeks ago

@editorialbot query scope

@sambit-giri — Thanks for your submission! Given the fact that this project is focused on education rather than research astrophysics, I have submitted this pre-review for editorial review. This usually takes a week or two and I'll report back here as soon as I hear back from the rest of the editorial board.

My initial reaction is that this might be a better fit for the Journal of Open Source Education, but please feel free to add some more context here if you think this is consistent with our submission requirements.

editorialbot commented 4 weeks ago

Submission flagged for editorial review.

sambit-giri commented 4 weeks ago

@dfm Thank you for the suggestion. I agree that this submission is a better fit for the Journal of Open Source Education. Apologies for not being aware of this dedicated journal for educational tools. Should I create a new submission in the other journal?

dfm commented 4 weeks ago

No problem! That probably makes sense. Let me withdraw this submission and you can submit over there.

dfm commented 4 weeks ago

@editorialbot withdraw

editorialbot commented 4 weeks ago

Paper withdrawn.