openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: tempodisco: an R package for temporal discounting #7170

Closed editorialbot closed 2 weeks ago

editorialbot commented 2 months ago

Submitting author: !--author-handle-->@kinleyid<!--end-author-handle-- (Isaac Kinley) Repository: https://github.com/kinleyid/tempodisco/ Branch with paper.md (empty if default branch): Version: v0.1.0 Editor: !--editor-->@skanwal<!--end-editor-- Reviewers: @bkrayfield, @marberts Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/64e0b475f3e3c0a1b6ac7cdd907f9e63"><img src="https://joss.theoj.org/papers/64e0b475f3e3c0a1b6ac7cdd907f9e63/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/64e0b475f3e3c0a1b6ac7cdd907f9e63/status.svg)](https://joss.theoj.org/papers/64e0b475f3e3c0a1b6ac7cdd907f9e63)

Author instructions

Thanks for submitting your paper to JOSS @kinleyid. Currently, there isn't a JOSS editor assigned to your paper.

@kinleyid if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.06 s (826.3 files/s, 307283.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                      11           2546           2638           9642
R                               15            261            624           1285
Rmd                              8            118            284            198
Markdown                         2             40              0            107
YAML                             3             22              9            106
CSS                              8             29             41            104
TeX                              1              8              0             84
Sass                             1              4              0             71
-------------------------------------------------------------------------------
SUM:                            49           3028           3596          11597
-------------------------------------------------------------------------------

Commit count by author:

    74  Isaac Kinley
editorialbot commented 2 months ago

Paper file info:

📄 Wordcount for paper.md is 375

✅ The paper includes a Statement of need section

editorialbot commented 2 months ago

License info:

🔴 Failed to discover a valid open source license

editorialbot commented 2 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- None

🟡 SKIP DOIs

- No DOI given, and none found for title: An algorithm for identifying nonsystematic delay-d...
- No DOI given, and none found for title: R^2 should not be used to describe behavioral-econ...

❌ MISSING DOIs

- 10.1037//0096-3445.128.1.78 may be a valid DOI for title: Heroin addicts have higher discount rates for dela...
- 10.3758/bf03195548 may be a valid DOI for title: Using logistic regression to estimate delay-discou...
- 10.1002/jeab.128 may be a valid DOI for title: Accurate characterization of delay discounting: A ...
- 10.1901/jeab.2001.76-235 may be a valid DOI for title: Area under the curve as a measure of discounting
- 10.1016/j.drugalcdep.2007.12.011 may be a valid DOI for title: Turning k on its head: Comments on use of an ED50 ...
- 10.3791/53584-v may be a valid DOI for title: Measuring delay discounting in humans using an adj...
- 10.1017/s0033291721002282 may be a valid DOI for title: The problems with delay discounting: A critical re...

❌ INVALID DOIs

- None
editorialbot commented 2 months ago

:warning: An error happened when generating the pdf. Problem with ORCID (0000-0000-0000-0000) for Isaac Kinley. Invalid ORCID.

kinleyid commented 2 months ago

@editorialbot commands

editorialbot commented 2 months ago

Hello @kinleyid, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers
kinleyid commented 2 months ago

@editorialbot check repository

editorialbot commented 2 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.06 s (862.0 files/s, 324540.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                      11           2546           2638           9642
R                               15            261            624           1285
Markdown                         3            150              0            592
Rmd                              8            118            284            198
YAML                             3             22              9            106
CSS                              8             29             41            104
TeX                              1              8              0             93
Sass                             1              4              0             71
-------------------------------------------------------------------------------
SUM:                            50           3138           3596          12091
-------------------------------------------------------------------------------

Commit count by author:

    76  Isaac Kinley
editorialbot commented 2 months ago

Paper file info:

📄 Wordcount for paper.md is 369

✅ The paper includes a Statement of need section

editorialbot commented 2 months ago

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

kinleyid commented 2 months ago

@editorialbot generate pdf

editorialbot commented 2 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 2 months ago

Five most similar historical JOSS papers:

BCEA: An R Package for Cost-Effectiveness Analysis Submitting author: @n8thangreen Handling editor: @ajstewartlang (Active) Reviewers: @rowlandseymour, @MikeLydeamore Similarity score: 0.6941

The psycho Package: an Efficient and Publishing-Oriented Workflow for Psychological Science Submitting author: @DominiqueMakowski Handling editor: @leeper (Retired) Reviewers: @SachaEpskamp Similarity score: 0.6885

measr: Bayesian psychometric measurement using Stan Submitting author: @wjakethompson Handling editor: @chartgerink (Retired) Reviewers: @smasongarrison, @Wenchao-Ma, @seandamiandevine Similarity score: 0.6714

TDLM: An R package for a systematic comparison of trip distribution laws and models Submitting author: @maximelenormand Handling editor: @crvernon (Active) Reviewers: @kanishkan91, @MAnalytics Similarity score: 0.6676

PupillometryR: An R package for preparing and analysing pupillometry data Submitting author: @samhforbes Handling editor: @oliviaguest (Active) Reviewers: @paulinepalma, @Athanasiamo Similarity score: 0.6666

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

kinleyid commented 2 months ago

Hello, I'd like to add something I forgot to mention in the submission note---in addition to being under review, the paper that used an early version of this software also exists as a preprint that contains a link to said early version: https://doi.org/10.31234/osf.io/y2fdh

crvernon commented 2 months ago

@editorialbot invite @skanwal as editor

:wave: @skanwal - can you take this one on as editor?

editorialbot commented 2 months ago

Invitation to edit this submission sent!

skanwal commented 2 months ago

Hi @crvernon - Yes, I can take this one.

crvernon commented 2 months ago

@editorialbot assign @skanwal as editor

Thanks @skanwal!

editorialbot commented 2 months ago

Assigned! @skanwal is now the editor

kinleyid commented 2 months ago

Hello, just wanted to suggest some reviewers with R + decision making research expertise:

skanwal commented 2 months ago

Hello @PessoaP - will you be happy to review this submission?

skanwal commented 2 months ago

Hello @bkrayfield, will you be happy to review this submission?

kinleyid commented 3 weeks ago

Hello, just popping back in to suggest some more reviewers:

bkrayfield commented 3 weeks ago

@skanwal I can review the submission.

skanwal commented 3 weeks ago

@editorialbot assign @bkrayfield as reviewer

editorialbot commented 3 weeks ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

skanwal commented 3 weeks ago

@editorialbot commands

editorialbot commented 3 weeks ago

Hello @skanwal, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Add to this issue's reviewers list
@editorialbot add @username as reviewer

# Remove from this issue's reviewers list
@editorialbot remove @username from reviewers

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Assign a user as the editor of this submission
@editorialbot assign @username as editor

# Remove the editor assigned to this submission
@editorialbot remove editor

# Remind an author, a reviewer or the editor to return to a review after a 
# certain period of time (supported units days and weeks)
@editorialbot remind @reviewer in 2 weeks

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for version
@editorialbot set v1.0.0 as version

# Set a value for branch
@editorialbot set joss-paper as branch

# Set a value for repository
@editorialbot set https://github.com/organization/repo as repository

# Set a value for the archive DOI
@editorialbot set 10.5281/zenodo.6861996 as archive

# Mention the EiCs for the correct track
@editorialbot ping track-eic

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Recommends the submission for acceptance
@editorialbot recommend-accept

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Flag submission with questionable scope
@editorialbot query scope

# Get a link to the complete list of reviewers
@editorialbot list reviewers

# Creates a post-review checklist with editor and authors tasks
@editorialbot create post-review checklist

# Open the review issue
@editorialbot start review
skanwal commented 3 weeks ago

@editorialbot add @bkrayfield as reviewer

editorialbot commented 3 weeks ago

@bkrayfield added to the reviewers list!

skanwal commented 3 weeks ago

Hello @mashrur-ayon - will you be happy to review this submission?

editorialbot commented 3 weeks ago

Checklists can only be created once the review has started in the review issue

kinleyid commented 3 weeks ago

@editorialbot check repository

editorialbot commented 3 weeks ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.06 s (990.2 files/s, 326602.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                      11           2546           2638           9642
R                               18            364            857           1688
Markdown                         3            177              0            788
Rmd                             15            214            429            273
YAML                             4             23              9            109
CSS                              8             29             41            104
TeX                              1              9              0            104
Sass                             1              4              0             71
-------------------------------------------------------------------------------
SUM:                            61           3366           3974          12779
-------------------------------------------------------------------------------

Commit count by author:

   102  Isaac Kinley
editorialbot commented 3 weeks ago

Paper file info:

📄 Wordcount for paper.md is 377

✅ The paper includes a Statement of need section

editorialbot commented 3 weeks ago

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

kinleyid commented 3 weeks ago

@editorialbot check repository

Re-checking the repository since I made a few changes to it recently!

skanwal commented 2 weeks ago

Hello @mashrur-ayon - pinging again in case you missed the previous notification. Will you be happy to review this submission?

skanwal commented 2 weeks ago

Hello - @marberts - are you able to review this submission for us?

marberts commented 2 weeks ago

@skanwal Yes, I can review.

skanwal commented 2 weeks ago

@editorialbot add @marberts as reviewer

editorialbot commented 2 weeks ago

@marberts added to the reviewers list!

skanwal commented 2 weeks ago

Thanks @bkrayfield and @marberts. I'll create a review issue for this submission.

skanwal commented 2 weeks ago

@editorialbot start review

editorialbot commented 2 weeks ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/7472.