[PRE REVIEW]: lintr: Static Code Analysis for R

[editorialbot]

Submitting author: !--author-handle-->@jimhester<!--end-author-handle-- (James Hester) Repository: https://github.com/r-lib/lintr Branch with paper.md (empty if default branch): Version: v3.1.2 Editor: !--editor-->@lrnv<!--end-editor-- Reviewers: @JosiahParry, @SaranjeetKaur Managing EiC: Chris Vernon

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0f4eccbd59ee5bf5a5be88489581970f"><img src="https://joss.theoj.org/papers/0f4eccbd59ee5bf5a5be88489581970f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0f4eccbd59ee5bf5a5be88489581970f/status.svg)](https://joss.theoj.org/papers/0f4eccbd59ee5bf5a5be88489581970f)

Author instructions

Thanks for submitting your paper to JOSS @jimhester. Currently, there isn't a JOSS editor assigned to your paper.

@jimhester if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.21105/joss.01686 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: The Tidyverse Style Guide
- No DOI given, and none found for title: R: A Language and Environment for Statistical Comp...
- No DOI given, and none found for title: Code Complete
- No DOI given, and none found for title: Static program analysis — Wikipedia, The Free Ency...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=0.15 s (2436.8 files/s, 307421.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                              333           4197           8303          28595
XML                              2              0            129           1797
Markdown                        10            360              0           1460
YAML                            13             83             53            433
Rmd                             10            372            877            200
CSV                              1              0              0            124
JSON                             2              0              0             61
vim script                       1             14             21             50
TeX                              1              4              0             37
Dockerfile                       1              3              0             11
-------------------------------------------------------------------------------
SUM:                           374           5033           9383          32768
-------------------------------------------------------------------------------

Commit count by author:

   582  Michael Chirico
   381  Jim Hester
   210  Indrajeet Patil
   155  AshesITR
    88  Alexander Rosenstock
    57  Florent Angly
    46  Kun Ren
    24  Russ Hyde
    13  Kirill Müller
    10  Dragoș Moldovan-Grünfeld
     8  Forest Fang
     8  Hugo Gruson
     7  Gábor Csárdi
     7  MEO265
     7  Michael Quinn
     7  Russell Hyde
     7  dependabot[bot]
     6  Barret Schloerke
     5  Salim B
     4  JhossePaul
     4  Jonathan Keane
     4  jrnold
     3  Bruce Lee
     3  Daniel Possenriede
     3  Fabian Scheipl
     3  Jennifer (Jenny) Bryan
     3  Konrad Pagacz
     3  Laurent Gatto
     3  eitsupi
     3  huisman
     3  nathaneastwood
     3  olivroy
     2  Alex Branham
     2  Ashley Baldry
     2  Chris Black
     2  Dan Kessler
     2  F-Noelle
     2  Iñaki Úcar
     2  Jack Wasey
     2  Konrad Rudolph
     2  Maëlle Salmon
     2  Micah J Waldstein
     2  Rafael Zayas
     2  dmurdoch
     1  Alessandro Gentilini
     1  Alexis Iglauer
     1  Andrew Choi
     1  Andrés Felipe Quintero Moreano
     1  Anton Bossenbroek
     1  Bernie Gray
     1  Brandon Bertelsen
     1  Christian Diener
     1  Colin Rundel
     1  Daniel Sabanes Bove
     1  Dave Lovell
     1  Derek Chiu
     1  Dragos Moldovan-Grunfeld
     1  Ellis Valentiner
     1  Fleur Kelpin
     1  Florian Kohrt
     1  Frans van Dunné
     1  Frédéric Mahé
     1  Gabor Csardi
     1  Gabriela de Queiroz
     1  Guillaume Gaullier
     1  Hadley Wickham
     1  Hannah Frick
     1  Hao Ye
     1  Hedley
     1  Henning Lorenzen
     1  Hiroaki Yutani
     1  JJ Allaire
     1  James Baird
     1  Jamie Owen
     1  Jeffrey Arnold
     1  Jenny Bryan
     1  Jeremy Werner
     1  Jon Harmon
     1  Josh
     1  Kara Woo
     1  Landon Abney
     1  Leonardo Gama
     1  Mara Averick
     1  Marcel Schilling
     1  Marie-Helene Burle
     1  Mark Miller
     1  Matt Brennan
     1  Matthew T. Warkentin
     1  Nic
     1  Nicholas Masel
     1  Paolo Di Lorenzo
     1  Paul Kaefer
     1  Paul Staab
     1  Randy Lai
     1  Shaopeng
     1  StefanBRas
     1  Stu Field
     1  The Gitter Badger
     1  Tony Kenny
     1  Wesley Burr
     1  Will Landau
     1  Yu ISHIKAWA
     1  Yuu ISHIKAWA
     1  arekbee
     1  banky
     1  bernie gray
     1  jeffwong-nflx
     1  jmaspons
     1  ttriche

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 1463

✅ The paper includes a Statement of need section

[editorialbot]

License info:

🟡 License found: Other (Check here for OSI approval)

[editorialbot]

:warning: An error happened when generating the pdf. Author (Florent Angly) is missing affiliation.

[IndrajeetPatil]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[editorialbot]

Five most similar historical JOSS papers:

quanteda: An R package for the quantitative analysis of textual data Submitting author: @kenbenoit Handling editor: @arfon (Active) Reviewers: @lmullen, @borishejblum, @alexgarciac Similarity score: 0.6375

TextDescriptives: A Python package for calculating a large variety of metrics from text Submitting author: @HLasse Handling editor: @fabian-s (Active) Reviewers: @RichardLitt, @linuxscout Similarity score: 0.6274

Welcome to the Tidyverse Submitting author: @hadley Handling editor: @karthik (Retired) Reviewers: @ldecicco-USGS, @jeffreyhanson Similarity score: 0.6219

glottospace: R package for language mapping and geospatial analysis of linguistic and cultural data Submitting author: @SietzeN Handling editor: @ajstewartlang (Active) Reviewers: @fauxneticien, @skalyan91 Similarity score: 0.6195

LinRegOutliers: A Julia package for detecting outliers in linear regression Submitting author: @jbytecode Handling editor: @mikldk (Retired) Reviewers: @salleuska, @rMassimiliano Similarity score: 0.6191

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

[jimhester]

~@IndrajeetPatil You may want to look and see if we can resolve the issues flagged in this thread, particularly the license and author information above (though I do not know Florent Angly's affiliation)~

Never mind, I now see you have already handled this, appreciate you being on top of it and thanks!

[MichaelChirico]

thanks for flagging @jimhester! it was (partially) fixed already: https://github.com/r-lib/lintr/pull/2651

this comment is the updated paper:

https://github.com/openjournals/joss-reviews/issues/7171#issuecomment-2332273061

[lrnv]

@crvernon you mind If I assign myself as editor on this one ?

[crvernon]

@editorialbot assign @lrnv as editor

Thanks @lrnv!

[editorialbot]

Assigned! @lrnv is now the editor

[lrnv]

@jimhester Happy to be your editor for this meaningful package in the R realm.

To start off, would you be able to recommend a few potential reviewers for this ? For example if you have people that you know will give you interesting input on the submission, that might fit.

[jimhester]

https://reviewers.joss.theoj.org/reviewers/720, https://reviewers.joss.theoj.org/reviewers/1337 are a couple I noticed from a brief look. Josiah and I overlapped at RStudio a bit as a potential COI, but we never worked on any projects together and have both been gone from RStudio for > 2.5 years.

@MichaelChirico or @IndrajeetPatil do you have any other reviewer suggestions?

[MichaelChirico]

Also looked briefly; maybe https://reviewers.joss.theoj.org/reviewers/2436 who has worked on the R Dev Guide & other R forwards initiatives

[lrnv]

Okay then, @njtierney, @josiahparry, @SaranjeetKaur would any of you be willing to review r-lib/lintr for JOSS ? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: joss.readthedocs.io/en/latest/review_criteria.html

[SaranjeetKaur]

I would love to! Thanks!

[JosiahParry]

Thanks for thinking of me :) Yes, I would be happy to submit a review.

[lrnv]

@editorialbot add @JosiahParry as reviewer

[editorialbot]

@JosiahParry added to the reviewers list!

[lrnv]

@editorialbot add @SaranjeetKaur as reviewer

[editorialbot]

@SaranjeetKaur added to the reviewers list!

[lrnv]

@editorialbot start review

[editorialbot]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/7240.