openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: Mashpit: sketching out genomic epidemiology #7235

Closed editorialbot closed 1 month ago

editorialbot commented 1 month ago

Submitting author: !--author-handle-->@tongzhouxu<!--end-author-handle-- (Tongzhou Xu) Repository: https://github.com/tongzhouxu/mashpit Branch with paper.md (empty if default branch): Version: v0.9.7 Editor: !--editor-->@csoneson<!--end-editor-- Reviewers: @hkaspersen, @mberacochea Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/760af75d515b1bc3d2fc87085fe79b92"><img src="https://joss.theoj.org/papers/760af75d515b1bc3d2fc87085fe79b92/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/760af75d515b1bc3d2fc87085fe79b92/status.svg)](https://joss.theoj.org/papers/760af75d515b1bc3d2fc87085fe79b92)

Author instructions

Thanks for submitting your paper to JOSS @tongzhouxu. Currently, there isn't a JOSS editor assigned to your paper.

@tongzhouxu if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 month ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 month ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

βœ… OK DOIs

- 10.21105/joss.00027 is OK

🟑 SKIP DOIs

- No DOI given, and none found for title: Mash: fast genome and metagenome distance estimati...
- No DOI given, and none found for title: BLAST+: architecture and applications
- No DOI given, and none found for title: SeqSero2: rapid and improved Salmonella serotype d...
- No DOI given, and none found for title: The EnteroBase user’s guide, with case studies on ...

❌ MISSING DOIs

- 10.1093/bioinformatics/bty407 may be a valid DOI for title: Nextstrain: real-time tracking of pathogen evoluti...
- 10.2807/1560-7917.es.2017.22.23.30544 may be a valid DOI for title: PulseNet International: Vision for the implementat...
- 10.3389/fmicb.2017.00375 may be a valid DOI for title: A comparative analysis of the Lyve-SET phylogenomi...

❌ INVALID DOIs

- None
editorialbot commented 1 month ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.02 s (1021.4 files/s, 91690.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           8            138            158           1050
Markdown                         2             45              0            192
HTML                             4             11              2            155
YAML                             4             11             11             97
TeX                              1              9              0             81
JavaScript                       2              0              7              2
CSS                              1              0              5              1
-------------------------------------------------------------------------------
SUM:                            22            214            183           1578
-------------------------------------------------------------------------------

Commit count by author:

   146  Tongzhou Xu
    14  tongzhouxu
     7  dependabot[bot]
     3  Lee Katz
     1  Lee Katz - Aspen
     1  Lee Katz gzu2
editorialbot commented 1 month ago

Paper file info:

πŸ“„ Wordcount for paper.md is 1217

βœ… The paper includes a Statement of need section

editorialbot commented 1 month ago

License info:

🟑 License found: GNU General Public License v2.0 (Check here for OSI approval)

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 month ago

Five most similar historical JOSS papers:

Sepia, a taxonomy oriented read classifier in Rust Submitting author: @hcdenbakker Handling editor: @will-rowe (Retired) Reviewers: @Ebedthan, @telatin Similarity score: 0.7201

ALPPACA - A tooL for Prokaryotic Phylogeny And Clustering Analysis Submitting author: @hkaspersen Handling editor: @csoneson (Active) Reviewers: @mberacochea, @hseabolt, @rcannood Similarity score: 0.7082

NCBImeta: efficient and comprehensive metadata retrieval from NCBI databases Submitting author: @ktmeaton Handling editor: @lpantano (Active) Reviewers: @coughls, @druvus Similarity score: 0.7064

SneakerNet: A modular quality assurance and quality check workflow for primary genomic and metagenomic read data Submitting author: @lskatz Handling editor: @lpantano (Active) Reviewers: @lfaller, @erinyoung, @druvus Similarity score: 0.7000

Finch: a tool adding dynamic abundance filtering to genomic MinHashing Submitting author: @bovee Handling editor: @biorelated (Retired) Reviewers: @HadrienG Similarity score: 0.6991

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

tongzhouxu commented 1 month ago

@editorialbot generate pdf

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 month ago

Five most similar historical JOSS papers:

Sepia, a taxonomy oriented read classifier in Rust Submitting author: @hcdenbakker Handling editor: @will-rowe (Retired) Reviewers: @Ebedthan, @telatin Similarity score: 0.7202

ALPPACA - A tooL for Prokaryotic Phylogeny And Clustering Analysis Submitting author: @hkaspersen Handling editor: @csoneson (Active) Reviewers: @mberacochea, @hseabolt, @rcannood Similarity score: 0.7084

NCBImeta: efficient and comprehensive metadata retrieval from NCBI databases Submitting author: @ktmeaton Handling editor: @lpantano (Active) Reviewers: @coughls, @druvus Similarity score: 0.7065

SneakerNet: A modular quality assurance and quality check workflow for primary genomic and metagenomic read data Submitting author: @lskatz Handling editor: @lpantano (Active) Reviewers: @lfaller, @erinyoung, @druvus Similarity score: 0.7000

Finch: a tool adding dynamic abundance filtering to genomic MinHashing Submitting author: @bovee Handling editor: @biorelated (Retired) Reviewers: @HadrienG Similarity score: 0.6991

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

tongzhouxu commented 1 month ago

@editorialbot check references

editorialbot commented 1 month ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

βœ… OK DOIs

- 10.1093/bioinformatics/bty407 is OK
- 10.2807/1560-7917.es.2017.22.23.30544 is OK
- 10.1186/s13059-016-0997-x is OK
- 10.21105/joss.00027 is OK
- 10.1186/1471-2105-10-421 is OK
- 10.1128/aem.01746-19 is OK
- 10.1101/gr.251678.119 is OK
- 10.3389/fmicb.2017.00375 is OK

🟑 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
Kevin-Mattheus-Moerman commented 1 month ago

@tongzhouxu Dear author, thanks for this submission. I am the AEiC on this track and here to help process the initial steps. Before we proceed, please can you have a look at the following points:

Kevin-Mattheus-Moerman commented 1 month ago

@editorialbot invite @csoneson as editor

editorialbot commented 1 month ago

Invitation to edit this submission sent!

tongzhouxu commented 1 month ago

@tongzhouxu Dear author, thanks for this submission. I am the AEiC on this track and here to help process the initial steps. Before we proceed, please can you have a look at the following points:

  • [ ] Your project appears to lack contributing guidelines at the moment. Please work to add these and to mention/link to them in your README. You could for instance create a CONTRIBUTING.md file (see here for some examples: https://contributing.md/example/).
  • [ ] In the paper, please spell out USA as United States of America.

Thank you for the suggestions. I have added a CONTRIBUTING.md in the latest commit.

csoneson commented 1 month ago

@editorialbot assign @csoneson as editor

editorialbot commented 1 month ago

Assigned! @csoneson is now the editor

csoneson commented 1 month ago

πŸ‘‹πŸ» @tongzhouxu - thanks for your submission. I will handle it from here, and start by finding two suitable reviewers. If you have any suggestions (e.g. from the list mentioned in the top comment), feel free to let me know.

csoneson commented 1 month ago

πŸ‘‹πŸ» @hkaspersen, @mberacochea, @ns-rse - would you be interested in reviewing this submission for JOSS?

Mashpit: sketching out genomic epidemiology https://github.com/openjournals/joss-reviews/issues/7235

Thanks in advance!

mberacochea commented 1 month ago

Hi @csoneson,

I'm happy to review this submission. However, I won't be able to start until next week at the earliest. If that is not a problem, I'm happy to proceed.

Cheers

hkaspersen commented 1 month ago

@csoneson Thank you for the invitation! I would be happy to review this. Where can I find review criteria etc?

csoneson commented 1 month ago

Hi @hkaspersen and @mberacochea - thanks a lot for accepting to review! I will assign you and start the review issue.

@mberacochea - next week is totally fine! @hkaspersen - you can find more information here. I'm starting the review issue now, and in there you will find more practical instructions, including how to create your checklist.

csoneson commented 1 month ago

@editorialbot add @hkaspersen as reviewer

editorialbot commented 1 month ago

@hkaspersen added to the reviewers list!

csoneson commented 1 month ago

@editorialbot add @mberacochea as reviewer

editorialbot commented 1 month ago

@mberacochea added to the reviewers list!

csoneson commented 1 month ago

@editorialbot start review

editorialbot commented 1 month ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/7306.