openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
707 stars 37 forks source link

[REVIEW]: PySLSQP: A transparent Python package for the SLSQP optimization algorithm modernized with utilities for visualization and post-processing #7246

Open editorialbot opened 1 day ago

editorialbot commented 1 day ago

Submitting author: !--author-handle-->@anugrahjo<!--end-author-handle-- (Anugrah Jo Joshy) Repository: https://github.com/anugrahjo/PySLSQP Branch with paper.md (empty if default branch): Version: v0.1.0 Editor: !--editor-->@prashjha<!--end-editor-- Reviewers: @hariharanragothaman, @saaikrishnan Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e32d83151cb75e75a31e18180b8f5f88"><img src="https://joss.theoj.org/papers/e32d83151cb75e75a31e18180b8f5f88/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e32d83151cb75e75a31e18180b8f5f88/status.svg)](https://joss.theoj.org/papers/e32d83151cb75e75a31e18180b8f5f88)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@hariharanragothaman & @saaikrishnan, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @prashjha know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

@hariharanragothaman, please create your checklist typing: @editorialbot generate my checklist

@saaikrishnan, please create your checklist typing: @editorialbot generate my checklist

editorialbot commented 1 day ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 day ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

βœ… OK DOIs

- 10.1145/192115.192124 is OK
- 10.1137/S0036144504446096 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.21105/joss.02564 is OK
- 10.1007/s00158-011-0666-3 is OK

🟑 SKIP DOIs

- No DOI given, and none found for title: A software package for sequential quadratic progra...
- No DOI given, and none found for title: The NLopt nonlinear-optimization package
- No DOI given, and none found for title: A MODular development environment and library for ...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
editorialbot commented 1 day ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 day ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (1168.4 files/s, 221031.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          14            405            817           1604
Fortran 77                       1            384            691           1115
Markdown                        14            191              0            814
TeX                              4             92             49            659
YAML                             5             58            105            247
Jupyter Notebook                 2              0           1021             75
TOML                             1              8             13             65
Meson                            2              8              3             34
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            45           1158           2707           4648
-------------------------------------------------------------------------------

Commit count by author:

    34  anugrahjo
editorialbot commented 1 day ago

Paper file info:

πŸ“„ Wordcount for paper.md is 2707

βœ… The paper includes a Statement of need section

editorialbot commented 1 day ago

License info:

βœ… License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

prashjha commented 1 day ago

Dear @hariharanragothaman and @saaikrishnan, please read the first couple of comments in this thread and create your review checklist. You can read the reviewer guidelines here. Also, you can browse the closed "REVIEW" issues on the "joss-reviews" repository to get some ideas on how to complete the reviews. Good luck!

hariharanragothaman commented 1 day ago

@prashjha Thanks a lot for the suggestions and guidelines! Will do the needful! βœ