openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: bayes_traj: A Python package for Bayesian trajectory analysis #7252

Closed editorialbot closed 1 month ago

editorialbot commented 1 month ago

Submitting author: !--author-handle-->@jcross186<!--end-author-handle-- (James Ross) Repository: https://github.com/acil-bwh/bayes_traj/ Branch with paper.md (empty if default branch): joss Version: v1.0.1 Editor: !--editor-->@majensen<!--end-editor-- Reviewers: @gvieralopez, @lindemann09 Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/2f99457ed2a1a9255eb65be5923f19be"><img src="https://joss.theoj.org/papers/2f99457ed2a1a9255eb65be5923f19be/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/2f99457ed2a1a9255eb65be5923f19be/status.svg)](https://joss.theoj.org/papers/2f99457ed2a1a9255eb65be5923f19be)

Author instructions

Thanks for submitting your paper to JOSS @jcross186. Currently, there isn't a JOSS editor assigned to your paper.

@jcross186 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 month ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 month ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.20 s (263.6 files/s, 451156.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSV                             11              0              0          76511
Python                          26           1178           1960           4743
Markdown                         7            395              0           2002
Jupyter Notebook                 5              0           5145            292
TeX                              1             16              0            139
YAML                             1              5              1             44
XML                              3              0              0              6
-------------------------------------------------------------------------------
SUM:                            54           1594           7106          83737
-------------------------------------------------------------------------------

Commit count by author:

   435  James Ross
    31  Fritz Obermeyer
     2  jcross186
     1  acil-bwh
editorialbot commented 1 month ago

Paper file info:

📄 Wordcount for paper.md is 663

✅ The paper includes a Statement of need section

editorialbot commented 1 month ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41592-019-0686-2 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: pandas-dev/pandas: Pandas 1.0. 5
- No DOI given, and none found for title: PyTorch: An Imperative Style, High-Performance Dee...
- No DOI given, and none found for title: Array programming with NumPy
- No DOI given, and none found for title: Longitudinal modeling of lung function trajectorie...
- No DOI given, and none found for title: Lung function trajectories in health and disease
- No DOI given, and none found for title: COPDGene\textregistered 2019: redefining the diagn...

❌ MISSING DOIs

- 10.2139/ssrn.3315029 may be a valid DOI for title: Bayesian estimation and model selection in group-b...
- 10.1016/j.alcr.2019.100323 may be a valid DOI for title: An overview of mixture modelling for latent evolut...
- 10.1164/ajrccm-conference.2022.205.1_meetingabstracts.a3725 may be a valid DOI for title: Dysanapsis Is Associated with COPD Trajectories At...
- 10.1109/tmi.2016.2608782 may be a valid DOI for title: A Bayesian nonparametric model for disease subtypi...
- 10.7196/10.2015.v21i3.83 may be a valid DOI for title: Lung-function trajectories leading to chronic obst...

❌ INVALID DOIs

- None
editorialbot commented 1 month ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 1 month ago

:warning: An error happened when generating the pdf.

Kevin-Mattheus-Moerman commented 1 month ago

@jcross186 Dear author, thanks for this submission. I am the AEiC on this track and here to help process the initial steps. Before we proceed, please can you have a look at the following points:

Kevin-Mattheus-Moerman commented 1 month ago

@jcross186 :wave:

jcross186 commented 1 month ago

Hi Kevin,

I have checked in changes that address previous issues. Please let me know if all looks good.

Kind regards,

-James

From: Kevin Mattheus Moerman @.> Date: Thursday, September 26, 2024 at 11:52 AM To: openjournals/joss-reviews @.> Cc: Ross, James Chapman,Ph.D. @.>, Mention @.> Subject: Re: [openjournals/joss-reviews] [PRE REVIEW]: bayes_traj: A Python package for Bayesian trajectory analysis (Issue #7252)

    External Email - Use Caution

@jcross186https://secure-web.cisco.com/1c6ujiesvXndssHe4z9iLsbGuCI4ww5aGc3UNTKyy4_wJ4iduKJT9fpFwMIkoDw5_zkxdQJ0_EVT9PCnLcOL7UbCoN1C_V26-QJCL2sfWIfD7H5YxYRrPaZ8uQ5LbMlSHe1LLhhUk51y87rfCfCkDFp0_H3Iv3I1KLlVqgs-BF9XEtR-Zc7gTT8-5sobL4mK3trfDGMv1EXN898j0nxFVb6aIXxylRa0G8aP6LiFFSfAB02t8Tq59Zn6EyPC811_xiUhdNaxxyk14w-2i-oVIwnJztyBMDfB-ZWdZBMs9e4FLOSor8qZIUftIWobj_8CK/https%3A%2F%2Fgithub.com%2Fjcross186 👋

— Reply to this email directly, view it on GitHubhttps://secure-web.cisco.com/1cMzKbgTM4kOy59jOboY5rMGYxHsXpaOj30cezZCx_OuMjs-hup49HuhxpRfUrR0zP5-Vw64yI6clWSwGn3eX-d7cE5dBY14lm3LmGkXCc5rkpYSJwx6r3FD_iq828Iw-63bx3T6Tc1m2Pr5n2ddwhWEBDhchVb62bxN20qhjfHfZQ_PJRrlZRD9JVyvVTIjIig4nIdS5szcmKhQozsKz1ssf0ASrj5cl8LQzvbIsAwCjtk49y_jLD7oEtjdTt1WuPGVV6RVa5MNNlBUiraaDo43ba_9DtPz_JEBxK7QDRjd-EaPKoMcOiMoId9SSgRML/https%3A%2F%2Fgithub.com%2Fopenjournals%2Fjoss-reviews%2Fissues%2F7252%23issuecomment-2377347414, or unsubscribehttps://secure-web.cisco.com/14Nq3qR11Tka8rwttGe-HF2fj3_5T4WEecrrny8gf_LueP3lTcmLynsLImSaTPxVGywytJYp42sMSohc-D1cJaNzS0qTFkO1kHRo3UFdBoflKXOlcwOJqm6zzaYhY_Y2Ub3ZUwEY5U4DgEWsJM7Np8kW9rOCJ_V7WcPIpPKlBIdBn77RaMFSEP27p1SyWSXd4ESsSOcy_vUggtOW1YVxGk2WWrSjOfK0RAHRxeblOdWWmCNTm9-M67p2gnxs6VIvQYhwpMQdG3HOkDLiqGOchyNNNMjLJrXPm1duyk7QV6pYSFJjzwFfrmVeQD0peNBik/https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA62BFANZOHXEJZJPCTH75LZYQUQPAVCNFSM6AAAAABOSHBOGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZXGM2DONBRGQ. You are receiving this because you were mentioned.Message ID: @.***> The information in this e-mail is intended only for the person to whom it is addressed. If you believe this e-mail was sent to you in error and the e-mail contains patient information, please contact the Mass General Brigham Compliance HelpLine at https://www.massgeneralbrigham.org/complianceline https://www.massgeneralbrigham.org/complianceline . Please note that this e-mail is not secure (encrypted). If you do not wish to continue communication over unencrypted e-mail, please notify the sender of this message immediately. Continuing to send or respond to e-mail after receiving this message means you understand and accept this risk and wish to continue to communicate over unencrypted e-mail.

Kevin-Mattheus-Moerman commented 1 month ago

@editorialbot check references

editorialbot commented 1 month ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1037/met0000359 is OK
- 10.1016/j.alcr.2019.100323 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1016/j.eclinm.2023.102408 is OK
- 10.1109/TMI.2016.2608782 is OK
- 10.1056/NEJMoa1411532 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: pandas-dev/pandas: Pandas 1.0. 5
- No DOI given, and none found for title: PyTorch: An Imperative Style, High-Performance Dee...
- No DOI given, and none found for title: Array programming with NumPy
- No DOI given, and none found for title: Longitudinal modeling of lung function trajectorie...
- No DOI given, and none found for title: Lung function trajectories in health and disease
- No DOI given, and none found for title: COPDGene\textregistered 2019: redefining the diagn...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
Kevin-Mattheus-Moerman commented 1 month ago

@editorialbot generate pdf

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 month ago

Five most similar historical JOSS papers:

PyNM: a Lightweight Python implementation of Normative Modeling Submitting author: @harveyaa Handling editor: @dfm (Active) Reviewers: @smkia, @saigerutherford Similarity score: 0.6773

pypfilt: a particle filter for Python Submitting author: @robmoss Handling editor: @diehlpk (Active) Reviewers: @tbrown122387, @Karangupta1994 Similarity score: 0.6657

Akmedoids R package for generating directionally-homogeneous clusters of longitudinal data sets Submitting author: @MAnalytics Handling editor: @karthik (Retired) Reviewers: @karthik, @njtierney Similarity score: 0.6657

PxMCMC: A Python package for proximal Markov Chain Monte Carlo Submitting author: @auggiemarignier Handling editor: @mstimberg (Active) Reviewers: @jeremiecoullon, @mattpitkin Similarity score: 0.6649

ArviZ a unified library for exploratory analysis of Bayesian models in Python Submitting author: @canyon289 Handling editor: @arfon (Active) Reviewers: @malmaud, @mattpitkin Similarity score: 0.6633

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

Kevin-Mattheus-Moerman commented 1 month ago

@editorialbot invite @majensen as editor

editorialbot commented 1 month ago

Invitation to edit this submission sent!

majensen commented 1 month ago

@editorialbot assign me as editor

editorialbot commented 1 month ago

Assigned! @majensen is now the editor

majensen commented 1 month ago

Hi @jcross186 - if you have time, can you browse https://reviewers.joss.theoj.org/lookup for reviewers that you think might be appropriate? You can put usernames without the @ sign in this thread. This can help speed up the review process - much appreciated!

jcross186 commented 1 month ago

Hi Mark,

Here are a few:

gvieralopez limengbinggz mrazomej matteodelucchi gchure nhtran93 lindemann09

Kind regards,

-James

From: Mark Jensen @.> Date: Friday, September 27, 2024 at 2:31 PM To: openjournals/joss-reviews @.> Cc: Ross, James Chapman,Ph.D. @.>, Mention @.> Subject: Re: [openjournals/joss-reviews] [PRE REVIEW]: bayes_traj: A Python package for Bayesian trajectory analysis (Issue #7252)

    External Email - Use Caution

Hi @jcross186https://secure-web.cisco.com/1SB-a5bWxLXgWVKhRmRAiH585-ohye_sUTeW81fMSeFg_zgIa5kHHPZPYGgTdhqhfWKoYlDg3lqIP_YzH8uRnLj_1WJonPYSf_OukSQI6v5wJ5pEm-lCwKQOheV-I5nwar4RU1VCu7RWC5KSvpMjP0iKKE277EPYVT6A9l7K2HJl6iamgw_NN_moQKwlgekF88w9eAn73imKADAPyUYnjH2m4_xjVDdzU2Ck6pPyXCksN7uQKqYkiIbxB4krua6Us8JSODOUI90ZtMWE4bLbAFrNl_RhV-Rsb7GxMNkA7-uQPaj_FSz6K7r8VWvnApOla/https%3A%2F%2Fgithub.com%2Fjcross186 - if you have time, can you browse https://reviewers.joss.theoj.org/lookuphttps://secure-web.cisco.com/1Y1u-L3XUkfHRhUjjmwxWNYr-2RyyqFAKrVuN2cJEJpamL-Y1iS_LwRCwWhs3XQ_wnEl2Ykx58GM4PzNPrmnK5VskGFLrbjMp8RlSWBsEGndwJhl8YYKwhCZ1OY6zGjgFjYHOLxJMAmQPCBT9GfGAgJDqd8mAzJLS6MXzRFJIs-b8GwTIdVvE7meY45T-FP4JUCoMtHSb9J5k8xhb5wijE1I_FYmxoYqg07T9ZpMAM0zG_d1GmN04VrUS64em21KRzdPD8Ebq-Jm5j0wovt4Y17saFQDr7uJe3LCvWXFa5QxtDrrC6w_S2nb6xrYgo4AZ/https%3A%2F%2Freviewers.joss.theoj.org%2Flookup for reviewers that you think might be appropriate? You can put usernames without the @ sign in this thread. This can help speed up the review process - much appreciated!

— Reply to this email directly, view it on GitHubhttps://secure-web.cisco.com/1O-cuHeAf3RalfV5ZqabqH6ibEU2xEnmDNyQL-T_-jYHv3k9RJlZW-y5TDMpv1sPfvRtFZH-Of9bV7IqLKyfP2nZc30DA7cf6RivnnBnVqQTMSkrfnpBoYPjeRZcy9RYLtraNbJhBbjCM-dbnazkFwqEWoOes00HZJEJkGUpAamdGMT8dr4oR54FX0adhi0-EtyFaAVhRfAhUgFwWRtUomVqAPBoVlE6j-DLlJME1yb4bzZvyhjaE8qLktK7npye11lvJIHrvP238A51BBoj5bdqAOel-ddxX-ieUOS0TJRU-2vKuj5KI5CS8pcKJQ6X8/https%3A%2F%2Fgithub.com%2Fopenjournals%2Fjoss-reviews%2Fissues%2F7252%23issuecomment-2379840109, or unsubscribehttps://secure-web.cisco.com/1A6pZnaa6zoQxW2k8zG6OmEb4MnXnK2ZTiEkxu9bnq5nExmgDnYC0SLc2gXucjjXh3Fcj49qNbKw8e03GavT35h7Qd4gykiqGRShlvIexqyppUPuC6mzo_s0EEPYWRQY2rnXE9b1o4lTBZml1msi8l-_Ya0m2uYQGZzoEUogYXxkD6O6vg_ojT0TJHwk6SP60n1ujsQGJ1BPiE3Et-goLxu3t1T8Vk583ba3ZL1yMlWKS6oXcrEaaJ5nA1s2DtvVcwRN9HtqqneTbCubd6vVY2BJIRVt5lSua2O3gWRurFDFhzHW6lpHD93Xvbg5qlvKy/https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA62BFCXM3QQT4X4LS76S6TZYWP6DAVCNFSM6AAAAABOSHBOGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZZHA2DAMJQHE. You are receiving this because you were mentioned.Message ID: @.***> The information in this e-mail is intended only for the person to whom it is addressed. If you believe this e-mail was sent to you in error and the e-mail contains patient information, please contact the Mass General Brigham Compliance HelpLine at https://www.massgeneralbrigham.org/complianceline https://www.massgeneralbrigham.org/complianceline . Please note that this e-mail is not secure (encrypted). If you do not wish to continue communication over unencrypted e-mail, please notify the sender of this message immediately. Continuing to send or respond to e-mail after receiving this message means you understand and accept this risk and wish to continue to communicate over unencrypted e-mail.

majensen commented 1 month ago

Hi @gvieralopez - would you be willing to review this work for JOSS? We could use your expertise. Thanks for considering! --@majensen

majensen commented 1 month ago

Hello @lindemann09 - would you have time to review this software for JOSS? Thank you for your consideration. --@majensen

majensen commented 1 month ago

Hi @mrazomej - would you consider reviewing this work for JOSS? We would appreciate your expertise. Thanks --@majensen

lindemann09 commented 1 month ago

Yes

gvieralopez commented 1 month ago

Hi @gvieralopez - would you be willing to review this work for JOSS? We could use your expertise. Thanks for considering! --@majensen

Yes

majensen commented 1 month ago

@editorialbot add @gvieralopez as reviewer

editorialbot commented 1 month ago

@gvieralopez added to the reviewers list!

majensen commented 1 month ago

@editorialbot add @lindemann09 as reviewer

editorialbot commented 1 month ago

@lindemann09 added to the reviewers list!

majensen commented 1 month ago

@editorialbot start review

editorialbot commented 1 month ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/7323.